From 1df89913ad445a5c9627ab4970825accc634305c Mon Sep 17 00:00:00 2001
From: Kyrylo Silin <silin@kyrylo.org>
Date: Sat, 2 Mar 2019 13:31:20 +0200
Subject: [PATCH] rubocop: fix offences of the Style/RedundantParentheses cop

---
 .rubocop_todo.yml                 | 13 -------------
 lib/pry/command.rb                |  2 +-
 lib/pry/commands/ls/local_vars.rb |  2 +-
 lib/pry/indent.rb                 |  2 +-
 spec/command_integration_spec.rb  |  2 +-
 spec/commands/edit_spec.rb        |  2 +-
 spec/fixtures/example_nesting.rb  |  2 +-
 spec/method_spec.rb               |  2 +-
 8 files changed, 7 insertions(+), 20 deletions(-)

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index a522d4fe..dce8efce 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -314,19 +314,6 @@ Style/PerlBackrefs:
     - 'lib/pry/method.rb'
     - 'lib/pry/rubygem.rb'
 
-# Offense count: 8
-# Cop supports --auto-correct.
-Style/RedundantParentheses:
-  Exclude:
-    - 'lib/pry/command.rb'
-    - 'lib/pry/commands/ls/jruby_hacks.rb'
-    - 'lib/pry/commands/ls/local_vars.rb'
-    - 'lib/pry/indent.rb'
-    - 'spec/command_integration_spec.rb'
-    - 'spec/commands/edit_spec.rb'
-    - 'spec/fixtures/example_nesting.rb'
-    - 'spec/method_spec.rb'
-
 # Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleReturnValues.
diff --git a/lib/pry/command.rb b/lib/pry/command.rb
index f58c8a3e..3585d097 100644
--- a/lib/pry/command.rb
+++ b/lib/pry/command.rb
@@ -421,7 +421,7 @@ class Pry
         gems_not_installed = gems_needed.reject { |g| Rubygem.installed?(g) }
         output.puts(<<WARN)
 The command #{Helpers::Text.bold(command_name)} is unavailable because it requires the following
-gems to be installed: #{(gems_not_installed.join(", "))}
+gems to be installed: #{gems_not_installed.join(", ")}
 
 Type #{Helpers::Text.bold('install-command ' + command_name)} to install the required gems
 and activate this command.
diff --git a/lib/pry/commands/ls/local_vars.rb b/lib/pry/commands/ls/local_vars.rb
index 5bdd66b1..816160c4 100644
--- a/lib/pry/commands/ls/local_vars.rb
+++ b/lib/pry/commands/ls/local_vars.rb
@@ -12,7 +12,7 @@ class Pry
           name_value_pairs = @target.eval('local_variables').reject do |e|
             @sticky_locals.key?(e.to_sym)
           end.map do |name|
-            [name, (@target.eval(name.to_s))]
+            [name, @target.eval(name.to_s)]
           end
           format(name_value_pairs).join('')
         end
diff --git a/lib/pry/indent.rb b/lib/pry/indent.rb
index 5ee29a98..27ca281d 100644
--- a/lib/pry/indent.rb
+++ b/lib/pry/indent.rb
@@ -215,7 +215,7 @@ class Pry
       # If the list of tokens contains a matching closing token the line should
       # not be indented (and thus we should return true).
       tokens.each do |token, kind|
-        is_singleline_if = (SINGLELINE_TOKENS.include?(token)) && end_of_statement?(last_token, last_kind)
+        is_singleline_if = SINGLELINE_TOKENS.include?(token) && end_of_statement?(last_token, last_kind)
         is_optional_do = (token == "do" && seen_for_at.include?(add_after - 1))
 
         unless kind == :space
diff --git a/spec/command_integration_spec.rb b/spec/command_integration_spec.rb
index e66fe067..bb7d7de5 100644
--- a/spec/command_integration_spec.rb
+++ b/spec/command_integration_spec.rb
@@ -349,7 +349,7 @@ describe "commands" do
   end
 
   it 'should create a command in a nested context and that command should be accessible from the parent' do
-    expect(pry_tester(Object.new).eval(*(<<-RUBY.split("\n")))).to match(/instance variables:\s+@x/m)
+    expect(pry_tester(Object.new).eval(*<<-RUBY.split("\n"))).to match(/instance variables:\s+@x/m)
       @x = nil
       cd 7
       _pry_.commands.instance_eval { command('bing') { |arg| run arg } }
diff --git a/spec/commands/edit_spec.rb b/spec/commands/edit_spec.rb
index 059e6af9..531a55c8 100644
--- a/spec/commands/edit_spec.rb
+++ b/spec/commands/edit_spec.rb
@@ -459,7 +459,7 @@ describe "edit" do
       before do
         Object.remove_const :X if defined? ::X
         Object.remove_const :A if defined? ::A
-        @tempfile = (Tempfile.new(['pry', '.rb']))
+        @tempfile = Tempfile.new(['pry', '.rb'])
         @tempfile.puts <<-EOS
         module A
           def a
diff --git a/spec/fixtures/example_nesting.rb b/spec/fixtures/example_nesting.rb
index 06c90507..99d91a5e 100644
--- a/spec/fixtures/example_nesting.rb
+++ b/spec/fixtures/example_nesting.rb
@@ -14,7 +14,7 @@ class << A                          # ["class << A"]
   end                               # ["class << A"]
 end                                 # []
                                     # []
-module (:symbol.class)::Exciting    #
+module :symbol.class::Exciting      #
   def foo; end                      #
   class B                           #
     def goo; end                    #
diff --git a/spec/method_spec.rb b/spec/method_spec.rb
index f4fdd885..db85c121 100644
--- a/spec/method_spec.rb
+++ b/spec/method_spec.rb
@@ -482,7 +482,7 @@ describe Pry::Method do
       end
 
       it "should include modules at the point which they would be reached" do
-        expect(Pry::Method.resolution_order(LS::Bottom)).to eq [eigen_class(LS::Bottom), LS::O] + (Pry::Method.resolution_order(LS::Lower))
+        expect(Pry::Method.resolution_order(LS::Bottom)).to eq [eigen_class(LS::Bottom), LS::O] + Pry::Method.resolution_order(LS::Lower)
       end
 
       it "should include the Pry::Method.instance_resolution_order of Class after the singleton classes" do