Bump rubocop to v0.65.0 and generate config

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-11-04 17:42:27 +0800 using RuboCop version 0.59.2.
+# on 2019-02-24 19:58:43 +0200 using RuboCop version 0.65.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -31,7 +31,7 @@ Layout/AlignArray:
     - 'lib/pry/commands/ls/ls_entity.rb'
     - 'spec/pry_spec.rb'
 
-# Offense count: 3
+# Offense count: 34
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
 # SupportedHashRocketStyles: key, separator, table
@@ -39,6 +39,9 @@ Layout/AlignArray:
 # SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
 Layout/AlignHash:
   Exclude:
+    - 'lib/pry/code/code_file.rb'
+    - 'lib/pry/helpers/text.rb'
+    - 'lib/pry/indent.rb'
     - 'spec/pry_defaults_spec.rb'
     - 'spec/sticky_locals_spec.rb'
 
@@ -54,13 +57,11 @@ Layout/BlockAlignment:
     - 'spec/commands/show_source_spec.rb'
     - 'spec/indent_spec.rb'
 
-# Offense count: 5
+# Offense count: 1
 # Cop supports --auto-correct.
 Layout/BlockEndNewline:
   Exclude:
-    - 'lib/pry/code.rb'
     - 'spec/completion_spec.rb'
-    - 'spec/prompt_spec.rb'
 
 # Offense count: 3
 # Cop supports --auto-correct.
@@ -113,10 +114,11 @@ Layout/EmptyComment:
   Exclude:
     - 'spec/command_spec.rb'
 
-# Offense count: 1
+# Offense count: 2
 # Cop supports --auto-correct.
 Layout/EmptyLineAfterMagicComment:
   Exclude:
+    - 'lib/pry/pry_instance.rb'
     - 'lib/pry/terminal.rb'
 
 # Offense count: 10
@@ -141,12 +143,11 @@ Layout/EmptyLinesAroundExceptionHandlingKeywords:
     - 'lib/pry/method.rb'
     - 'lib/pry/method/patcher.rb'
 
-# Offense count: 3
+# Offense count: 2
 # Cop supports --auto-correct.
 Layout/EmptyLinesAroundMethodBody:
   Exclude:
     - 'lib/pry/code_object.rb'
-    - 'lib/pry/editor.rb'
     - 'lib/pry/indent.rb'
 
 # Offense count: 16
@@ -191,14 +192,13 @@ Layout/IndentAssignment:
   Exclude:
     - 'lib/pry/helpers/text.rb'
 
-# Offense count: 6
+# Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: special_inside_parentheses, consistent, align_braces
 Layout/IndentHash:
   Exclude:
     - 'lib/pry/commands/ls.rb'
-    - 'lib/pry/config/default.rb'
     - 'lib/pry/pry_instance.rb'
 
 # Offense count: 9
@@ -248,7 +248,7 @@ Layout/MultilineHashBraceLayout:
   Exclude:
     - 'lib/pry/pry_instance.rb'
 
-# Offense count: 11
+# Offense count: 9
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: symmetrical, new_line, same_line
@@ -256,7 +256,6 @@ Layout/MultilineMethodCallBraceLayout:
   Exclude:
     - 'lib/pry/cli.rb'
     - 'lib/pry/helpers/options_helpers.rb'
-    - 'lib/pry/pry_instance.rb'
     - 'spec/commands/ls_spec.rb'
     - 'spec/commands/reload_code_spec.rb'
 
@@ -271,7 +270,7 @@ Layout/MultilineMethodCallIndentation:
     - 'spec/command_set_spec.rb'
     - 'spec/pry_defaults_spec.rb'
 
-# Offense count: 14
+# Offense count: 13
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: aligned, indented
@@ -294,7 +293,7 @@ Layout/RescueEnsureAlignment:
     - 'lib/pry/command_set.rb'
     - 'lib/pry/pager.rb'
 
-# Offense count: 35
+# Offense count: 30
 # Cop supports --auto-correct.
 Layout/SpaceAfterComma:
   Exclude:
@@ -302,7 +301,6 @@ Layout/SpaceAfterComma:
     - 'lib/pry/commands/find_method.rb'
     - 'lib/pry/commands/gem_list.rb'
     - 'lib/pry/config/behavior.rb'
-    - 'lib/pry/config/memoization.rb'
     - 'lib/pry/helpers/table.rb'
     - 'spec/commands/play_spec.rb'
     - 'spec/commands/raise_up_spec.rb'
@@ -310,23 +308,20 @@ Layout/SpaceAfterComma:
     - 'spec/pry_defaults_spec.rb'
     - 'spec/syntax_checking_spec.rb'
 
-# Offense count: 9
+# Offense count: 5
 # Cop supports --auto-correct.
 Layout/SpaceAfterSemicolon:
   Exclude:
-    - 'spec/command_set_spec.rb'
-    - 'spec/commands/help_spec.rb'
     - 'spec/commands/show_doc_spec.rb'
     - 'spec/commands/show_source_spec.rb'
     - 'spec/commands/whereami_spec.rb'
 
-# Offense count: 8
+# Offense count: 3
 # Cop supports --auto-correct.
 Layout/SpaceBeforeComma:
   Exclude:
     - 'lib/pry/commands/hist.rb'
     - 'lib/pry/helpers/text.rb'
-    - 'spec/pry_defaults_spec.rb'
     - 'spec/sticky_locals_spec.rb'
 
 # Offense count: 5
@@ -336,7 +331,7 @@ Layout/SpaceBeforeSemicolon:
     - 'spec/commands/show_doc_spec.rb'
     - 'spec/method_spec.rb'
 
-# Offense count: 7
+# Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
 # SupportedStyles: space, no_space, compact
@@ -345,7 +340,6 @@ Layout/SpaceInsideArrayLiteralBrackets:
   Exclude:
     - 'lib/pry/input_completer.rb'
     - 'spec/history_spec.rb'
-    - 'spec/pry_defaults_spec.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
@@ -362,10 +356,8 @@ Layout/SpaceInsideHashLiteralBraces:
   Exclude:
     - 'lib/pry/commands/gem_stats.rb'
     - 'lib/pry/commands/help.rb'
-    - 'lib/pry/config/default.rb'
     - 'spec/command_set_spec.rb'
     - 'spec/commands/gist_spec.rb'
-    - 'spec/config/memoization_spec.rb'
     - 'spec/config_spec.rb'
     - 'spec/method_spec.rb'
     - 'spec/sticky_locals_spec.rb'
@@ -379,7 +371,7 @@ Layout/SpaceInsideParens:
     - 'spec/pry_defaults_spec.rb'
     - 'spec/sticky_locals_spec.rb'
 
-# Offense count: 24
+# Offense count: 25
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: space, no_space
@@ -398,23 +390,13 @@ Layout/SpaceInsideStringInterpolation:
     - 'spec/commands/edit_spec.rb'
     - 'spec/history_spec.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: final_newline, final_blank_line
-Layout/TrailingBlankLines:
-  Exclude:
-    - 'spec/unrescued_exceptions_spec.rb'
-
-# Offense count: 13
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: AllowInHeredoc.
 Layout/TrailingWhitespace:
   Exclude:
     - 'lib/pry/color_printer.rb'
     - 'lib/pry/testable/variables.rb'
-    - 'spec/color_printer_spec.rb'
-    - 'spec/indent_spec.rb'
 
 # Offense count: 3
 Lint/Debugger:
@@ -474,7 +456,7 @@ Lint/ShadowedException:
   Exclude:
     - 'lib/pry/method.rb'
 
-# Offense count: 36
+# Offense count: 33
 Lint/UnderscorePrefixedVariableName:
   Enabled: false
 
@@ -489,11 +471,11 @@ Lint/Void:
   Exclude:
     - 'lib/pry/helpers/table.rb'
 
-# Offense count: 100
+# Offense count: 103
 Metrics/AbcSize:
-  Max: 130
+  Max: 48
 
-# Offense count: 177
+# Offense count: 178
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
@@ -504,31 +486,26 @@ Metrics/BlockLength:
 Metrics/BlockNesting:
   Max: 4
 
-# Offense count: 20
+# Offense count: 19
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
   Max: 333
 
-# Offense count: 30
+# Offense count: 31
 Metrics/CyclomaticComplexity:
   Max: 32
 
-# Offense count: 108
+# Offense count: 116
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 132
 
-# Offense count: 1
-# Configuration parameters: CountComments.
-Metrics/ModuleLength:
-  Max: 126
-
 # Offense count: 1
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 6
 
-# Offense count: 27
+# Offense count: 28
 Metrics/PerceivedComplexity:
   Max: 25
 
@@ -579,12 +556,6 @@ Naming/MemoizedInstanceVariableName:
   Exclude:
     - 'lib/pry/wrapped_module/candidate.rb'
 
-# Offense count: 5
-# Configuration parameters: .
-# SupportedStyles: snake_case, camelCase
-Naming/MethodName:
-  EnforcedStyle: snake_case
-
 # Offense count: 26
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
 # AllowedNames: io, id, to, by, on, in, at, ip, db
@@ -633,13 +604,6 @@ Performance/Size:
   Exclude:
     - 'spec/history_spec.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect.
-Performance/StartWith:
-  Exclude:
-    - 'lib/pry/platform.rb'
-
 # Offense count: 4
 # Cop supports --auto-correct.
 Performance/StringReplacement:
@@ -706,7 +670,7 @@ Style/AsciiComments:
     - 'lib/pry/pry_instance.rb'
     - 'lib/pry/terminal.rb'
 
-# Offense count: 14
+# Offense count: 12
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: braces, no_braces, context_dependent
@@ -715,18 +679,16 @@ Style/BracesAroundHashParameters:
     - 'lib/pry/command_set.rb'
     - 'lib/pry/commands/help.rb'
     - 'lib/pry/commands/ls.rb'
-    - 'lib/pry/config/default.rb'
     - 'lib/pry/pry_instance.rb'
     - 'spec/command_set_spec.rb'
-    - 'spec/config/memoization_spec.rb'
     - 'spec/config_spec.rb'
     - 'spec/method_spec.rb'
 
-# Offense count: 34
+# Offense count: 39
 Style/CaseEquality:
   Enabled: false
 
-# Offense count: 96
+# Offense count: 95
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
@@ -764,11 +726,11 @@ Style/ConditionalAssignment:
     - 'lib/pry/testable/pry_tester.rb'
     - 'lib/pry/wrapped_module.rb'
 
-# Offense count: 159
+# Offense count: 154
 Style/Documentation:
   Enabled: false
 
-# Offense count: 17
+# Offense count: 11
 Style/DoubleNegation:
   Exclude:
     - 'lib/pry/code.rb'
@@ -778,7 +740,6 @@ Style/DoubleNegation:
     - 'lib/pry/method.rb'
     - 'lib/pry/method/weird_method_locator.rb'
     - 'lib/pry/pager.rb'
-    - 'lib/pry/platform.rb'
     - 'lib/pry/slop/option.rb'
     - 'lib/pry/wrapped_module.rb'
 
@@ -879,7 +840,7 @@ Style/GlobalVars:
   Exclude:
     - 'spec/commands/edit_spec.rb'
 
-# Offense count: 38
+# Offense count: 37
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false
@@ -913,14 +874,13 @@ Style/InverseMethods:
     - 'lib/pry/commands/ls/jruby_hacks.rb'
     - 'lib/pry/commands/ls/ls_entity.rb'
 
-# Offense count: 4
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: line_count_dependent, lambda, literal
 Style/Lambda:
   Exclude:
     - 'lib/pry/commands/ls/methods.rb'
-    - 'spec/pry_output_spec.rb'
     - 'spec/pry_spec.rb'
 
 # Offense count: 5
@@ -965,15 +925,14 @@ Style/MissingRespondToMissing:
     - 'lib/pry/plugins.rb'
     - 'lib/pry/wrapped_module.rb'
 
-# Offense count: 4
+# Offense count: 3
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
+# Configuration parameters: EnforcedStyle, Autocorrect.
 # SupportedStyles: module_function, extend_self
 Style/ModuleFunction:
   Exclude:
     - 'lib/pry/helpers/base_helpers.rb'
     - 'lib/pry/helpers/text.rb'
-    - 'lib/pry/platform.rb'
     - 'lib/pry/testable.rb'
 
 # Offense count: 8
@@ -988,8 +947,10 @@ Style/MultipleComparison:
   Exclude:
     - 'lib/pry/indent.rb'
 
-# Offense count: 36
+# Offense count: 48
 # Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: literals, strict
 Style/MutableConstant:
   Enabled: false
 
@@ -1034,12 +995,11 @@ Style/NonNilCheck:
   Exclude:
     - 'lib/pry/helpers/base_helpers.rb'
 
-# Offense count: 5
+# Offense count: 4
 # Cop supports --auto-correct.
 Style/Not:
   Exclude:
     - 'lib/pry/method/weird_method_locator.rb'
-    - 'lib/pry/platform.rb'
     - 'lib/pry/pry_class.rb'
     - 'lib/pry/testable.rb'
 
@@ -1053,13 +1013,11 @@ Style/NumericLiteralPrefix:
     - 'spec/history_spec.rb'
     - 'spec/pryrc_spec.rb'
 
-# Offense count: 31
+# Offense count: 24
 # Cop supports --auto-correct.
 Style/ParallelAssignment:
   Exclude:
-    - 'lib/pry/command.rb'
     - 'lib/pry/command_set.rb'
-    - 'lib/pry/commands/show_info.rb'
     - 'lib/pry/hooks.rb'
     - 'lib/pry/indent.rb'
     - 'lib/pry/method.rb'
@@ -1070,7 +1028,6 @@ Style/ParallelAssignment:
     - 'lib/pry/slop.rb'
     - 'spec/commands/cd_spec.rb'
     - 'spec/commands/whereami_spec.rb'
-    - 'spec/prompt_spec.rb'
     - 'spec/pry_defaults_spec.rb'
 
 # Offense count: 57
@@ -1094,22 +1051,14 @@ Style/PercentLiteralDelimiters:
     - 'spec/syntax_checking_spec.rb'
     - 'spec/wrapped_module_spec.rb'
 
-# Offense count: 54
+# Offense count: 10
 # Cop supports --auto-correct.
 Style/PerlBackrefs:
   Exclude:
-    - 'lib/pry/command.rb'
-    - 'lib/pry/commands/edit/file_and_line_locator.rb'
-    - 'lib/pry/commands/shell_command.rb'
-    - 'lib/pry/commands/show_info.rb'
-    - 'lib/pry/helpers/documentation_helpers.rb'
     - 'lib/pry/input_completer.rb'
     - 'lib/pry/last_exception.rb'
     - 'lib/pry/method.rb'
     - 'lib/pry/rubygem.rb'
-    - 'lib/pry/slop.rb'
-    - 'lib/pry/slop/option.rb'
-    - 'lib/pry/terminal.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
@@ -1253,14 +1202,14 @@ Style/StderrPuts:
   Exclude:
     - 'lib/pry/slop.rb'
 
-# Offense count: 2305
+# Offense count: 2271
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
   Enabled: false
 
-# Offense count: 21
+# Offense count: 20
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: single_quotes, double_quotes
@@ -1275,7 +1224,7 @@ Style/StringLiteralsInInterpolation:
     - 'spec/helper.rb'
     - 'spec/syntax_checking_spec.rb'
 
-# Offense count: 11
+# Offense count: 10
 # Cop supports --auto-correct.
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets
@@ -1337,7 +1286,7 @@ Style/TrivialAccessors:
     - 'lib/pry/pager.rb'
     - 'lib/pry/pry_class.rb'
 
-# Offense count: 3
+# Offense count: 4
 # Cop supports --auto-correct.
 Style/UnneededCondition:
   Exclude:
@@ -1378,7 +1327,7 @@ Style/WhileUntilModifier:
     - 'lib/pry/helpers/table.rb'
     - 'lib/pry/method.rb'
 
-# Offense count: 12
+# Offense count: 10
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, MinSize, WordRegex.
 # SupportedStyles: percent, brackets
@@ -1393,12 +1342,11 @@ Style/WordArray:
     - 'spec/history_spec.rb'
     - 'spec/hooks_spec.rb'
     - 'spec/method_spec.rb'
-    - 'spec/pry_defaults_spec.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: all_comparison_operators, equality_operators_only
+# SupportedStyles: forbid_for_all_comparison_operators, forbid_for_equality_operators_only, require_for_all_comparison_operators, require_for_equality_operators_only
 Style/YodaCondition:
   Exclude:
     - 'lib/pry/helpers/table.rb'
@@ -1414,7 +1362,7 @@ Style/ZeroLengthPredicate:
     - 'lib/pry/commands/help.rb'
     - 'lib/pry/testable/evalable.rb'
 
-# Offense count: 854
+# Offense count: 869
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:

Gemfile

@@ -8,7 +8,7 @@ group :development do
 
   # Rubocop supports only >=2.2.0
   if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.2.0')
-    gem 'rubocop', '= 0.59.2', require: false
+    gem 'rubocop', '= 0.65.0', require: false
   end
 end