kotovalexarian-likes-github/pry--pry
1
0
Fork 0
mirror of https://github.com/pry/pry.git synced 2022-11-09 12:35:05 -05:00
Code Releases Activity

Fix a bug where Pry::Config.new(nil) == nil would return true. (#1903)

Browse source
This commit is contained in:
r-obert 2018-12-05 22:18:31 +01:00 • committed by GitHub
parent b5538b8501
commit 54e6ce52f7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/pry/config/behavior.rb
View file

@ -215,6 +215,8 @@ class Pry
# True if self and `other` are considered `eql?`, otherwise false.
#
def ==(other)
return false if !other
@lookup == __try_convert_to_hash(other)
end
alias_method :eql?, :==

48
spec/config_spec.rb
View file

@ -1,4 +1,24 @@
describe Pry::Config do
RSpec.describe Pry::Config do
describe ".from_hash" do
it "returns an object without a default" do
local = described_class.from_hash({})
expect(local.default).to eq(nil)
end
it "returns an object with a default" do
default = described_class.new(nil)
local = described_class.from_hash({}, default)
expect(local.default).to eq(local)
end
it "recursively creates Pry::Config objects from a Hash" do
h = {'foo1' => {'foo2' => {'foo3' => 'foobar'}}}
default = described_class.from_hash(h)
expect(default.foo1).to be_instance_of(described_class)
expect(default.foo1.foo2).to be_instance_of(described_class)
end
end
describe "bug #1552" do
specify "a local key has precendence over its default when the stored value is false" do
local = described_class.from_hash({}, described_class.from_hash('color' => true))
@ -53,26 +73,6 @@ describe Pry::Config do
end
end
describe ".from_hash" do
it "returns an object without a default" do
local = described_class.from_hash({})
expect(local.default).to eq(nil)
end
it "returns an object with a default" do
default = described_class.new(nil)
local = described_class.from_hash({}, default)
expect(local.default).to eq(local)
end
it "recursively creates Pry::Config objects from a Hash" do
h = {'foo1' => {'foo2' => {'foo3' => 'foobar'}}}
default = described_class.from_hash(h)
expect(default.foo1).to be_instance_of(described_class)
expect(default.foo1.foo2).to be_instance_of(described_class)
end
end
describe "#respond_to_missing?" do
before do
@config = described_class.new(nil)
@ -140,6 +140,12 @@ describe Pry::Config do
local1 = described_class.new(nil)
expect(local1).not_to eq(Object.new)
end
it "returns false when compared against nil" do
# rubocop:disable Style/NilComparison
expect(described_class.new(nil) == nil).to eq(false)
# rubocop:enable Style/NilComparison
end
end
describe "#forget" do