From 25f5022fcf3c43c43bfdb10ff2c1dc60588b9fa6 Mon Sep 17 00:00:00 2001 From: Barrett Ingram Date: Sat, 2 Jan 2021 17:53:36 -0600 Subject: [PATCH] Add CI support for ruby 3 and fix broken spec Spec started failing because a statement which we expected to be a syntax error is now interpreted as a valid pattern-matching statement. Swapping the hash-rockets for colons turns this back into a syntax error. --- .circleci/config.yml | 13 +++++++++++++ spec/syntax_checking_spec.rb | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 7a7a0876..3f55e1d2 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -138,6 +138,15 @@ jobs: - <<: *bundle_install - <<: *install_ubuntu_nano - <<: *unit + "ruby-3.0": + docker: + - image: circleci/ruby:3.0 + working_directory: ~/pry + steps: + - <<: *repo_restore_cache + - <<: *bundle_install + - <<: *install_ubuntu_nano + - <<: *unit "jruby-9.1-jdk": docker: - image: circleci/jruby:9.1-jdk @@ -199,6 +208,10 @@ workflows: requires: - rubocop_lint - yard_lint + - "ruby-3.0": + requires: + - rubocop_lint + - yard_lint - "jruby-9.1-jdk": requires: - rubocop_lint diff --git a/spec/syntax_checking_spec.rb b/spec/syntax_checking_spec.rb index ca75ba9f..beba497f 100644 --- a/spec/syntax_checking_spec.rb +++ b/spec/syntax_checking_spec.rb @@ -36,7 +36,7 @@ describe Pry do ["o = Object.new.tap{ def o.render;", "'MEH'", "}"], # multiple syntax errors reported in one SyntaxException - ["puts {'key'=>'val'}.to_json"] + ["puts {key: 'val'}.to_json"] ].compact.each do |foo| it "should raise an error on invalid syntax like #{foo.inspect}" do redirect_pry_io(InputTester.new(*foo), @str_output) do