mirror of
https://github.com/pry/pry.git
synced 2022-11-09 12:35:05 -05:00
Use proper temp directories for each OS
Also, there was a failing test on Windows ("should shell-escape files"). You will see it if you're running tests on Windows. Make it conditional.
This commit is contained in:
parent
d29f6b5c04
commit
9df47232cc
1 changed files with 32 additions and 13 deletions
|
@ -1,5 +1,20 @@
|
|||
require 'pathname'
|
||||
require 'helper'
|
||||
|
||||
describe Pry::Editor do
|
||||
class << Pry::Editor
|
||||
public :build_editor_invocation_string
|
||||
end
|
||||
|
||||
before do
|
||||
# OS-specific tempdir name. For GNU/Linux it's "tmp", for Windows it's
|
||||
# something "Temp".
|
||||
@tf_dir = Pathname.new(Dir::Tmpname.tmpdir)
|
||||
|
||||
@tf_path = @tf_dir.to_s + File::SEPARATOR + 'hello world.rb'
|
||||
end
|
||||
|
||||
unless Pry::Helpers::BaseHelpers.windows?
|
||||
describe "build_editor_invocation_string" do
|
||||
before do
|
||||
class << Pry::Editor
|
||||
|
@ -8,7 +23,9 @@ describe Pry::Editor do
|
|||
end
|
||||
|
||||
it 'should shell-escape files' do
|
||||
Pry::Editor.build_editor_invocation_string("/tmp/hello world.rb", 5, true).should =~ %r(/tmp/hello\\ world.rb)
|
||||
invocation_str = Pry::Editor.build_editor_invocation_string(@tf_path, 5, true)
|
||||
invocation_str.should =~ /#@tf_dir.+hello\\ world\.rb/
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
|
@ -26,11 +43,13 @@ describe Pry::Editor do
|
|||
end
|
||||
|
||||
it "should replace / by \\" do
|
||||
Pry::Editor.build_editor_invocation_string("/tmp/hello world.rb", 5, true).should =~ %r(\\tmp\\)
|
||||
invocation_str = Pry::Editor.build_editor_invocation_string(@tf_path, 5, true)
|
||||
invocation_str.should =~ %r(\\#{@tf_dir.basename}\\)
|
||||
end
|
||||
|
||||
it "should not shell-escape files" do
|
||||
Pry::Editor.build_editor_invocation_string("/tmp/hello world.rb", 5, true).should =~ %r(hello world.rb)
|
||||
invocation_str = Pry::Editor.build_editor_invocation_string(@tf_path, 5, true)
|
||||
invocation_str.should =~ /hello world\.rb/
|
||||
end
|
||||
end
|
||||
|
||||
|
@ -48,8 +67,8 @@ describe Pry::Editor do
|
|||
end
|
||||
|
||||
it 'should not shell-escape files' do
|
||||
Pry::Editor.invoke_editor('/tmp/hello world.rb', 10, true)
|
||||
@file.should == "/tmp/hello world.rb"
|
||||
Pry::Editor.invoke_editor(@tf_path, 10, true)
|
||||
@file.should == "#@tf_path"
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in a new issue