mirror of
https://github.com/pry/pry.git
synced 2022-11-09 12:35:05 -05:00
Fix bug in edit regarding file names with path but no suffix
There was a bug in Command::Edit#probably_a_file? due to missing parentheses in a method call followed by an operator.
This commit is contained in:
parent
c7386aebc2
commit
a987a8e7c2
3 changed files with 12 additions and 1 deletions
|
@ -40,6 +40,7 @@
|
|||
being inferred from context (#877)
|
||||
* Rename `--installed-plugins` flag to `--plugins`
|
||||
* Strip ANSI codes from prompt before measuring length for indentation (#493)
|
||||
* Fix bug in `edit` regarding recognition of file names without suffix.
|
||||
|
||||
#### Dev-facing changes
|
||||
* `rake pry` now accepts switches prefixed with `_` (e.g., `rake pry _v`)
|
||||
|
|
|
@ -186,7 +186,7 @@ class Pry
|
|||
end
|
||||
|
||||
def probably_a_file?(str)
|
||||
[".rb", ".c", ".py", ".yml", ".gemspec"].include? File.extname(str) ||
|
||||
[".rb", ".c", ".py", ".yml", ".gemspec"].include?(File.extname(str)) ||
|
||||
str =~ /\/|\\/
|
||||
end
|
||||
|
||||
|
|
|
@ -35,6 +35,16 @@ describe "edit" do
|
|||
FileUtils.rm(@tf_path) if File.exists?(@tf_path)
|
||||
end
|
||||
|
||||
it "should not allow patching any known kind of file" do
|
||||
["file.rb", "file.c", "file.py", "file.yml", "file.gemspec",
|
||||
"/tmp/file", "\\\\Temp\\\\file"].each do |file|
|
||||
proc {
|
||||
pry_eval "edit -p #{file}"
|
||||
}.should.raise(NotImplementedError).
|
||||
message.should =~ /Cannot yet patch false objects!/
|
||||
end
|
||||
end
|
||||
|
||||
it "should invoke Pry.config.editor with absolutified filenames" do
|
||||
pry_eval 'edit lib/pry.rb'
|
||||
@file.should == File.expand_path('lib/pry.rb')
|
||||
|
|
Loading…
Reference in a new issue