rubocop: fix offences of the Performance/RedundantBlockCall cop

.rubocop_todo.yml

@@ -169,15 +169,6 @@ Naming/MemoizedInstanceVariableName:
 Naming/UncommunicativeMethodParamName:
   Enabled: false
 
-# Offense count: 6
-# Cop supports --auto-correct.
-Performance/RedundantBlockCall:
-  Exclude:
-    - 'lib/pry/commands/code_collector.rb'
-    - 'lib/pry/input_lock.rb'
-    - 'lib/pry/slop.rb'
-    - 'spec/command_spec.rb'
-
 # Offense count: 1
 # Cop supports --auto-correct.
 Performance/RedundantMatch:

lib/pry/commands/code_collector.rb

@@ -122,13 +122,13 @@ class Pry
        !args.empty?].count(true) > 1
     end
 
-    def pry_array_content_as_string(array, ranges, &block)
+    def pry_array_content_as_string(array, ranges)
       all = ''
       ranges.each do |range|
         raise CommandError, "Minimum value for range is 1, not 0." if convert_to_range(range).first == 0
 
         ranged_array = Array(array[range]) || []
-        ranged_array.compact.each { |v| all << block.call(v) }
+        ranged_array.compact.each { |v| all << yield(v) }
       end
 
       all

lib/pry/input_lock.rb

@@ -33,7 +33,7 @@ class Pry
 
     # Adds ourselves to the ownership list. The last one in the list may access
     # the input through interruptible_region().
-    def __with_ownership(&block)
+    def __with_ownership
       @mutex.synchronize do
         # Three cases:
         # 1) There are no owners, in this case we are good to go.
@@ -56,7 +56,7 @@ class Pry
         @owners << Thread.current
       end
 
-      block.call
+      yield
     ensure
       @mutex.synchronize do
         # We are releasing any desire to have the input ownership by removing
@@ -73,7 +73,7 @@ class Pry
     def with_ownership(&block)
       # If we are in a nested with_ownership() call (nested pry context), we do nothing.
       nested = @mutex.synchronize { @owners.include?(Thread.current) }
-      nested ? block.call : __with_ownership(&block)
+      nested ? yield : __with_ownership(&block)
     end
 
     def enter_interruptible_region
@@ -103,13 +103,13 @@ class Pry
       retry
     end
 
-    def interruptible_region(&block)
+    def interruptible_region
       enter_interruptible_region
 
       # XXX Note that there is a chance that we get the interrupt right after
       # the readline call succeeded, but we'll never know, and we will retry the
       # call, discarding that piece of input.
-      block.call
+      yield
     rescue Interrupt
       # We were asked to back off. The one requesting the interrupt will be
       # waiting on the conditional for the interruptible flag to change to false.

lib/pry/slop.rb

@@ -496,7 +496,7 @@ class Pry::Slop
       end
     else
       @unknown_options << item if strict? && item =~ /\A--?/
-      block.call(item) if block && !@trash.include?(index)
+      yield(item) if block && !@trash.include?(index)
     end
   end
 

spec/command_spec.rb

@@ -605,7 +605,7 @@ describe "Pry::Command" do
         it "should NOT expose &block in create_command's process method" do
           @set.create_command "walking-spanish", "down the hall", takes_block: true do
             def process(&block)
-              block.call
+              block.call # rubocop:disable Performance/RedundantBlockCall
             end
           end
           @out = StringIO.new