1
0
Fork 0
mirror of https://github.com/pry/pry.git synced 2022-11-09 12:35:05 -05:00

ShowDocSpec: add another random comment to the definition

This commit is rather interesting. Well, maybe not the commit, but the
issue it is aimed to fix. So what's the aim? The aim is to eliminate an
error in the test for the following Ruby implementations: rbx-18mode,
jruby-18mode, jruby-19mode.

See that build for details: https://travis-ci.org/pry/pry/builds/5478834

You may be wondering now: "Kyrylo, what is so interesting in it?".
Heh-heh, sit down right beside me, my covey.

I have a screenshot for you:
http://img-fotki.yandex.ru/get/4125/98991937.11/0_911d2_acdd6798_orig

The screenshot demonstrates the difference between `show-doc` finding
monkey-patches on different Ruby implementations (JRuby and MRI 1.9.3).
Take a closer look at the order of the candidates. It is different in
the abovementioned implementations. That is the reason why the test is
failing. Unfortunately, I couldn't figure out why that is happening.

The fix is simple and it doesn't ruin the idea of the test. However,
I'm leaving that order issue to the greater minds of our civilization.

Uh! Don't forget to check out the description of that commit, because it
is related to this topic:
e926d8c944
This commit is contained in:
Kyrylo Silin 2013-03-14 14:49:34 +02:00
parent b6b6d6b584
commit d05233ecd3

View file

@ -263,7 +263,9 @@ if !PryTestHelpers.mri18_and_no_real_source_location?
end
describe "messages relating to -a" do
it 'indicates all available monkeypatches can be shown with -a when (when -a not used and more than one candidate exists for class)' do
it 'indicates all available monkeypatches can be shown with -a when' \
'(when -a not used and more than one candidate exists for class)' do
# Still reading boring tests, eh?
class TestClassForShowSource
def beta
end