Commit Graph

16 Commits

Author SHA1 Message Date
Kyrylo Silin e61354693f Add .rspec and require 'helper' from there
Just discovered this nice feature of RSpec where it can load all files for
us. Works with `bundle exec rake` and `bundle exec rspec spec/file_spec.rb`,
which covers all use cases.
2018-11-18 14:04:44 +08:00
Kyrylo Silin bc26e405ea Simplify Prompt API
Before this change when you set a prompt, you have to do the following:

```rb
Pry.config.prompt = Pry::Prompt[:simple][:value]
```

The `[:value]` part was leaking implementation details and it proved to be an
unnecessary step.

With this change we can do the following:

```rb
Pry.config.prompt = Pry::Prompt[:simple]
```

`[:value]` is omitted.

I have also refactored some tests and removed irrelevant ones.

The Array API for prompt is deprecated:
`Pry.config.prompt = [proc {}, proc {}]` emits a warning now.
2018-11-17 05:26:25 +08:00
Kyrylo Silin eb5564e5b1 prompt: raise ArgumentError when trying to add an existing prompt
This way we make sure nobody overwrites our default prompts.
2018-11-16 04:17:55 +08:00
Kyrylo Silin 04d4f424e3 rubocop: fix offences regarding spaces
Fixes offences of the following cops:

* Layout/SpaceAroundEqualsInParameterDefault
* Layout/SpaceAroundOperators
* Layout/SpaceBeforeBlockBraces
* Layout/SpaceInsideBlockBraces
2018-11-04 17:34:24 +08:00
Kyrylo Silin 3da930f908 prompt: add basic API for adding prompts
Fixes #1836 (Add an API for adding new prompts)
2018-11-04 02:11:15 +08:00
Kyrylo Silin ace907b1b1 prompt: make it possible to set name dynamically
Fixes #1738 (Possible to make prompt_name dynamic?)

The user-facing API is the following:

```rb
Pry.config.prompt_name = Pry.lazy { rand(100) }

[1] 80(main)>
[2] 87(main)>
[3] 30(main)>
```
2018-10-28 19:02:14 +08:00
Kyrylo Silin f33d82779a rubocop: fix offences of the Style/HashSyntax cop 2018-10-13 03:09:29 +08:00
r-obert 97c1493e16 fix a bug where "cd Hash.new" reported self as a Pry::Config in prompt.
from_hash is recursive, turning Hash values into Pry::Config objects.
fix #1724
2017-12-22 23:01:50 +01:00
Kyrylo Silin 96c6958cc6 specs: convert to shoulds to expects 2015-03-10 22:49:29 +02:00
Matijs van Zuijlen 5e8d69e8b3 Fix possible reference to past scope warnings
This type of warning was introduced in Ruby 2.2
2015-01-23 14:24:35 +01:00
Matijs van Zuijlen 96b61f14aa Fix some warnings 2015-01-23 14:03:36 +01:00
Josh Cheek 144d32e1d6 Switch test suite to RSpec
Removes Bacon and Mocha

Reasoning explained in this comment: https://github.com/pry/pry/issues/277#issuecomment-51708712

Mostly this went smoothly. There were a few errors that I fixed along
the way, e.g. tests that were failing but for various reasons still
passed. Should have documented them, but didn't think about it until
very near the end. But generaly, I remember 2 reasons this would happen:
`lambda { raise "omg" }.should.raise(RuntimeError, /not-omg/)` will pass
because the second argument is ignored by Bacon. And `1.should == 2`
will return false instead of raising an error when it is not in an it
block (e.g. if stuck in a describe block, that would just return false)

The only one that I felt unsure about was spec/helpers/table_spec.rb
`Pry::Helpers.tablify_or_one_line('head', %w(ing)).should == 'head: ing'`
This is wrong, but was not failing because it was in a describe block
instead of an it block.  In reality, it returns `"head: ing\n"`,
I updated the test to reflect this, though I don't know for sure
this is the right thing to do

This will fail on master until https://github.com/pry/pry/pull/1281 is merged.
This makes https://github.com/pry/pry/pull/1278 unnecessary.
2014-08-10 17:37:21 -06:00
Robert Gleeson 74135c1890 allow for tests to be run with ease.
'bacon spec/config_spec.rb' instead of 'bacon -I spec spec/config_spec.rb'
2014-03-14 05:31:24 +01:00
Robert Gleeson 91d412c044 remove openstruct dependency from all of pry. 2014-01-21 11:11:42 +01:00
Conrad Irwin c3d5469a1a Manage binding_stack in r() too! 2012-12-15 15:03:03 -08:00
☈king 848b6bdbeb Rename for tabcompletion-friendliness. 2012-11-15 18:59:51 -06:00
Renamed from test/test_prompt.rb (Browse further)