1
0
Fork 0
mirror of https://github.com/pry/pry.git synced 2022-11-09 12:35:05 -05:00
Commit graph

6 commits

Author SHA1 Message Date
Conrad Irwin
b26a5ec32e Merge commit '0e091ff6c35691711929c16a8e407ebf5fbc88b2' 2014-08-16 16:43:25 -07:00
Conrad Irwin
0e091ff6c3 Use new syntax for tests 2014-08-16 16:43:22 -07:00
Josh Cheek
144d32e1d6 Switch test suite to RSpec
Removes Bacon and Mocha

Reasoning explained in this comment: https://github.com/pry/pry/issues/277#issuecomment-51708712

Mostly this went smoothly. There were a few errors that I fixed along
the way, e.g. tests that were failing but for various reasons still
passed. Should have documented them, but didn't think about it until
very near the end. But generaly, I remember 2 reasons this would happen:
`lambda { raise "omg" }.should.raise(RuntimeError, /not-omg/)` will pass
because the second argument is ignored by Bacon. And `1.should == 2`
will return false instead of raising an error when it is not in an it
block (e.g. if stuck in a describe block, that would just return false)

The only one that I felt unsure about was spec/helpers/table_spec.rb
`Pry::Helpers.tablify_or_one_line('head', %w(ing)).should == 'head: ing'`
This is wrong, but was not failing because it was in a describe block
instead of an it block.  In reality, it returns `"head: ing\n"`,
I updated the test to reflect this, though I don't know for sure
this is the right thing to do

This will fail on master until https://github.com/pry/pry/pull/1281 is merged.
This makes https://github.com/pry/pry/pull/1278 unnecessary.
2014-08-10 17:37:21 -06:00
Tom Kadwill
1376726cf6 Added tests for Pry::Command::ReloadCode#reload_object and Pry::Command::ReloadCode#process 2014-05-10 10:09:11 +01:00
Conrad Irwin
ed58b9716a Fix reload-code specs [Fixes #1224]
The cascading problem was caused by reloading sensitive bits of bacon
2014-05-07 00:59:36 -07:00
Tom Kadwill
ae1844f40a Improved reload-code error messages and added tests. 2014-04-27 14:28:09 -07:00