1
0
Fork 0
mirror of https://github.com/pry/pry.git synced 2022-11-09 12:35:05 -05:00
Commit graph

15 commits

Author SHA1 Message Date
Kyrylo Silin
f829360909 rubocop: fix ofences of the Style/BlockDelimiters cop 2018-11-18 00:37:47 +08:00
Kyrylo Silin
0fc57889a1 rubocop: fix offences of the Lint/UnusedBlockArgument cop 2018-11-11 20:22:03 +08:00
Kyrylo Silin
04d4f424e3 rubocop: fix offences regarding spaces
Fixes offences of the following cops:

* Layout/SpaceAroundEqualsInParameterDefault
* Layout/SpaceAroundOperators
* Layout/SpaceBeforeBlockBraces
* Layout/SpaceInsideBlockBraces
2018-11-04 17:34:24 +08:00
Kyrylo Silin
48b6a9c3b4 rubocop: fix offences of Layout/EmptyLinesAroundClassBody cop 2018-11-04 16:50:21 +08:00
Kyrylo Silin
4833e5082f rubocop: fix offences of the Lint/AssignmentInCondition cop 2018-10-21 05:52:22 +08:00
Arlandis Word
59e7afd40b Fix rubocop empty line after guard clause style violations 2018-10-14 09:44:58 -04:00
Kyrylo Silin
f33d82779a rubocop: fix offences of the Style/HashSyntax cop 2018-10-13 03:09:29 +08:00
robert
b69fbcaf5e fix warning about signature of respond_to? on 2.4 2017-05-27 18:41:00 +01:00
strcmp
cab1e094fa import slop v3.4 as lib/pry/slop 2015-12-11 06:04:18 +00:00
Conrad Irwin
4824314c8c Revert "Set Pry::Slop equal to Slop (v2.4.4)"
This reverts commit e306ff5584.
2012-05-30 13:38:17 -07:00
Conrad Irwin
9847daac18 Revert "Upgrade to Slop v3"
This reverts commit 6bd1627022.
2012-05-30 13:38:17 -07:00
Conrad Irwin
82a87c7eb0 Revert "reinstate slop license"
This reverts commit 535ac800b0.
2012-05-30 13:33:08 -07:00
Conrad Irwin
535ac800b0 reinstate slop license 2012-05-29 21:16:42 -07:00
Conrad Irwin
6bd1627022 Upgrade to Slop v3 2012-05-29 20:28:11 -07:00
Conrad Irwin
e306ff5584 Set Pry::Slop equal to Slop (v2.4.4)
We've decided not to upgrade our slop dependency to version 3 for
several reasons:

1. People who are currently using pry in their programs are using slop
version 2; and they may not realise this. Bumping the slop dependency
could therefore break people's code in subtle ways. By removing the
dependency completely we make it obvious that breakage has occurred, and
allows programs to chose their own version of slop.

2. The new version of slop is incompatible with pry. As a command-line
tool we use our option parsing library very very intensely; and as such
we've grown used to (and even embraced) it's warts, inconcistencies and
undocumented behaviours. Upgrading the slop dependency at this point
requires a lot of fix up work both on the slop codebase and the pry
codebase.

3. The slop API is implicitly part of the pry API for defining custom
commands; by changing that API we run a significant risk of breaking
people's pry extensions.

4. The problems in 1., 2. and 3. are going to recur every time slop releases
a new version.

5. Doing this does not preclude upgrading the version of slop we use in
the future. Beacuse 1. will not occur anymore, the only breakage that we
can cause is in pry extensions; this seems resonable providing we signal
the fact that we're doing it (for example by updating the major
version number).
2012-05-28 00:29:18 -07:00