1
0
Fork 0
mirror of https://github.com/pry/pry.git synced 2022-11-09 12:35:05 -05:00
Commit graph

15 commits

Author SHA1 Message Date
yui-knk
9f9c72c82b Remove helpers for spec. Helpers for spec and specs for helper are mixed in spec/helpers, so remove helpers to spec/spec_helpers. 2013-12-21 23:20:42 +09:00
Kyrylo Silin
9074613927 Helpers::tablify: fix FloatDomainError
Before this commit the following snippet didn't work:

  pry(main)> Pry::Helpers.tablify(['foobar', 'baz'], 5)
  #=> FloatDomainError

There was a divison by zero in `Helpers::Table#_recolumn`.

The problem is incorrectly written `until` loop condition. Note that the
longest element in the array has 6 characters. But the second argument
tells `::tablify` that the line width is only 5 characters long.

This commit changes the condition. Now, if you run the same snippet, you
would see that the elements form one column (and the code doesn't blow
up your program).

Possibly, in the described case, the table has unwanted blanks. However,
I'm not very competent in the code, so I'd better not touch it, because
it works.
2013-01-27 06:12:35 +02:00
Conrad Irwin
2c60f93b2d Merge branch 'wip.refactor'
Conflicts:
	lib/pry/completion.rb
	lib/pry/pry_instance.rb
	spec/commands/play_spec.rb
	spec/pry_defaults_spec.rb
2013-01-18 00:19:38 -08:00
☈king
14283aa51f Adjusting ls output for voluminous output
The previous table output was geared mostly for `ls _pry_`, which isn't
a common of hierarchy. After feedback from users such as @envygeeks, we
found a few tweaks that would help the really-small layers such as those
found in Rails or in small classes, namely:

- Rolling it up onto one line, if possible
- Highlighting the heading in the colors familiar to users of GNU ls for
  "directory" style

Additionally, I took the opportunity for toning down the
private/protected method colors, because before they were green and
yellow, now they're both "muted terminal blue"

Without the ability to really get in and really distinguish colors (e.g.
using 256 colors), giving "protected" such a loud color seems wrong.

Before recoloring:
  https://github.com/pry/pry/issues/813#issuecomment-12355179
After:
  https://github.com/pry/pry/issues/813#issuecomment-12355941
2013-01-17 23:15:31 +00:00
☈king
139a2a7a0a Extract Table to its own file 2013-01-09 17:18:44 -06:00
Conrad Irwin
b9117c8619 Tidier test for BasicObject support 2012-12-28 14:19:38 -08:00
Ryan Fitzgerald
ba3457686f Record initial prompt too 2012-12-23 20:05:37 -08:00
Ryan Fitzgerald
4b5d47cd60 Fix tester for nested-instance case 2012-12-23 19:58:18 -08:00
Ryan Fitzgerald
988b27c071 Switch from fibers to threads 💔 2012-12-23 18:57:25 -08:00
Ryan Fitzgerald
00c2fc935d Test command mutating eval_string instead of Ruby doing it
It probably isn't actually important to support Ruby mutating
eval_string.
2012-12-23 15:22:02 -08:00
Ryan Fitzgerald
4edafaee0f ReplTester API changes; add failing spec 2012-12-23 12:25:48 -08:00
Ryan Fitzgerald
3c6ffaf69c Slightly refactor REPL initialization 2012-12-23 00:08:40 -08:00
Ryan Fitzgerald
6ee0f4a32b Add integration tester, failing spec 2012-12-23 00:03:29 -08:00
Conrad Irwin
d31967799c Remove more rep() from spec/pry_spec.rb 2012-12-18 00:11:08 -08:00
Ryan Fitzgerald
038bdf8a91 Move some testing code into spec/helpers/ 2012-12-08 17:14:25 -08:00