1
0
Fork 0
mirror of https://github.com/pry/pry.git synced 2022-11-09 12:35:05 -05:00
Commit graph

22 commits

Author SHA1 Message Date
Kyrylo Silin
e61354693f Add .rspec and require 'helper' from there
Just discovered this nice feature of RSpec where it can load all files for
us. Works with `bundle exec rake` and `bundle exec rspec spec/file_spec.rb`,
which covers all use cases.
2018-11-18 14:04:44 +08:00
Kyrylo Silin
22d4ff7b22 Don't attempt to read unused proc parameters 2018-11-11 20:36:49 +08:00
Kyrylo Silin
0fc57889a1 rubocop: fix offences of the Lint/UnusedBlockArgument cop 2018-11-11 20:22:03 +08:00
Kyrylo Silin
c229142739 rubocop: fix offences of the Lint/AmbiguousBlockAssociation cop 2018-10-16 04:38:17 +08:00
r-obert
4391aa863e
add Pry::Testable, and friends. (#1679)
* add Pry::Testable, and friends.

This commit replaces lib/pry/test/helper.rb by using category modules.
There's now:

* Pry::Testable:
  * Pry::Testable::Evalable
  * Pry::Testable::Mockable
  * Pry::Testable::Utility
  * Pry::Testable::PryTester

'include Pry::Testable' includes all of the above.
For the pry test suite it worked out best to include 'Pry::Testable' at the top-level.

In plugins I've written though this hasn't been the case, and I only normally need:
Pry::Testable::Evalable. So it reduces pollution for the third-party cases, which this
code is intended for since it lives within lib/ of the project.

What do you think?

* breaking change: add set_testenv_variables and unset_testenv_variables

* breaking change: add Pry::Testable::Variables, and rename

constant_scope() to temporary_constants().

* breaking change: rename inject_var as insert_variable, and move its

definition to Pry::Testable::Variables.

* include Pry::Testable::Evalable & include Pry::Testable::Variables into

the top-level, but keep the other two modules spec-local.

* document third argument of insert_variable.

* update CHANGELOG.md

* note changelog entry is a breaking change

* update documentation
2017-11-04 05:32:31 +01:00
robert
3ce1fb9bb7 fix warning about unused variable on 2.4
the variable isn't unused, but ruby isn't smart enough to detect
how it's used (inside eval).
2017-06-04 22:25:55 +01:00
strcmp
fd2e366c2e add testcase for #1464 2015-08-24 03:08:41 +01:00
Kyrylo Silin
96c6958cc6 specs: convert to shoulds to expects 2015-03-10 22:49:29 +02:00
Josh Cheek
144d32e1d6 Switch test suite to RSpec
Removes Bacon and Mocha

Reasoning explained in this comment: https://github.com/pry/pry/issues/277#issuecomment-51708712

Mostly this went smoothly. There were a few errors that I fixed along
the way, e.g. tests that were failing but for various reasons still
passed. Should have documented them, but didn't think about it until
very near the end. But generaly, I remember 2 reasons this would happen:
`lambda { raise "omg" }.should.raise(RuntimeError, /not-omg/)` will pass
because the second argument is ignored by Bacon. And `1.should == 2`
will return false instead of raising an error when it is not in an it
block (e.g. if stuck in a describe block, that would just return false)

The only one that I felt unsure about was spec/helpers/table_spec.rb
`Pry::Helpers.tablify_or_one_line('head', %w(ing)).should == 'head: ing'`
This is wrong, but was not failing because it was in a describe block
instead of an it block.  In reality, it returns `"head: ing\n"`,
I updated the test to reflect this, though I don't know for sure
this is the right thing to do

This will fail on master until https://github.com/pry/pry/pull/1281 is merged.
This makes https://github.com/pry/pry/pull/1278 unnecessary.
2014-08-10 17:37:21 -06:00
Conrad Irwin
dd5e2511f3 Use _pry_.pager instead of Pry::Pager
This is not a concern for backward compatibility as it was introduced
since the last release
2014-05-01 01:51:02 -07:00
Conrad Irwin
44463e7d85 Stop using compatibility aliases for Pry.config 2014-05-01 01:51:01 -07:00
Robert Gleeson
74135c1890 allow for tests to be run with ease.
'bacon spec/config_spec.rb' instead of 'bacon -I spec spec/config_spec.rb'
2014-03-14 05:31:24 +01:00
yui-knk
4e9df5b901 Fix pry.config.output_prefix to work. Fix #1128 2014-02-05 22:31:23 +09:00
Ryan Fitzgerald
54e4729727 Stream colorized inspect output into pagers 2013-11-02 14:20:56 -07:00
Kyrylo Silin
9cb54fd755 spec/pry_output_spec.rb: test colour leaks for Object literals
This ensures that CodeRay does not leak colours.
For more information see the following commit:

c544c1d699
2013-10-24 00:51:36 +03:00
Conrad Irwin
2c60f93b2d Merge branch 'wip.refactor'
Conflicts:
	lib/pry/completion.rb
	lib/pry/pry_instance.rb
	spec/commands/play_spec.rb
	spec/pry_defaults_spec.rb
2013-01-18 00:19:38 -08:00
Conrad Irwin
1aacb10cb3 Remove output.write
Many plugins only define a puts method on the output object. This change
removse the ability to customize the formatter used when outputting
variables in `ls`. We should reconsider the best way to do this.
2013-01-14 09:33:27 -08:00
Conrad Irwin
26307d5a63 Remove extra newline from output specs [Fixes #34] 2012-12-15 15:36:11 -08:00
John Mair
4bf42ca006 move Pad to local helpers, and move more methods in PryTestHelpers 2012-12-09 00:01:18 +01:00
Conrad Irwin
83d3ceeb5f Don't recolorize output with ANSI escapes [Fixes #751] 2012-11-28 15:21:14 -08:00
Conrad Irwin
fae1417e5c Fix specs on jruby-19mode on travis
This is working around (another) brokenness in jruby 1.6.8s splat
handling in ruby 1.9 mode; but I figure that now jruby 1.7 is out,
we can not bother fixing it.
2012-11-18 01:42:22 -08:00
☈king
848b6bdbeb Rename for tabcompletion-friendliness. 2012-11-15 18:59:51 -06:00
Renamed from test/test_pry_output.rb (Browse further)