mirror of
https://github.com/pry/pry.git
synced 2022-11-09 12:35:05 -05:00
144d32e1d6
Removes Bacon and Mocha Reasoning explained in this comment: https://github.com/pry/pry/issues/277#issuecomment-51708712 Mostly this went smoothly. There were a few errors that I fixed along the way, e.g. tests that were failing but for various reasons still passed. Should have documented them, but didn't think about it until very near the end. But generaly, I remember 2 reasons this would happen: `lambda { raise "omg" }.should.raise(RuntimeError, /not-omg/)` will pass because the second argument is ignored by Bacon. And `1.should == 2` will return false instead of raising an error when it is not in an it block (e.g. if stuck in a describe block, that would just return false) The only one that I felt unsure about was spec/helpers/table_spec.rb `Pry::Helpers.tablify_or_one_line('head', %w(ing)).should == 'head: ing'` This is wrong, but was not failing because it was in a describe block instead of an it block. In reality, it returns `"head: ing\n"`, I updated the test to reflect this, though I don't know for sure this is the right thing to do This will fail on master until https://github.com/pry/pry/pull/1281 is merged. This makes https://github.com/pry/pry/pull/1278 unnecessary.
81 lines
2.4 KiB
Ruby
81 lines
2.4 KiB
Ruby
require_relative 'helper'
|
|
|
|
describe Pry do
|
|
before do
|
|
@str_output = StringIO.new
|
|
end
|
|
|
|
[
|
|
["p = '", "'"],
|
|
["def", "a", "(); end"],
|
|
["p = <<FOO", "lots", "and", "lots of", "foo", "FOO"],
|
|
["[", ":lets,", "'list',", "[/nested/", "], things ]"],
|
|
["abc =~ /hello", "/"],
|
|
["issue = %W/", "343/"],
|
|
["pouts(<<HI, 'foo", "bar", "HI", "baz')"],
|
|
].each do |foo|
|
|
it "should not raise an error on broken lines: #{foo.join("\\n")}" do
|
|
redirect_pry_io(InputTester.new(*foo), @str_output) do
|
|
Pry.start
|
|
end
|
|
|
|
@str_output.string.should_not =~ /SyntaxError/
|
|
end
|
|
end
|
|
|
|
[
|
|
["end"],
|
|
["puts )("],
|
|
["1 1"],
|
|
["puts :"]
|
|
] + (Pry::Helpers::BaseHelpers.rbx? ? [] : [
|
|
["def", "method(1"], # in this case the syntax error is "expecting ')'".
|
|
["o = Object.new.tap{ def o.render;","'MEH'", "}"] # in this case the syntax error is "expecting keyword_end".
|
|
]).compact.each do |foo|
|
|
it "should raise an error on invalid syntax like #{foo.inspect}" do
|
|
redirect_pry_io(InputTester.new(*foo), @str_output) do
|
|
Pry.start
|
|
end
|
|
|
|
@str_output.string.should =~ /SyntaxError/
|
|
end
|
|
end
|
|
|
|
it "should not intefere with syntax errors explicitly raised" do
|
|
redirect_pry_io(InputTester.new(%q{raise SyntaxError, "unexpected $end"}), @str_output) do
|
|
Pry.start
|
|
end
|
|
|
|
@str_output.string.should =~ /SyntaxError/
|
|
end
|
|
|
|
it "should allow trailing , to continue the line" do
|
|
pry = Pry.new
|
|
Pry::Code.complete_expression?("puts 1, 2,").should == false
|
|
end
|
|
|
|
it "should complete an expression that contains a line ending with a ," do
|
|
pry = Pry.new
|
|
Pry::Code.complete_expression?("puts 1, 2,\n3").should == true
|
|
end
|
|
|
|
it "should not suppress the error output if the line ends in ;" do
|
|
mock_pry("raise RuntimeError, 'foo';").should =~ /RuntimeError/
|
|
end
|
|
|
|
it "should not clobber _ex_ on a SyntaxError in the repl" do
|
|
mock_pry("raise RuntimeError, 'foo'", "puts foo)", "_ex_.is_a?(RuntimeError)").should =~ /^RuntimeError.*\nSyntaxError.*\n=> true/m
|
|
end
|
|
|
|
it "should allow whitespace delimeted strings" do
|
|
mock_pry('"%s" %% foo ').should =~ /"foo"/
|
|
end
|
|
|
|
it "should allow newline delimeted strings" do
|
|
mock_pry('"%s" %%','foo').should =~ /"foo"/
|
|
end
|
|
|
|
it "should allow whitespace delimeted strings ending on the first char of a line" do
|
|
mock_pry('"%s" %% ', ' #done!').should =~ /"\\n"/
|
|
end
|
|
end
|