Add #flush and #sync methods to Puma::NullIO (#2553)

History.md

@@ -1,3 +1,8 @@
+## 5.2.2 / 2021-02-
+
+* Bugfixes
+  * Add `#flush` and `#sync` methods to `Puma::NullIO`  ([#2553])
+
 ## 5.2.1 / 2021-02-05
 
 * Bugfixes

lib/puma/null_io.rb

@@ -36,6 +36,10 @@ module Puma
       true
     end
 
+    def sync
+      true
+    end
+
     def sync=(v)
     end
 
@@ -44,5 +48,9 @@ module Puma
 
     def write(*ary)
     end
+
+    def flush
+      self
+    end
   end
 end

test/test_events.rb

@@ -97,6 +97,14 @@ class TestEvents < Minitest::Test
     assert_equal "ready\n", out
   end
 
+  def test_null_log_does_nothing
+    out, _ = capture_io do
+      Puma::Events.null.log("ready")
+    end
+
+    assert_equal "", out
+  end
+
   def test_write_writes_to_stdout
     out, _ = capture_io do
       Puma::Events.stdio.write("ready")

test/test_null_io.rb

@@ -56,4 +56,12 @@ class TestNullIO < Minitest::Test
   def test_size
     assert_equal 0, nio.size
   end
+
+  def test_sync_returns_true
+    assert_equal true, nio.sync
+  end
+
+  def test_flush_returns_self
+    assert_equal nio, nio.flush
+  end
 end