kotovalexarian-likes-github/puma--puma
1
0
Fork 0
mirror of https://github.com/puma/puma.git synced 2022-11-09 13:48:40 -05:00
Code Releases Activity

ps -p will check correctly whether $PID exists (#1545)

Browse source 
It is appropriate to use `ps -p` in that place.

Under certain conditions, existing code ``[ "`ps -A -o pid=
| grep -c $PID`" -eq 0 ]`` may behave incorrectly.

For example, if the content of $PID happens to be a short string
(such as `199`), and another process includes the string
(process such as `2199`), then unfortunately `grep -c` will return
positive number even if `199` is not running.
This commit is contained in:
hoshino tsuyoshi 2018-03-28 22:00:30 +09:00 • committed by Nate Berkopec
parent 286cb05029
commit 9aea96eaf3
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tools/jungle/init.d/puma
View file

@ -48,7 +48,7 @@ do_start_one() {
if [ -e $PIDFILE ]; then
PID=`cat $PIDFILE`
# If the puma isn't running, run it, otherwise restart it.
if [ "`ps -A -o pid= | grep -c $PID`" -eq 0 ]; then
if ps -p $PID > /dev/null; then
do_start_one_do $1
else
do_restart_one $1
@ -105,7 +105,7 @@ do_stop_one() {
STATEFILE=$1/tmp/puma/state
if [ -e $PIDFILE ]; then
PID=`cat $PIDFILE`
if [ "`ps -A -o pid= | grep -c $PID`" -eq 0 ]; then
if ps -p $PID > /dev/null; then
log_daemon_msg "---> Puma $1 isn't running."
else
log_daemon_msg "---> About to kill PID `cat $PIDFILE`"