1
0
Fork 0
mirror of https://github.com/puma/puma.git synced 2022-11-09 13:48:40 -05:00

Catch 'Error in reactor loop escaped: mode not supported for this object: r' (#2477)

The following error happens intermittently in non MRI CI:

Error in reactor loop escaped: mode not supported for this object: r (ArgumentError)

Add rescue in `Reactor#register
This commit is contained in:
MSP-Greg 2020-11-16 14:31:07 -06:00 committed by GitHub
parent dcfe6273cb
commit ae017306b1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 0 deletions

View file

@ -10,6 +10,7 @@
* Bugfixes
* Your bugfix goes here <Most recent on the top, like GitHub> (#Github Number)
* Catch 'Error in reactor loop escaped: mode not supported for this object: r' (#2477)
* Ignore Rails' reaper thread (and any thread marked forksafe) for warning ([#2475])
* Ignore illegal (by Rack spec) response header ([#2439])
* Close idle connections immediately on shutdown ([#2460])

View file

@ -95,6 +95,8 @@ module Puma
def register(client)
@selector.register(client.to_io, :r).value = client
@timeouts << client
rescue ArgumentError
# unreadable clients raise error when processed by NIO
end
# 'Wake up' a monitored object by calling the provided block.