1
0
Fork 0
mirror of https://github.com/puma/puma.git synced 2022-11-09 13:48:40 -05:00
Commit graph

29 commits

Author SHA1 Message Date
Benoit Daloze
0b737cce42
Run tests on TruffleRuby, all tests pass now (#2198)
* Support skip_on :truffleruby

* Remove unused variable declaration

* Properly skip tests which need fork

* Improve NO_FORK_MSG

* Keep the Tempfile instances alive in test_redirect_io.rb

* Otherwise they could GC in the middle of the test, and the files could
  then be deleted.

* Use a better way to find a free port

* Read directly from the socket in #read_and_drop

* There is no point to decode the bytes since we are closing the socket
  in Puma::MiniSSL::Socket#close.
* Also, calling #engine_read_all might cause further SSL errors, which
  could hide the first SSL error. This notably happens in
  TestPumaServerSSLClient#test_verify_fail_if_no_client_cert
  if the server is faster than the client. The error in that case is
  "System error: Success - 0 (Puma::MiniSSL::SSLError)" which is not
  actually an error, but there is also nothing to read further from SSL.

* TruffleRuby should pass the CI now, remove from allowed failures

* Use a timeout of 120 for all non-MRI implementations

* 60 doesn't seem enough in CI for TestThreadPool#test_trim on TruffleRuby.

* Fix check for cluster mode in integration tests

* Improve integration tests to fail more clearly if the pid file does not exist

* Make integration tests more robust

* Add skips for unreliable or racy tests

* Add ChangeLog entry

* No need to run RuboCop on non-MRI implementations

* This should speed up CI a bit for those jobs.
2020-03-25 06:13:31 +09:00
Nate Berkopec
9dee8d04fb
Remove freeze-all-strings from build
Rack 1.6 blows up with this option.
2020-03-19 14:37:20 -06:00
Patrik Ragnarsson
a45d696351
Be able to skip tests [ci skip] (#2192)
Either via pull request title or commit message (for docs fixes on
master).
2020-03-18 17:43:57 -06:00
MSP-Greg
21a33f73a9
Actions - Add nonMRI workflow - allow failure - JRuby, TruffleRuby [changelog skip] (#2185)
* Actions - Add nonMRIHead workflow - allow failure - JRuby, TruffleRuby

Also, on Windows, add Ruby 2.2 and fix compile code

* extconf.rb - minor fix for old Windows Rubies

* JRuby fixes for CI

1. lib/puma/minissl.rb - add 'correct' constants so CI will run

2. test/shell/t*.rb - extend time to start by two seconds for JRuby

* Delete .travis.yml
2020-03-17 06:16:45 -06:00
Nate Berkopec
e42d3a65cd
JRuby -> GH Actions 2020-03-14 13:57:46 -06:00
MSP-Greg
745bef73e1
Show RUBYOPT in test 'header', use setup-ruby-pkgs (#2162) 2020-03-08 21:10:07 -06:00
MSP-Greg
bd8d26e533
Temp fix for Actions Windows CI (#2157) 2020-03-07 21:05:35 -06:00
MSP-Greg
9b5137a5d1
Fix two Ruby 2.2 issues, add to Actions & remove from Travis [changelog skip] (#2146)
* Add Ruby 2.2 to Actions, remove from Travis

Travis uses OpenSSL 1.0.1, Actions uses 1.0.2

* Ruby 2.2 - binder.rb, server.rb - add single io.closed? check to each
2020-03-04 11:17:38 -06:00
MSP-Greg
bc3059029e
workflows/ruby.yml - use 'bundle install' with '--path=.bundle/puma' (#2126) 2020-02-24 14:06:02 -06:00
MSP-Greg
71bcd84a57
Split ruby.yml, revise Actions (#2114) 2020-02-13 10:47:15 -06:00
Patrik Ragnarsson
6f59df8dc0
Actions: Use the new action name [changelog skip] (#2109)
This action was transferred to ruby/setup-ruby: https://github.com/ruby/setup-ruby/releases/tag/v1.13.0
2020-02-07 11:16:57 -06:00
MSP-Greg
10b4ffc378
Update Actions ruby.yml [changelog skip] (#2103)
* Update ruby.yml

Ruby 2.4 thru 2.7 on all platforms

Ubuntu 2.3, macOS 2.3, & Windows 2.4 use OpenSSL 1.0.2, all others are 1.1.1

JRuby fails tests

* .travis.yml - remove jobs similar to Actions
2020-02-07 10:53:52 -06:00
Patrik Ragnarsson
7e691845dd GitHub Actions no longer have Ruby 2.3.x (#2087)
Using RVM to install 2.3.8 like RubyGems does: https://github.com/rubygems/rubygems/blob/v3.1.2/.github/workflows/ubuntu-rvm.yml

...with OpenSSL 1.0.2 like @MSP-Greg says: https://github.com/puma/puma/pull/2087#issuecomment-569439765
2019-12-30 14:37:09 +07:00
Patrik Ragnarsson
51494b0547 Changelog check checks PR title [ci skip] (#2088)
75e2179e61/.github/workflows/check_changelog.yml (L13)
2019-12-16 06:38:32 +07:00
Derik Linch
244a358193 changed PR template to direct people to add "[skip ci]" to the PR title (#2056)
rather than a commit message

[skip changelog]
2019-10-28 19:21:54 -04:00
Olle Jonsson
cea74d706a PR template: link to contributing, changelog (#2051)
Point to the "blob" on master, so that the link is clickable from the PR

[changelog skip]
2019-10-24 09:21:23 +08:00
Nate Berkopec
c379424c7b
Add pull request template 2019-10-21 10:27:31 +08:00
MSP-Greg
1d97e42dde Actions CI - Allow CI from branches other than master (forks), add test timeout (#2042)
Timeout will need to be changed if JRuby is added to this workflow.
2019-10-18 17:22:50 +08:00
Daniel Colson
dd781669d7 Allow reversed words to skip changelog [skip ci] (#2021)
[Travis][] allows both "<KEYWORD> skip" and "skip <KEYWORD>", as does
[Circleci][]. I never remember which order the words should go in, so it
is a nice convenience if either order works.

[Travis]: https://docs.travis-ci.com/user/customizing-the-build/#skipping-a-build
[Circleci]: https://circleci.com/docs/2.0/skip-build/#skipping-a-build
2019-10-10 11:06:39 +02:00
Richard Schneeman
079b284d13 Fix GitHub changelog check (#1999) 2019-09-26 19:02:33 +02:00
Nate Berkopec
f0c98a5a14
Ask for CLI options AND config in bug report 2019-09-26 12:50:53 +02:00
Nate Berkopec
25e41f0740
Del old issue template 2019-09-26 12:50:23 +02:00
Richard Schneeman
b9ed8444d3 [ci skip] Require Changelog at PR time (#1991)
* [ci skip] Require Changelog at PR time

We frequently forget to ask for a changelog entry, and then when we want to release the release maintainer has to go back and manually add them all. It would be better if the changelog was required at PR time so the original submitter can think of the best wording. If a PR is trivial people can add `[ci skip]` or `[changelog skip]`.

This implementation uses github actions.

* Use correct name of changelog file

The changelog is History.md not CHANGELOG.md
2019-09-25 21:53:54 +02:00
Nate Berkopec
c68dfffc32
Freeze all string literals in CI 2019-09-20 12:14:19 +02:00
Nate Berkopec
b59db28a6c
CI -> Github actions (#1918) 2019-09-19 19:50:13 +02:00
Nate Berkopec
58acb805f5
Example Dockerfile for issue reproduction 2019-09-19 13:43:42 +02:00
Nate Berkopec
7e704b553c Update issue templates 2019-09-15 15:31:36 +02:00
Nate Berkopec
379c159a86 Add puma version to issue template 2017-08-16 08:24:42 -06:00
Francesco Rodriguez
768f6bd5ca Add issue template.
Use GitHub feature to add more details to reported issues.

Based on Rails' issue template.

Ref: https://github.com/blog/2111-issue-and-pull-request-templates
2016-09-13 12:02:47 +02:00