* Fix crash when no_token is set
* Use a more meaningful name instead of an empty string
* Adds a test to ensure `{ no_token: true }` works
* Adds an explanation for the usage of a String
Just to justify the use of a String instead of a Symbol.
* Removes thread that would start the server
This removes the part of the test that would start the server. The
reason why the thread was being created originally in the PR was to
ensure that the server was booting even with `{ no_token: true }`.
I believe we don't need to test the full server boot but just ensure
that we won't pass a Symbol to OptionParser. In particular the test
ensures that the token will be set to `'none'` when `no_token: true`.
There're already other tests testing that the server boots.
- deprecate `--control`
- add new option `--control-url`
- https://github.com/puma/puma/pull/1416 introduced a bug in pumactl the puma
cli does not respond to `control-cli` option. On puma it is called `control`
- this commit
a8f54f74cd
was correct, but it looked like a typo since the names of the options are not
consistent across versions
- the best option for fixing this seems to be to support both options
- we don't want to stop supporting `control` in the cli for
backwards-compatibility so it is deprecated
running `rake` loads all files starting with `test_` which is not supposed to also load the helper,
since the helper should be loaded by each test and is not a test itself.
`Puma::Configuration._from_file` was removed in 89f37432de. It was still being used by the `Puma::ControlCLI` class which was previously not being tested while being called with a `--config-file` option.
This PR reintroduces the previous behavior of loading a config file when specified via `pumactl` command.
