mirror of
https://github.com/puma/puma.git
synced 2022-11-09 13:48:40 -05:00
64c0153cd0
* Add basic JSON serializer For now, it only handles Arrays of Integers, but we'll extend it to support all of the common types * Serialize Strings * Escape quotes in Strings * Escape backslashes in Strings * Serialize Hashes with String keys * Extract method for serializing Strings * Add test coverage for non-Hash non-Array JSON serialization * Add test for unexpected key types * Serialize Hashes with Symbol keys * Raise on unexpected value types * Serialize boolean values * Serialize Floats * Add module comment to Puma::JSON * Update integration test to use fully-qualfied JSON module reference * Remove json gem dependency from /stats status server response Fixes a bug where requesting `/stats` from the status server would cause subsequent phased restarts to fail when upgrading/downgrading the json gem. * Run gc_stats tests on JRuby These were disabled at some point on JRuby, but they seem to run fine. Importantly, this test ensures that a call to `/gc-stats` returns well-formed JSON on JRuby, where the value of `GC.stat` contains nested structures. * Remove json gem dependency from /gc-stats status server response Fixes a bug where requesting `/gc-stats` from the status server would cause subsequent phased restarts to fail when upgrading/downgrading the json gem. * Remove json gem from /thread-backtraces status server response Fixes a bug where requesting `/thread-backtraces` from the status server would cause subsequent phased restarts to fail when upgrading/downgrading the json gem. * Remove json gem dependency from Puma.stats Fixes a bug where accessing `Puma.stats` would cause subsequent phased restarts to fail when upgrading/downgrading the json gem. * Fix test name in json test Co-authored-by: rmacklin <1863540+rmacklin@users.noreply.github.com> * Add History entry * Add test for exceptions on values of unexpected types * Update test name for additional clarity * Reorder cases to match order in ECMA-404 * Allow all serializable inputs in Puma::JSON::serialize The pervious implementation was based on and older JSON standard which defined JSON texts to be either objects or arrays. Modern JSON standands allow all JSON values to be valid JSON texts. * Update JSON tests to test value types directly * Reorder tests to roughly match source order * Add test for serializing integers as JSON * Serialize nil as null * Use block form of gsub instead of hash form * Escape control characters as required by ECMA-404 * Collapse handling of Symbol and String into one case * Extract constants used in string serialization * Remove superflous else case * Use stringio for incremental JSON construction * Extract test helper for testing JSON serialization * Assert that strings generated by Puma::JSON roundtrip when using ::JSON * Use a recent version of the json gem in tests `::JSON.parse` doesn't handle JSON texts other than objects and arrays in old versions * Handle default expected_roundtrip more explicitly for clarity Co-authored-by: rmacklin <1863540+rmacklin@users.noreply.github.com>
96 lines
2.9 KiB
Ruby
96 lines
2.9 KiB
Ruby
# frozen_string_literal: true
|
|
require 'stringio'
|
|
|
|
module Puma
|
|
|
|
# Puma deliberately avoids the use of the json gem and instead performs JSON
|
|
# serialization without any external dependencies. In a puma cluster, loading
|
|
# any gem into the puma master process means that operators cannot use a
|
|
# phased restart to upgrade their application if the new version of that
|
|
# application uses a different version of that gem. The json gem in
|
|
# particular is additionally problematic because it leverages native
|
|
# extensions. If the puma master process relies on a gem with native
|
|
# extensions and operators remove gems from disk related to old releases,
|
|
# subsequent phased restarts can fail.
|
|
#
|
|
# The implementation of JSON serialization in this module is not designed to
|
|
# be particularly full-featured or fast. It just has to handle the few places
|
|
# where Puma relies on JSON serialization internally.
|
|
|
|
module JSON
|
|
QUOTE = /"/
|
|
BACKSLASH = /\\/
|
|
CONTROL_CHAR_TO_ESCAPE = /[\x00-\x1F]/ # As required by ECMA-404
|
|
CHAR_TO_ESCAPE = Regexp.union QUOTE, BACKSLASH, CONTROL_CHAR_TO_ESCAPE
|
|
|
|
class SerializationError < StandardError; end
|
|
|
|
class << self
|
|
def generate(value)
|
|
StringIO.open do |io|
|
|
serialize_value io, value
|
|
io.string
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def serialize_value(output, value)
|
|
case value
|
|
when Hash
|
|
output << '{'
|
|
value.each_with_index do |(k, v), index|
|
|
output << ',' if index != 0
|
|
serialize_object_key output, k
|
|
output << ':'
|
|
serialize_value output, v
|
|
end
|
|
output << '}'
|
|
when Array
|
|
output << '['
|
|
value.each_with_index do |member, index|
|
|
output << ',' if index != 0
|
|
serialize_value output, member
|
|
end
|
|
output << ']'
|
|
when Integer, Float
|
|
output << value.to_s
|
|
when String
|
|
serialize_string output, value
|
|
when true
|
|
output << 'true'
|
|
when false
|
|
output << 'false'
|
|
when nil
|
|
output << 'null'
|
|
else
|
|
raise SerializationError, "Unexpected value of type #{value.class}"
|
|
end
|
|
end
|
|
|
|
def serialize_string(output, value)
|
|
output << '"'
|
|
output << value.gsub(CHAR_TO_ESCAPE) do |character|
|
|
case character
|
|
when BACKSLASH
|
|
'\\\\'
|
|
when QUOTE
|
|
'\\"'
|
|
when CONTROL_CHAR_TO_ESCAPE
|
|
'\u%.4X' % character.ord
|
|
end
|
|
end
|
|
output << '"'
|
|
end
|
|
|
|
def serialize_object_key(output, value)
|
|
case value
|
|
when Symbol, String
|
|
serialize_string output, value.to_s
|
|
else
|
|
raise SerializationError, "Could not serialize object of type #{value.class} as object key"
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|