1
0
Fork 0
mirror of https://github.com/puma/puma.git synced 2022-11-09 13:48:40 -05:00
puma--puma/lib/puma
schneems c24c0c8834 Rack handler should use provided default host
This issue is somewhat tricky. When Rails is booted via `rails server` there are two types of configuration options passed, ones specified directly by a user like `rails s -p 3001` will always "win".

For any other config that is not explicitly passed in, puma will consider it a "default". For example when you run `rails s` (without -p) then the default port will be 3000.

There is one other way to configure puma though, and that is via a config file:

```
# config/puma.rb
port 3002
```

This is the order of precedence for configuration

1) Anything the user explicitly passes to `rails s`
2) Config specified in `config/puma.rb` file
3) Default values passed in via `rails s`
4) Defaults values stored in puma

This fallback mechanism works well except in the case of calling `port` in a `config/puma.rb` file. To understand look at the [old method definition](2668597ec1/lib/puma/dsl.rb (L140-L145)):

```
def port(port, host=nil)
  host ||= Configuration::DefaultTCPHost
  bind "tcp://#{host}:#{port}"
end
```

When the `port` method gets called, even if the user did not specify a `host` the `Configuration::DefaultTCPHost` will be used, which is a problem for local development because it defaults to `0.0.0.0`. [SO about 0.0.0.0 versus localhost](https://stackoverflow.com/questions/20778771/what-is-the-difference-between-0-0-0-0-127-0-0-1-and-localhost).

In this case, while a user did directly specify a port, they did not specify a host, so you would expect the `rails s` defaults passed in to take affect.

To make Puma respect that the host coming from `rails s` has more precedence than it's own default host, we must introduce the ability to set and retrieve a default_host value.

This is then used in the rack handler so when `rails s` passes in `:Host => "localhost"` then it is used instead of reverting to `0.0.0.0`.

The issue with #1699 is the test was wrong, it would have failed if a config file was present with a `port` invocation.
2019-01-04 16:09:56 -06:00
..
app Add /gc URL to status server to do a major GC. Add a /gc-status URL to get GC.stats as JSON. (#1384) 2017-08-03 15:46:49 -06:00
plugin Let's use Rubocop! (#1325) 2017-06-04 13:21:05 -07:00
rack Merge branch 'master' into make_ci_work 2018-09-21 10:02:09 -05:00
accept_nonblock.rb Vastly improve IO perf on 1.9.3 2012-08-11 15:09:09 -07:00
binder.rb Merge pull request #1649 from puma/schneems/frozen 2018-10-17 16:16:29 -05:00
cli.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
client.rb Merge pull request #1649 from puma/schneems/frozen 2018-10-17 16:16:29 -05:00
cluster.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
commonlogger.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
compat.rb Remove support for 1.8.7 and 1.9.2. 2016-09-01 23:58:15 +02:00
configuration.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
const.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
control_cli.rb Merge pull request #1649 from puma/schneems/frozen 2018-10-17 16:16:29 -05:00
convenient.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
daemon_ext.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
delegation.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
detect.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
dsl.rb Rack handler should use provided default host 2019-01-04 16:09:56 -06:00
events.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
io_buffer.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
java_io_buffer.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
jruby_restart.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
launcher.rb Merge pull request #1649 from puma/schneems/frozen 2018-10-17 16:16:29 -05:00
minissl.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
null_io.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
plugin.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
rack_default.rb Default Rack handler helper 2013-02-09 20:27:05 -08:00
reactor.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
runner.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
server.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
single.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
state_file.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
tcp_logger.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
thread_pool.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00
util.rb Freeze all the strings! 2018-09-17 11:41:14 -05:00