kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity
rails--rails/actionview/CHANGELOG.md

115 lines
3.8 KiB
Markdown
Raw Normal View History

Extend `ActionView::Helpers#translate` to yield This commit extends the `ActionView::Helpers#translate` (and by way of alias, `#t`) helper methods to accept blocks. When invoked with a block, the `translate` call will yield the translated text as its first block argument, along with the resolved translation key as its second: ```erb <%= translate(".key") do |translation, resolved_key| %> <span data-i18n-key="<%= resolved_key %>"><%= translation %></span> <% end %> ``` In cases where relative translation keys are foregone in lieu of fully qualified keys, or if the caller is not interested in the resolved key, the second block argument can be omitted: ```erb <%= translate("action.template.key") do |translation| %> <p><%= translation %></p> <p><%= translation %>, but a second time</p> <% end %> ``` A benefit of yielding the translation is that it enabled template-local variable re-use. Alternatively, [`Object#tap`][tap] could be used. Prior to this commit, however, the resolution of the translation key was internal to `ActionView`, and unavailable to the caller (unless they were willing to explicitly determine the resolved key themselves). By making it available as a block parameter, it could be used to annotate the translated value in the resulting elements. [tap]: https://ruby-doc.org/core-2.7.0/Object.html#method-i-tap
2020-03-06 10:34:26 -05:00
* `ActionView::Helpers::TranslationHelper#translate` accepts a block, yielding
the translated text and the fully resolved translation key:
<%= translate(".relative_key") do |translation, resolved_key| %>
<span title="<%= resolved_key %>"><%= translation %></span>
<% end %>
*Sean Doyle*
Ensure cache fragment digests include all templates A Rails view may rely on several templates (e.g. layouts and partials) in addition to the template for the action being rendered (e.g. "show.html.erb"). To track which view file is currently being rendered for the purpose of generating template tree digests used in cache fragment keys, Action View uses a stack, the top item of which is accessed via the @current_template variable (introduced in 1581cab). Consider the following template: <!-- home.html.erb --> <%= render layout: "wrapper" do %> <%= cache "foo" %> HOME <%= end %> <%= end %> Inside the block passed to the render helper, @current_template corresponds to the wrapper.html.erb template instead of home.html.erb. As wrapper.html.erb is then used as the root node for generating the template tree digest used in the cache fragment key, the cache fragment fails to expire upon changes to home.html.erb. Additionally, should a second template use the wrapper.html.erb layout and contain a cache fragment with the same key, the cache fragment keys for both templates will be identical - causing cached content to "leak" from one view to another (as described in #38984). This commit skips adding templates to the stack when rendered as a layout with a block via the render helper, ensuring correct and unique cache fragment digests. Additionally, the virtual_path keyword arguments found in CacheHelper and all references to the are removed as they no longer possess any function. (Following the introduction of @current_template, virtual_path is accessed via @current_template.virtual_path rather than as a standalone variable.)
2020-04-24 17:29:00 -04:00
* Ensure cache fragment digests include all relevant template dependencies when
fragments are contained in a block passed to the render helper. Remove the
virtual_path keyword arguments found in CacheHelper as they no longer possess
any function following 1581cab.
Fixup CHANGELOGs [ci skip]
2020-06-06 23:58:22 -04:00
Fixes #38984.
Ensure cache fragment digests include all templates A Rails view may rely on several templates (e.g. layouts and partials) in addition to the template for the action being rendered (e.g. "show.html.erb"). To track which view file is currently being rendered for the purpose of generating template tree digests used in cache fragment keys, Action View uses a stack, the top item of which is accessed via the @current_template variable (introduced in 1581cab). Consider the following template: <!-- home.html.erb --> <%= render layout: "wrapper" do %> <%= cache "foo" %> HOME <%= end %> <%= end %> Inside the block passed to the render helper, @current_template corresponds to the wrapper.html.erb template instead of home.html.erb. As wrapper.html.erb is then used as the root node for generating the template tree digest used in the cache fragment key, the cache fragment fails to expire upon changes to home.html.erb. Additionally, should a second template use the wrapper.html.erb layout and contain a cache fragment with the same key, the cache fragment keys for both templates will be identical - causing cached content to "leak" from one view to another (as described in #38984). This commit skips adding templates to the stack when rendered as a layout with a block via the render helper, ensuring correct and unique cache fragment digests. Additionally, the virtual_path keyword arguments found in CacheHelper and all references to the are removed as they no longer possess any function. (Following the introduction of @current_template, virtual_path is accessed via @current_template.virtual_path rather than as a standalone variable.)
2020-04-24 17:29:00 -04:00
*Aaron Lipman*
Unify raise_on_missing_translations for views and controllers
2017-12-26 19:51:42 -05:00
* Deprecate `config.action_view.raise_on_missing_translations` in favor of
`config.i18n.raise_on_missing_translations`.
New generalized configuration option now determines whether an error should be raised
for missing translations in controllers and views.
*fatkodima*
Fixup CHANGELOGs [ci skip]
2020-06-06 23:58:22 -04:00
* Instrument layout rendering in `TemplateRenderer#render_with_layout` as `render_layout.action_view`,
and include (when necessary) the layout's virtual path in notification payloads for collection and partial renders.
add additional instrumentation block for ActionView layout rendering
2020-04-20 16:28:35 -04:00
*Zach Kemp*
Rename `annotate_template_file_names` to `annotate_rendered_view_with_filenames` - Add the configuration option for annotating templates with file names to the generated app. - Add `annotate_rendered_view_with_filenames` option to configuring guide.
2020-05-09 02:22:12 -04:00
* `ActionView::Base.annotate_rendered_view_with_filenames` annotates HTML output with template file names.
.annotate_template_file_names annotates HTML output with template file names As a developer, when looking at a page in my web browser, it's sometimes difficult to figure out which template(s) are being used to render the page. config.action_view.annotate_template_file_names adds HTML comments to the rendered output indicating where each template begins and ends. Co-authored-by: Aaron Patterson <tenderlove@github.com>
2020-03-30 16:16:31 -04:00
*Joel Hawksley*, *Aaron Patterson*
Fix translate method with default: nil ```ruby I18n.translate('missing.translation', default: nil) # => nil helper.translate('missing.translation', default: nil) # Before # => "<span class=\"translation_missing\" title=\"translation missing: en.missing.translation\">Translation</span>" # After # => nil ```
2019-12-05 17:13:28 -05:00
* `ActionView::Helpers::TranslationHelper#translate` returns nil when
passed `default: nil` without a translation matching `I18n#translate`.
*Stefan Wrobel*
Use default order of PathResolver::EXTENSIONS for sort templates
2019-10-24 16:51:49 -04:00
* `OptimizedFileSystemResolver` prefers template details in order of locale,
formats, variants, handlers.
*Iago Pimenta*
Add changelog entry for https://github.com/rails/rails/pull/37918 Per request from @bogdanvlviv.
2019-12-11 11:20:38 -05:00
* Added `class_names` helper to create a CSS class value with conditional classes.
*Joel Hawksley*, *Aaron Patterson*
Add support for conditional values to TagBuilder Adds support for conditional values to TagBuilder, extracting logic we use in the GitHub application, inspired by https://github.com/JedWatson/classnames. It’s common practice to conditionally apply CSS classes in Rails views. This can lead to messy string interpolation, often using ternaries: ```ruby content_tag( "My username", class: "always #{'sometimes' if current_user.special?} another" ) ``` By adding support for hashes to TagBuilder, we can instead write the following: ```ruby content_tag( "My username", class: ["always", "another", { 'sometimes' => current_user.special? }] ) ``` cc @JedWatson
2019-12-03 13:18:01 -05:00
* Add support for conditional values to TagBuilder.
*Joel Hawksley*
Add changelog entry for https://github.com/rails/rails/pull/37918 Per request from @bogdanvlviv.
2019-12-11 11:20:38 -05:00
`ActionView::Helpers::FormOptionsHelper#select` should mark option for `nil` as selected ```ruby @post = Post.new @post.category = nil # Before select("post", "category", none: nil, programming: 1, economics: 2) # => # <select name="post[category]" id="post_category"> # <option value="">none</option> # <option value="1">programming</option> # <option value="2">economics</option> # </select> # After select("post", "category", none: nil, programming: 1, economics: 2) # => # <select name="post[category]" id="post_category"> # <option selected="selected" value="">none</option> # <option value="1">programming</option> # <option value="2">economics</option> # </select> ``` To get the same result without these changes we can set `:selected` as `@post.category.to_s`: ```ruby select("post", "category", {none: nil, programming: 1, economics: 2}, {selected: @post.category.to_s} ```
2018-12-27 11:18:32 -05:00
* `ActionView::Helpers::FormOptionsHelper#select` should mark option for `nil` as selected.
```ruby
@post = Post.new
@post.category = nil
# Before
select("post", "category", none: nil, programming: 1, economics: 2)
# =>
# <select name="post[category]" id="post_category">
# <option value="">none</option>
# <option value="1">programming</option>
# <option value="2">economics</option>
# </select>
# After
select("post", "category", none: nil, programming: 1, economics: 2)
# =>
# <select name="post[category]" id="post_category">
# <option selected="selected" value="">none</option>
# <option value="1">programming</option>
# <option value="2">economics</option>
# </select>
```
*bogdanvlviv*
Logging at info level should be reserved for top-level concerns Information about partials and cable connection notices are too low level.
2019-08-25 14:39:58 -04:00
* Log lines for partial renders and started template renders are now
emitted at the `DEBUG` level instead of `INFO`.
Completed template renders are still logged at the `INFO` level.
*DHH*
Update sanitizer in ActionView::Helpers::SanitizeHelper - The sanitizer has been changed to safe_list_sanitizer. - deprecate white_list_sanitizer
2019-05-14 00:09:39 -04:00
* ActionView::Helpers::SanitizeHelper: support rails-html-sanitizer 1.1.0.
*Juanito Fatas*
Fixup CHANGELOGs [ci skip]
2019-11-23 19:20:00 -05:00
* Added `phone_to` helper method to create a link from mobile numbers.
Added a phone_to helper method, on the style of mail_to and sms_to. (#36775) * Added a phone_to helper method, on the style of mail_to and sms_to. It creates an anchor tag with the href set to tel: *here your number* which, when clicked on a mobile phone, or on a desktop with a supported application, lets the phone app kick in, and it prepopulates it with the phone number specified. [Pietro Moro + Rafael Mendonça França]
2019-07-26 14:54:57 -04:00
*Pietro Moro*
Empty array instead of nil for source_extract The source_extract method will return nil when it can't find the file name in the backtrace, methods that consume this method expect an array and the nil ends up causing type errors down the road like it happened here: #36341. This patch refactors the source_extract method so that it returns an empty array instead of nil when it can't find the source code. Co-authored-by: Kasper Timm Hansen <kaspth@gmail.com>
2019-06-21 15:04:28 -04:00
* annotated_source_code returns an empty array so TemplateErrors without a
template in the backtrace are surfaced properly by DebugExceptions.
*Guilherme Mansur*, *Kasper Timm Hansen*
Autoload SyntaxErrorInTemplate When a SyntaxError is detected in a template we raise this exception. On a first request to the server the exception we get a NameError since the exception is not required from `active_view/template/error.rb` yet. However later on it gets required and a second request will succeed. On the first request we see the rails "Something Wen Wrong" page and not the expected syntax error in template error page with the webconsole and stacktrace. By autoloading the constant we fix this issue. Co-authored-by: Gannon McGibbon <gannon.mcgibbon@gmail.com>
2019-06-19 13:42:52 -04:00
* Add autoload for SyntaxErrorInTemplate so syntax errors are correctly raised by DebugExceptions.
*Guilherme Mansur*, *Gannon McGibbon*
Fixup CHANGELOGs [ci skip]
2019-11-23 19:20:00 -05:00
* `RenderingHelper` supports rendering objects that `respond_to?` `:render_in`.
`RenderingHelper` supports rendering objects that `respond_to?` `:render_in` Co-authored-by: Natasha Umer <natashau@github.com> Co-authored-by: Aaron Patterson <tenderlove@github.com> Co-authored-by: Shawn Allen <shawnbot@github.com> Co-authored-by: Emily Plummer <emplums@github.com> Co-authored-by: Diana Mounter <broccolini@github.com> Co-authored-by: John Hawthorn <jhawthorn@github.com> Co-authored-by: Nathan Herald <myobie@github.com> Co-authored-by: Zaid Zawaideh <zawaideh@github.com> Co-authored-by: Zach Ahn <engineering@zachahn.com>
2019-05-29 15:03:54 -04:00
*Joel Hawksley*, *Natasha Umer*, *Aaron Patterson*, *Shawn Allen*, *Emily Plummer*, *Diana Mounter*, *John Hawthorn*, *Nathan Herald*, *Zaid Zawaideh*, *Zach Ahn*
Add support for conditional values to TagBuilder Adds support for conditional values to TagBuilder, extracting logic we use in the GitHub application, inspired by https://github.com/JedWatson/classnames. It’s common practice to conditionally apply CSS classes in Rails views. This can lead to messy string interpolation, often using ternaries: ```ruby content_tag( "My username", class: "always #{'sometimes' if current_user.special?} another" ) ``` By adding support for hashes to TagBuilder, we can instead write the following: ```ruby content_tag( "My username", class: ["always", "another", { 'sometimes' => current_user.special? }] ) ``` cc @JedWatson
2019-12-03 13:18:01 -05:00
Fix select_tag so that is doesn't change options when include_blank is set
2019-05-22 04:21:59 -04:00
* Fix `select_tag` so that it doesn't change `options` when `include_blank` is present.
*Younes SERRAJ*
Update the changelog to explain the fix
2019-04-19 12:34:53 -04:00
Start Rails 6.1 development
2019-04-24 15:57:14 -04:00
Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/actionview/CHANGELOG.md) for previous changes.
Copy permalink