kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity
rails--rails/activerecord/CHANGELOG.md

45 lines
1.1 KiB
Markdown
Raw Normal View History

Add database_exists? method to connection adapters When SQLite connects it will silently create a database if the database does not exist. This behaviour causes different issues because of inconsistent behaviour between adapters: #36383, #32914. This commit adds a `database_exists?` method as a way to check the database without creating it. This is a stepping stone to fully resolving the above issues.
2019-06-10 16:22:29 -04:00
* Add database_exists? method to connection adapters to check if a database exists.
Fix indentation 💇‍♀️ Ref https://github.com/rails/rails/pull/36621#discussion_r301208961
2019-07-08 15:53:55 -04:00
*Guilherme Mansur*
Add database_exists? method to connection adapters When SQLite connects it will silently create a database if the database does not exist. This behaviour causes different issues because of inconsistent behaviour between adapters: #36383, #32914. This commit adds a `database_exists?` method as a way to check the database without creating it. This is a stepping stone to fully resolving the above issues.
2019-06-10 16:22:29 -04:00
Better error message for calling columns_hash When a record does not have a table name, as in the case for a record with `self.abstract_class = true` and no `self.table_name` set the error message raises a cryptic: "ActiveRecord::StatementInvalid: Could not find table ''" this patch now raises a new `TableNotSpecified Error` Fixes: #36274 Co-Authored-By: Eugene Kenny <elkenny@gmail.com>
2019-05-14 15:13:29 -04:00
* Loading the schema for a model that has no `table_name` raises a `TableNotSpecified` error.
*Guilherme Mansur*, *Eugene Kenny*
PostgreSQL: Fix GROUP BY with ORDER BY virtual count attribute GROUP BY with virtual count attribute is invalid for almost all databases, but it is valid for PostgreSQL, and it had worked until Rails 5.2.2, so it is a regression for Rails 5.2.3 (caused by 311f001). I can't find perfectly solution for fixing this for now, but I would not like to break existing apps, so I decided to allow referencing virtual count attribute in ORDER BY clause when GROUP BY aggrigation (it partly revert the effect of 311f001) to fix the regression #36022. Fixes #36022.
2019-06-17 08:49:28 -04:00
* PostgreSQL: Fix GROUP BY with ORDER BY virtual count attribute.
Fixes #36022.
*Ryuta Kamizono*
Make ActiveRecord `ConnectionPool.connections` thread-safe. (#36473) * Make ActiveRecord `ConnectionPool.connections` thread-safe. ConnectionPool documentation is clear on the need to synchronize access to @connections but also states that public methods do not require synchronization. Existing code exposed @connections directly via attr_reader. The fix uses synchronize() to lock @connections then returns a copy to the caller using Array.dup(). Includes comments on the connections method that thread-safe access to the connections array does not imply thread-safety of accessing methods on the actual connections. Adds a test-case that modifies the pool using a supported method in one thread while a second thread accesses pool.connections. The test fails without this patch. Fixes #36465. * Update activerecord/test/cases/connection_pool_test.rb [jeffdoering + Rafael Mendonça França]
2019-06-13 14:23:13 -04:00
* Make ActiveRecord `ConnectionPool.connections` method thread-safe.
Fixes #36465.
*Jeff Doering*
Convert the db:abort_if_pending_migrations task to be multi-DB aware
2019-06-07 14:13:18 -04:00
* Add support for multiple databases to `rails db:abort_if_pending_migrations`.
*Mark Lee*
Fix sqlite3 collation parsing when using decimal columns. If an sqlite3 table contains a decimal column behind columns with a collation definition, then parsing the collation of all preceeding columns will fail -- the collation will be missed without notice.
2019-06-04 09:47:21 -04:00
* Fix sqlite3 collation parsing when using decimal columns.
*Martin R. Schuster*
Unify to use 4 spaces indentation in CHANGELOGs [ci skip] Especially, somehow `CHANGELOG.md` in actiontext and activestorage in master branch had used 3 spaces indentation.
2019-06-04 16:47:33 -04:00
* Fix invalid schema when primary key column has a comment.
Fix invalid schema dump when primary key column has a comment Before this fix it would either generate an invalid schema, passing `comment` option twice to `create_table`, or it move the comment from primary key column to the table if table had no comment when the dump was generated. The situation now is that a comment on primary key will be ignored (not present on schema). Fixes #29966
2019-06-03 07:05:36 -04:00
Unify to use 4 spaces indentation in CHANGELOGs [ci skip] Especially, somehow `CHANGELOG.md` in actiontext and activestorage in master branch had used 3 spaces indentation.
2019-06-04 16:47:33 -04:00
Fixes #29966.
Fix invalid schema dump when primary key column has a comment Before this fix it would either generate an invalid schema, passing `comment` option twice to `create_table`, or it move the comment from primary key column to the table if table had no comment when the dump was generated. The situation now is that a comment on primary key will be ignored (not present on schema). Fixes #29966
2019-06-03 07:05:36 -04:00
*Guilherme Goettems Schneider*
Unify to use 4 spaces indentation in CHANGELOGs [ci skip] Especially, somehow `CHANGELOG.md` in actiontext and activestorage in master branch had used 3 spaces indentation.
2019-06-04 16:47:33 -04:00
* Fix table comment also being applied to the primary key column.
Fix table comment also being applied to the primary key column
2019-05-31 15:59:47 -04:00
*Guilherme Goettems Schneider*
[skip ci] Fix missing punctuation mark and formatting
2019-05-13 01:39:16 -04:00
* Allow generated `create_table` migrations to include or skip timestamps.
Adds touch option to has_one association
2019-04-05 00:44:30 -04:00
Unify to use 4 spaces indentation in CHANGELOGs [ci skip] Especially, somehow `CHANGELOG.md` in actiontext and activestorage in master branch had used 3 spaces indentation.
2019-06-04 16:47:33 -04:00
*Michael Duchemin*
Adds touch option to has_one association
2019-04-05 00:44:30 -04:00
Start Rails 6.1 development
2019-04-24 15:57:14 -04:00
Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/activerecord/CHANGELOG.md) for previous changes.
Copy permalink