2016-08-06 12:26:20 -04:00
|
|
|
require "cases/helper"
|
|
|
|
require "models/topic"
|
|
|
|
require "models/author"
|
|
|
|
require "models/post"
|
2011-02-10 12:56:50 -05:00
|
|
|
|
2017-04-04 22:35:47 -04:00
|
|
|
if ActiveRecord::Base.connection.prepared_statements
|
2017-03-22 11:21:05 -04:00
|
|
|
module ActiveRecord
|
|
|
|
class BindParameterTest < ActiveRecord::TestCase
|
2017-04-27 02:44:25 -04:00
|
|
|
fixtures :topics, :authors, :author_addresses, :posts
|
2017-03-22 11:21:05 -04:00
|
|
|
|
|
|
|
class LogListener
|
|
|
|
attr_accessor :calls
|
|
|
|
|
|
|
|
def initialize
|
|
|
|
@calls = []
|
|
|
|
end
|
|
|
|
|
|
|
|
def call(*args)
|
|
|
|
calls << args
|
|
|
|
end
|
2011-02-10 12:56:50 -05:00
|
|
|
end
|
|
|
|
|
2017-03-22 11:21:05 -04:00
|
|
|
def setup
|
|
|
|
super
|
|
|
|
@connection = ActiveRecord::Base.connection
|
|
|
|
@subscriber = LogListener.new
|
|
|
|
@pk = Topic.columns_hash[Topic.primary_key]
|
|
|
|
@subscription = ActiveSupport::Notifications.subscribe("sql.active_record", @subscriber)
|
2011-02-10 12:56:50 -05:00
|
|
|
end
|
|
|
|
|
2017-03-22 11:21:05 -04:00
|
|
|
def teardown
|
|
|
|
ActiveSupport::Notifications.unsubscribe(@subscription)
|
|
|
|
end
|
2011-02-10 12:56:50 -05:00
|
|
|
|
2015-01-05 18:25:19 -05:00
|
|
|
def test_bind_from_join_in_subquery
|
2016-08-06 12:26:20 -04:00
|
|
|
subquery = Author.joins(:thinking_posts).where(name: "David")
|
|
|
|
scope = Author.from(subquery, "authors").where(id: 1)
|
2015-01-05 18:25:19 -05:00
|
|
|
assert_equal 1, scope.count
|
|
|
|
end
|
|
|
|
|
2013-11-08 10:57:51 -05:00
|
|
|
def test_binds_are_logged
|
2017-05-03 14:11:33 -04:00
|
|
|
binds = [bind_attribute("id", 1)]
|
|
|
|
sql = "select * from topics where id = #{bind_param.to_sql}"
|
2011-02-10 12:56:50 -05:00
|
|
|
|
2016-08-06 12:26:20 -04:00
|
|
|
@connection.exec_query(sql, "SQL", binds)
|
2011-02-10 12:56:50 -05:00
|
|
|
|
2014-03-29 09:52:56 -04:00
|
|
|
message = @subscriber.calls.find { |args| args[4][:sql] == sql }
|
2013-11-08 10:57:51 -05:00
|
|
|
assert_equal binds, message[4][:binds]
|
|
|
|
end
|
2011-02-10 16:34:33 -05:00
|
|
|
|
2013-11-08 10:57:51 -05:00
|
|
|
def test_find_one_uses_binds
|
|
|
|
Topic.find(1)
|
2015-01-27 15:42:02 -05:00
|
|
|
message = @subscriber.calls.find { |args| args[4][:binds].any? { |attr| attr.value == 1 } }
|
2016-08-06 12:26:20 -04:00
|
|
|
assert message, "expected a message with binds"
|
2013-11-08 10:57:51 -05:00
|
|
|
end
|
2011-02-10 16:34:33 -05:00
|
|
|
|
2017-03-22 11:21:05 -04:00
|
|
|
def test_logs_binds_after_type_cast
|
2017-05-03 14:11:33 -04:00
|
|
|
binds = [bind_attribute("id", "10", Type::Integer.new)]
|
2017-03-22 11:21:05 -04:00
|
|
|
assert_logs_binds(binds)
|
2013-11-08 10:57:51 -05:00
|
|
|
end
|
2016-07-18 21:20:58 -04:00
|
|
|
|
2017-03-22 11:21:05 -04:00
|
|
|
def test_logs_legacy_binds_after_type_cast
|
|
|
|
binds = [[@pk, "10"]]
|
|
|
|
assert_logs_binds(binds)
|
2016-07-18 21:20:58 -04:00
|
|
|
end
|
2017-03-22 11:21:05 -04:00
|
|
|
|
2017-04-04 22:35:47 -04:00
|
|
|
def test_deprecate_supports_statement_cache
|
|
|
|
assert_deprecated { ActiveRecord::Base.connection.supports_statement_cache? }
|
|
|
|
end
|
|
|
|
|
2017-03-22 11:21:05 -04:00
|
|
|
private
|
|
|
|
def assert_logs_binds(binds)
|
|
|
|
payload = {
|
|
|
|
name: "SQL",
|
|
|
|
sql: "select * from topics where id = ?",
|
|
|
|
binds: binds,
|
|
|
|
type_casted_binds: @connection.type_casted_binds(binds)
|
|
|
|
}
|
|
|
|
|
|
|
|
event = ActiveSupport::Notifications::Event.new(
|
|
|
|
"foo",
|
|
|
|
Time.now,
|
|
|
|
Time.now,
|
|
|
|
123,
|
|
|
|
payload)
|
|
|
|
|
|
|
|
logger = Class.new(ActiveRecord::LogSubscriber) {
|
|
|
|
attr_reader :debugs
|
|
|
|
|
|
|
|
def initialize
|
|
|
|
super
|
|
|
|
@debugs = []
|
|
|
|
end
|
|
|
|
|
|
|
|
def debug(str)
|
|
|
|
@debugs << str
|
|
|
|
end
|
|
|
|
}.new
|
|
|
|
|
|
|
|
logger.sql(event)
|
|
|
|
assert_match([[@pk.name, 10]].inspect, logger.debugs.first)
|
|
|
|
end
|
2012-05-13 03:27:52 -04:00
|
|
|
end
|
2011-02-10 12:56:50 -05:00
|
|
|
end
|
|
|
|
end
|