2017-08-14 13:08:09 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2017-02-23 12:15:28 -05:00
|
|
|
require "isolation/abstract_unit"
|
|
|
|
require "rails/secrets"
|
|
|
|
|
|
|
|
class Rails::SecretsTest < ActiveSupport::TestCase
|
|
|
|
include ActiveSupport::Testing::Isolation
|
|
|
|
|
2017-11-12 11:32:52 -05:00
|
|
|
setup :build_app
|
|
|
|
teardown :teardown_app
|
2017-02-23 12:15:28 -05:00
|
|
|
|
|
|
|
test "setting read to false skips parsing" do
|
2017-04-01 00:22:25 -04:00
|
|
|
run_secrets_generator do
|
|
|
|
Rails::Secrets.write(<<-end_of_secrets)
|
2017-09-06 18:32:39 -04:00
|
|
|
production:
|
2017-04-01 00:22:25 -04:00
|
|
|
yeah_yeah: lets-walk-in-the-cool-evening-light
|
|
|
|
end_of_secrets
|
2017-02-23 12:15:28 -05:00
|
|
|
|
2017-09-06 18:32:39 -04:00
|
|
|
add_to_env_config("production", "config.read_encrypted_secrets = false")
|
|
|
|
app("production")
|
|
|
|
|
2017-04-01 00:22:25 -04:00
|
|
|
assert_not Rails.application.secrets.yeah_yeah
|
2017-02-23 12:15:28 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
test "raises when reading secrets without a key" do
|
|
|
|
run_secrets_generator do
|
|
|
|
FileUtils.rm("config/secrets.yml.key")
|
|
|
|
|
|
|
|
assert_raises Rails::Secrets::MissingKeyError do
|
|
|
|
Rails::Secrets.key
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
test "reading with ENV variable" do
|
|
|
|
run_secrets_generator do
|
2018-12-20 12:44:01 -05:00
|
|
|
old_key = ENV["RAILS_MASTER_KEY"]
|
|
|
|
ENV["RAILS_MASTER_KEY"] = IO.binread("config/secrets.yml.key").strip
|
|
|
|
FileUtils.rm("config/secrets.yml.key")
|
|
|
|
|
|
|
|
assert_match "# production:\n# external_api_key:", Rails::Secrets.read
|
|
|
|
ensure
|
|
|
|
ENV["RAILS_MASTER_KEY"] = old_key
|
2017-02-23 12:15:28 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
test "reading from key file" do
|
|
|
|
run_secrets_generator do
|
2017-03-02 13:38:01 -05:00
|
|
|
File.binwrite("config/secrets.yml.key", "00112233445566778899aabbccddeeff")
|
2017-02-23 12:15:28 -05:00
|
|
|
|
2017-03-02 13:38:01 -05:00
|
|
|
assert_equal "00112233445566778899aabbccddeeff", Rails::Secrets.key
|
2017-02-23 12:15:28 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
test "editing" do
|
|
|
|
run_secrets_generator do
|
|
|
|
decrypted_path = nil
|
|
|
|
|
|
|
|
Rails::Secrets.read_for_editing do |tmp_path|
|
|
|
|
decrypted_path = tmp_path
|
|
|
|
|
2017-08-22 16:59:05 -04:00
|
|
|
assert_match(/# production:\n# external_api_key/, File.read(tmp_path))
|
2017-02-23 12:15:28 -05:00
|
|
|
|
|
|
|
File.write(tmp_path, "Empty streets, empty nights. The Downtown Lights.")
|
|
|
|
end
|
|
|
|
|
|
|
|
assert_not File.exist?(decrypted_path)
|
|
|
|
assert_equal "Empty streets, empty nights. The Downtown Lights.", Rails::Secrets.read
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
test "merging secrets with encrypted precedence" do
|
|
|
|
run_secrets_generator do
|
|
|
|
File.write("config/secrets.yml", <<-end_of_secrets)
|
2017-09-06 18:32:39 -04:00
|
|
|
production:
|
2017-02-23 12:15:28 -05:00
|
|
|
yeah_yeah: lets-go-walking-down-this-empty-street
|
|
|
|
end_of_secrets
|
|
|
|
|
|
|
|
Rails::Secrets.write(<<-end_of_secrets)
|
2017-09-06 18:32:39 -04:00
|
|
|
production:
|
2017-02-23 12:15:28 -05:00
|
|
|
yeah_yeah: lets-walk-in-the-cool-evening-light
|
|
|
|
end_of_secrets
|
|
|
|
|
2017-09-06 18:32:39 -04:00
|
|
|
add_to_env_config("production", "config.read_encrypted_secrets = true")
|
|
|
|
app("production")
|
|
|
|
|
2017-02-23 12:15:28 -05:00
|
|
|
assert_equal "lets-walk-in-the-cool-evening-light", Rails.application.secrets.yeah_yeah
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-04-01 00:22:25 -04:00
|
|
|
test "refer secrets inside env config" do
|
|
|
|
run_secrets_generator do
|
|
|
|
Rails::Secrets.write(<<-end_of_yaml)
|
|
|
|
production:
|
|
|
|
some_secret: yeah yeah
|
|
|
|
end_of_yaml
|
|
|
|
|
|
|
|
add_to_env_config "production", <<-end_of_config
|
|
|
|
config.dereferenced_secret = Rails.application.secrets.some_secret
|
|
|
|
end_of_config
|
|
|
|
|
2017-09-06 18:32:39 -04:00
|
|
|
app("production")
|
|
|
|
|
|
|
|
assert_equal "yeah yeah", Rails.application.config.dereferenced_secret
|
2017-04-01 00:22:25 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-07-06 19:17:01 -04:00
|
|
|
test "do not update secrets.yml.enc when secretes do not change" do
|
|
|
|
run_secrets_generator do
|
2017-07-21 08:21:45 -04:00
|
|
|
Rails::Secrets.read_for_editing do |tmp_path|
|
|
|
|
File.write(tmp_path, "Empty streets, empty nights. The Downtown Lights.")
|
|
|
|
end
|
2017-07-06 19:17:01 -04:00
|
|
|
|
2017-07-21 08:21:45 -04:00
|
|
|
FileUtils.cp("config/secrets.yml.enc", "config/secrets.yml.enc.bk")
|
2017-07-06 19:17:01 -04:00
|
|
|
|
2017-07-21 08:21:45 -04:00
|
|
|
Rails::Secrets.read_for_editing do |tmp_path|
|
|
|
|
File.write(tmp_path, "Empty streets, empty nights. The Downtown Lights.")
|
2017-07-06 19:17:01 -04:00
|
|
|
end
|
2017-07-21 08:21:45 -04:00
|
|
|
|
|
|
|
assert_equal File.read("config/secrets.yml.enc.bk"), File.read("config/secrets.yml.enc")
|
2017-07-06 19:17:01 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-07-08 05:53:32 -04:00
|
|
|
test "can read secrets written in binary" do
|
|
|
|
run_secrets_generator do
|
|
|
|
secrets = <<-end_of_secrets
|
|
|
|
production:
|
|
|
|
api_key: 00112233445566778899aabbccddeeff…
|
|
|
|
end_of_secrets
|
|
|
|
|
2017-07-22 08:45:53 -04:00
|
|
|
Rails::Secrets.write(secrets.dup.force_encoding(Encoding::ASCII_8BIT))
|
2017-07-08 05:53:32 -04:00
|
|
|
|
|
|
|
Rails::Secrets.read_for_editing do |tmp_path|
|
|
|
|
assert_match(/production:\n\s*api_key: 00112233445566778899aabbccddeeff…\n/, File.read(tmp_path))
|
|
|
|
end
|
|
|
|
|
2017-09-06 18:32:39 -04:00
|
|
|
app("production")
|
|
|
|
|
|
|
|
assert_equal "00112233445566778899aabbccddeeff…", Rails.application.secrets.api_key
|
2017-07-08 05:53:32 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
test "can read secrets written in non-binary" do
|
|
|
|
run_secrets_generator do
|
|
|
|
secrets = <<-end_of_secrets
|
|
|
|
production:
|
|
|
|
api_key: 00112233445566778899aabbccddeeff…
|
|
|
|
end_of_secrets
|
|
|
|
|
|
|
|
Rails::Secrets.write(secrets)
|
|
|
|
|
|
|
|
Rails::Secrets.read_for_editing do |tmp_path|
|
2017-07-22 08:45:53 -04:00
|
|
|
assert_equal(secrets.dup.force_encoding(Encoding::ASCII_8BIT), IO.binread(tmp_path))
|
2017-07-08 05:53:32 -04:00
|
|
|
end
|
|
|
|
|
2017-09-06 18:32:39 -04:00
|
|
|
app("production")
|
|
|
|
|
|
|
|
assert_equal "00112233445566778899aabbccddeeff…", Rails.application.secrets.api_key
|
2017-07-08 05:53:32 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-02-23 12:15:28 -05:00
|
|
|
private
|
|
|
|
def run_secrets_generator
|
|
|
|
Dir.chdir(app_path) do
|
2017-11-12 11:32:52 -05:00
|
|
|
File.write("config/secrets.yml.key", "f731758c639da2604dfb6bf3d1025de8")
|
|
|
|
File.write("config/secrets.yml.enc", "sEB0mHxDbeP1/KdnMk00wyzPFACl9K6t0cZWn5/Mfx/YbTHvnI07vrneqHg9kaH3wOS7L6pIQteu1P077OtE4BSx/ZRc/sgQPHyWu/tXsrfHqnPNpayOF/XZqizE91JacSFItNMWpuPsp9ynbzz+7cGhoB1S4aPNIU6u0doMrzdngDbijsaAFJmsHIQh6t/QHoJx--8aMoE0PvUWmw1Iqz--ldFqnM/K0g9k17M8PKoN/Q==")
|
2017-02-23 12:15:28 -05:00
|
|
|
|
Add credentials using a generic EncryptedConfiguration class (#30067)
* WIP: Add credentials using a generic EncryptedConfiguration class
This is sketch code so far.
* Flesh out EncryptedConfiguration and test it
* Better name
* Add command and generator for credentials
* Use the Pathnames
* Extract EncryptedFile from EncryptedConfiguration and add serializers
* Test EncryptedFile
* Extract serializer validation
* Stress the point about losing comments
* Allow encrypted configuration to be read without parsing for display
* Use credentials by default and base them on the master key
* Derive secret_key_base in test/dev, source it from credentials in other envs
And document the usage.
* Document the new credentials setup
* Stop generating the secrets.yml file now that we have credentials
* Document what we should have instead
Still need to make it happen, tho.
* [ci skip] Keep wording to `key base`; prefer defaults.
Usually we say we change defaults, not "spec" out a release.
Can't use backticks in our sdoc generated documentation either.
* Abstract away OpenSSL; prefer MessageEncryptor.
* Spare needless new when raising.
* Encrypted file test shouldn't depend on subclass.
* [ci skip] Some woordings.
* Ditch serializer future coding.
* I said flip it. Flip it good.
* [ci skip] Move require_master_key to the real production.rb.
* Add require_master_key to abort the boot process.
In case the master key is required in a certain environment
we should inspect that the key is there and abort if it isn't.
* Print missing key message and exit immediately.
Spares us a lengthy backtrace and prevents further execution.
I've verified the behavior in a test app, but couldn't figure the
test out as loading the app just exits immediately with:
```
/Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `load': marshal data too short (ArgumentError)
from /Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `run'
from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest.rb:830:in `run_one_method'
from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest/parallel.rb:32:in `block (2 levels) in start'
```
It's likely we need to capture and prevent the exit somehow.
Kernel.stub(:exit) didn't work. Leaving it for tomorrow.
* Fix require_master_key config test.
Loading the app would trigger the `exit 1` per require_master_key's
semantics, which then aborted the test.
Fork and wait for the child process to finish, then inspect the
exit status.
Also check we aborted because of a missing master key, so something
else didn't just abort the boot.
Much <3 to @tenderlove for the tip.
* Support reading/writing configs via methods.
* Skip needless deep symbolizing.
* Remove save; test config reader elsewhere.
* Move secret_key_base check to when we're reading it.
Otherwise we'll abort too soon since we don't assign the secret_key_base
to secrets anymore.
* Add missing string literal comments; require unneeded yaml require.
* ya ya ya, rubocop.
* Add master_key/credentials after bundle.
Then we can reuse the existing message on `rails new bc4`.
It'll look like:
```
Using web-console 3.5.1 from https://github.com/rails/web-console.git (at master@ce985eb)
Using rails 5.2.0.alpha from source at `/Users/kasperhansen/Documents/code/rails`
Using sass-rails 5.0.6
Bundle complete! 16 Gemfile dependencies, 72 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
Adding config/master.key to store the master encryption key: 97070158c44b4675b876373a6bc9d5a0
Save this in a password manager your team can access.
If you lose the key, no one, including you, can access anything encrypted with it.
create config/master.key
```
And that'll be executed even if `--skip-bundle` was passed.
* Ensure test app has secret_key_base.
* Assign secret_key_base to app or omit.
* Merge noise
* Split options for dynamic delegation into its own method and use deep symbols to make it work
* Update error to point to credentials instead
* Appease Rubocop
* Validate secret_key_base when reading it.
Instead of relying on the validation in key_generator move that into
secret_key_base itself.
* Fix generator and secrets test.
Manually add config.read_encrypted_secrets since it's not there by default
anymore.
Move mentions of config/secrets.yml to config/credentials.yml.enc.
* Remove files I have no idea how they got here.
* [ci skip] swap secrets for credentials.
* [ci skip] And now, changelogs are coming.
2017-09-11 14:21:20 -04:00
|
|
|
add_to_config <<-RUBY
|
|
|
|
config.read_encrypted_secrets = true
|
|
|
|
RUBY
|
|
|
|
|
2017-02-23 12:15:28 -05:00
|
|
|
yield
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|