2017-07-24 16:20:53 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-08-06 12:54:50 -04:00
|
|
|
require "abstract_unit"
|
|
|
|
require "fixtures/session_autoload_test/session_autoload_test/foo"
|
2011-10-21 14:13:29 -04:00
|
|
|
|
|
|
|
class CacheStoreTest < ActionDispatch::IntegrationTest
|
|
|
|
class TestController < ActionController::Base
|
|
|
|
def no_session_access
|
|
|
|
head :ok
|
|
|
|
end
|
|
|
|
|
|
|
|
def set_session_value
|
|
|
|
session[:foo] = "bar"
|
|
|
|
head :ok
|
|
|
|
end
|
|
|
|
|
|
|
|
def set_serialized_session_value
|
|
|
|
session[:foo] = SessionAutoloadTest::Foo.new
|
|
|
|
head :ok
|
|
|
|
end
|
|
|
|
|
|
|
|
def get_session_value
|
2015-07-17 21:48:00 -04:00
|
|
|
render plain: "foo: #{session[:foo].inspect}"
|
2011-10-21 14:13:29 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def get_session_id
|
2019-12-17 16:44:59 -05:00
|
|
|
render plain: "#{request.session.id.public_id}"
|
2011-10-21 14:13:29 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def call_reset_session
|
|
|
|
session[:bar]
|
|
|
|
reset_session
|
|
|
|
session[:bar] = "baz"
|
|
|
|
head :ok
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_setting_and_getting_session_value
|
|
|
|
with_test_route_set do
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/set_session_value"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
2016-08-06 12:54:50 -04:00
|
|
|
assert cookies["_session_id"]
|
2011-10-21 14:13:29 -04:00
|
|
|
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/get_session_value"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
|
|
|
assert_equal 'foo: "bar"', response.body
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_getting_nil_session_value
|
|
|
|
with_test_route_set do
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/get_session_value"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
2016-08-06 12:54:50 -04:00
|
|
|
assert_equal "foo: nil", response.body
|
2011-10-21 14:13:29 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_getting_session_value_after_session_reset
|
|
|
|
with_test_route_set do
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/set_session_value"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
2016-08-06 12:54:50 -04:00
|
|
|
assert cookies["_session_id"]
|
|
|
|
session_cookie = cookies.send(:hash_for)["_session_id"]
|
2011-10-21 14:13:29 -04:00
|
|
|
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/call_reset_session"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
2016-08-06 12:54:50 -04:00
|
|
|
assert_not_equal [], headers["Set-Cookie"]
|
2011-10-21 14:13:29 -04:00
|
|
|
|
|
|
|
cookies << session_cookie # replace our new session_id with our old, pre-reset session_id
|
|
|
|
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/get_session_value"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
2016-08-06 12:54:50 -04:00
|
|
|
assert_equal "foo: nil", response.body, "data for this session should have been obliterated from cache"
|
2011-10-21 14:13:29 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_getting_from_nonexistent_session
|
|
|
|
with_test_route_set do
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/get_session_value"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
2016-08-06 12:54:50 -04:00
|
|
|
assert_equal "foo: nil", response.body
|
|
|
|
assert_nil cookies["_session_id"], "should only create session on write, not read"
|
2011-10-21 14:13:29 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_setting_session_value_after_session_reset
|
|
|
|
with_test_route_set do
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/set_session_value"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
2016-08-06 12:54:50 -04:00
|
|
|
assert cookies["_session_id"]
|
|
|
|
session_id = cookies["_session_id"]
|
2011-10-21 14:13:29 -04:00
|
|
|
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/call_reset_session"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
2016-08-06 12:54:50 -04:00
|
|
|
assert_not_equal [], headers["Set-Cookie"]
|
2011-10-21 14:13:29 -04:00
|
|
|
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/get_session_value"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
2016-08-06 12:54:50 -04:00
|
|
|
assert_equal "foo: nil", response.body
|
2011-10-21 14:13:29 -04:00
|
|
|
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/get_session_id"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
|
|
|
assert_not_equal session_id, response.body
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_getting_session_id
|
|
|
|
with_test_route_set do
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/set_session_value"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
2016-08-06 12:54:50 -04:00
|
|
|
assert cookies["_session_id"]
|
|
|
|
session_id = cookies["_session_id"]
|
2011-10-21 14:13:29 -04:00
|
|
|
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/get_session_id"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
|
|
|
assert_equal session_id, response.body, "should be able to read session id without accessing the session hash"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_deserializes_unloaded_class
|
|
|
|
with_test_route_set do
|
|
|
|
with_autoload_path "session_autoload_test" do
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/set_serialized_session_value"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
2016-08-06 12:54:50 -04:00
|
|
|
assert cookies["_session_id"]
|
2011-10-21 14:13:29 -04:00
|
|
|
end
|
|
|
|
with_autoload_path "session_autoload_test" do
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/get_session_id"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
|
|
|
end
|
|
|
|
with_autoload_path "session_autoload_test" do
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/get_session_value"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
|
|
|
assert_equal 'foo: #<SessionAutoloadTest::Foo bar:"baz">', response.body, "should auto-load unloaded class"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_doesnt_write_session_cookie_if_session_id_is_already_exists
|
|
|
|
with_test_route_set do
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/set_session_value"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
2016-08-06 12:54:50 -04:00
|
|
|
assert cookies["_session_id"]
|
2011-10-21 14:13:29 -04:00
|
|
|
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/get_session_value"
|
2011-10-21 14:13:29 -04:00
|
|
|
assert_response :success
|
2016-12-24 12:29:52 -05:00
|
|
|
assert_nil headers["Set-Cookie"], "should not resend the cookie again if session_id cookie is already exists"
|
2011-10-21 14:13:29 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_prevents_session_fixation
|
|
|
|
with_test_route_set do
|
2019-12-17 16:44:59 -05:00
|
|
|
sid = Rack::Session::SessionId.new("0xhax")
|
|
|
|
assert_nil @cache.read("_session_id:#{sid.private_id}")
|
2011-10-21 14:13:29 -04:00
|
|
|
|
2019-12-17 16:44:59 -05:00
|
|
|
cookies["_session_id"] = sid.public_id
|
2016-08-06 12:54:50 -04:00
|
|
|
get "/set_session_value"
|
2011-10-21 14:13:29 -04:00
|
|
|
|
|
|
|
assert_response :success
|
2019-12-17 16:44:59 -05:00
|
|
|
assert_not_equal sid.public_id, cookies["_session_id"]
|
|
|
|
assert_nil @cache.read("_session_id:#{sid.private_id}")
|
|
|
|
assert_equal(
|
|
|
|
{ "foo" => "bar" },
|
|
|
|
@cache.read("_session_id:#{Rack::Session::SessionId.new(cookies['_session_id']).private_id}")
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_can_read_session_with_legacy_id
|
|
|
|
with_test_route_set do
|
|
|
|
get "/set_session_value"
|
|
|
|
assert_response :success
|
|
|
|
assert cookies["_session_id"]
|
|
|
|
|
2019-12-18 15:07:44 -05:00
|
|
|
sid = Rack::Session::SessionId.new(cookies["_session_id"])
|
2019-12-17 16:44:59 -05:00
|
|
|
session = @cache.read("_session_id:#{sid.private_id}")
|
|
|
|
@cache.delete("_session_id:#{sid.private_id}")
|
|
|
|
@cache.write("_session_id:#{sid.public_id}", session)
|
|
|
|
|
|
|
|
get "/get_session_value"
|
|
|
|
assert_response :success
|
|
|
|
assert_equal 'foo: "bar"', response.body
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_drop_session_in_the_legacy_id_as_well
|
|
|
|
with_test_route_set do
|
|
|
|
get "/set_session_value"
|
|
|
|
assert_response :success
|
|
|
|
assert cookies["_session_id"]
|
|
|
|
|
2019-12-18 15:07:44 -05:00
|
|
|
sid = Rack::Session::SessionId.new(cookies["_session_id"])
|
2019-12-17 16:44:59 -05:00
|
|
|
session = @cache.read("_session_id:#{sid.private_id}")
|
|
|
|
@cache.delete("_session_id:#{sid.private_id}")
|
|
|
|
@cache.write("_session_id:#{sid.public_id}", session)
|
|
|
|
|
|
|
|
get "/call_reset_session"
|
|
|
|
assert_response :success
|
|
|
|
assert_not_equal [], headers["Set-Cookie"]
|
|
|
|
|
|
|
|
assert_nil @cache.read("_session_id:#{sid.private_id}")
|
|
|
|
assert_nil @cache.read("_session_id:#{sid.public_id}")
|
2011-10-21 14:13:29 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
private
|
|
|
|
def with_test_route_set
|
|
|
|
with_routing do |set|
|
|
|
|
set.draw do
|
2016-03-01 03:48:53 -05:00
|
|
|
ActiveSupport::Deprecation.silence do
|
2016-08-06 13:35:13 -04:00
|
|
|
get ":action", to: ::CacheStoreTest::TestController
|
2016-03-01 03:48:53 -05:00
|
|
|
end
|
2011-10-21 14:13:29 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
@app = self.class.build_app(set) do |middleware|
|
2014-07-09 20:49:37 -04:00
|
|
|
@cache = ActiveSupport::Cache::MemoryStore.new
|
2016-08-06 13:35:13 -04:00
|
|
|
middleware.use ActionDispatch::Session::CacheStore, key: "_session_id", cache: @cache
|
2015-08-07 18:35:39 -04:00
|
|
|
middleware.delete ActionDispatch::ShowExceptions
|
2011-10-21 14:13:29 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
yield
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|