2017-07-23 11:36:41 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-08-06 12:50:17 -04:00
|
|
|
require "abstract_unit"
|
|
|
|
require "action_view/dependency_tracker"
|
2012-12-16 17:38:46 -05:00
|
|
|
|
2013-06-04 15:39:50 -04:00
|
|
|
class NeckbeardTracker
|
|
|
|
def self.call(name, template)
|
|
|
|
["foo/#{name}"]
|
2012-12-16 17:38:46 -05:00
|
|
|
end
|
2013-06-04 15:39:50 -04:00
|
|
|
end
|
2012-12-16 17:38:46 -05:00
|
|
|
|
2013-06-04 15:39:50 -04:00
|
|
|
class FakeTemplate
|
|
|
|
attr_reader :source, :handler
|
2012-12-16 17:38:46 -05:00
|
|
|
|
2013-06-04 15:39:50 -04:00
|
|
|
def initialize(source, handler = Neckbeard)
|
|
|
|
@source, @handler = source, handler
|
2012-12-16 17:38:46 -05:00
|
|
|
end
|
2013-06-04 15:39:50 -04:00
|
|
|
end
|
|
|
|
|
2019-02-01 19:10:02 -05:00
|
|
|
Neckbeard = lambda { |template, source| source }
|
|
|
|
Bowtie = lambda { |template, source| source }
|
2012-12-16 17:38:46 -05:00
|
|
|
|
2013-06-04 15:39:50 -04:00
|
|
|
class DependencyTrackerTest < ActionView::TestCase
|
2012-12-16 17:38:46 -05:00
|
|
|
def tracker
|
|
|
|
ActionView::DependencyTracker
|
|
|
|
end
|
|
|
|
|
|
|
|
def setup
|
2013-02-20 10:42:30 -05:00
|
|
|
ActionView::Template.register_template_handler :neckbeard, Neckbeard
|
|
|
|
tracker.register_tracker(:neckbeard, NeckbeardTracker)
|
2012-12-16 17:38:46 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
def teardown
|
2014-06-09 10:45:46 -04:00
|
|
|
ActionView::Template.unregister_template_handler :neckbeard
|
2013-02-20 10:42:30 -05:00
|
|
|
tracker.remove_tracker(:neckbeard)
|
2012-12-16 17:38:46 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
def test_finds_tracker_by_template_handler
|
|
|
|
template = FakeTemplate.new("boo/hoo")
|
|
|
|
dependencies = tracker.find_dependencies("boo/hoo", template)
|
|
|
|
assert_equal ["foo/boo/hoo"], dependencies
|
|
|
|
end
|
2012-12-17 15:26:55 -05:00
|
|
|
|
|
|
|
def test_returns_empty_array_if_no_tracker_is_found
|
|
|
|
template = FakeTemplate.new("boo/hoo", Bowtie)
|
|
|
|
dependencies = tracker.find_dependencies("boo/hoo", template)
|
|
|
|
assert_equal [], dependencies
|
|
|
|
end
|
2012-12-16 17:38:46 -05:00
|
|
|
end
|
2013-06-04 15:39:50 -04:00
|
|
|
|
2013-06-12 07:20:43 -04:00
|
|
|
class ERBTrackerTest < Minitest::Test
|
2013-06-04 15:39:50 -04:00
|
|
|
def make_tracker(name, template)
|
|
|
|
ActionView::DependencyTracker::ERBTracker.new(name, template)
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_dependency_of_erb_template_with_number_in_filename
|
|
|
|
template = FakeTemplate.new("<%# render 'messages/message123' %>", :erb)
|
2013-12-15 21:51:35 -05:00
|
|
|
tracker = make_tracker("messages/_message123", template)
|
2013-06-04 15:39:50 -04:00
|
|
|
|
|
|
|
assert_equal ["messages/message123"], tracker.dependencies
|
|
|
|
end
|
|
|
|
|
2014-07-25 19:35:16 -04:00
|
|
|
def test_dependency_of_template_partial_with_layout
|
|
|
|
template = FakeTemplate.new("<%# render partial: 'messages/show', layout: 'messages/layout' %>", :erb)
|
|
|
|
tracker = make_tracker("multiple/_dependencies", template)
|
|
|
|
|
|
|
|
assert_equal ["messages/layout", "messages/show"], tracker.dependencies
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_dependency_of_template_layout_standalone
|
|
|
|
template = FakeTemplate.new("<%# render layout: 'messages/layout' do %>", :erb)
|
|
|
|
tracker = make_tracker("messages/layout", template)
|
|
|
|
|
|
|
|
assert_equal ["messages/layout"], tracker.dependencies
|
|
|
|
end
|
|
|
|
|
2013-06-04 15:39:50 -04:00
|
|
|
def test_finds_dependency_in_correct_directory
|
|
|
|
template = FakeTemplate.new("<%# render(message.topic) %>", :erb)
|
2013-12-15 21:51:35 -05:00
|
|
|
tracker = make_tracker("messages/_message", template)
|
2013-06-04 15:39:50 -04:00
|
|
|
|
|
|
|
assert_equal ["topics/topic"], tracker.dependencies
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_finds_dependency_in_correct_directory_with_underscore
|
|
|
|
template = FakeTemplate.new("<%# render(message_type.messages) %>", :erb)
|
2013-12-15 21:51:35 -05:00
|
|
|
tracker = make_tracker("message_types/_message_type", template)
|
2013-06-04 15:39:50 -04:00
|
|
|
|
|
|
|
assert_equal ["messages/message"], tracker.dependencies
|
|
|
|
end
|
|
|
|
|
2013-12-15 21:51:35 -05:00
|
|
|
def test_dependency_of_erb_template_with_no_spaces_after_render
|
|
|
|
template = FakeTemplate.new("<%# render'messages/message' %>", :erb)
|
|
|
|
tracker = make_tracker("messages/_message", template)
|
|
|
|
|
|
|
|
assert_equal ["messages/message"], tracker.dependencies
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_finds_no_dependency_when_render_begins_the_name_of_an_identifier
|
|
|
|
template = FakeTemplate.new("<%# rendering 'it useless' %>", :erb)
|
|
|
|
tracker = make_tracker("resources/_resource", template)
|
|
|
|
|
|
|
|
assert_equal [], tracker.dependencies
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_finds_no_dependency_when_render_ends_the_name_of_another_method
|
|
|
|
template = FakeTemplate.new("<%# surrender 'to reason' %>", :erb)
|
|
|
|
tracker = make_tracker("resources/_resource", template)
|
|
|
|
|
|
|
|
assert_equal [], tracker.dependencies
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_finds_dependency_on_multiline_render_calls
|
|
|
|
template = FakeTemplate.new("<%#
|
|
|
|
render :object => @all_posts,
|
|
|
|
:partial => 'posts' %>", :erb)
|
|
|
|
|
|
|
|
tracker = make_tracker("some/_little_posts", template)
|
|
|
|
|
|
|
|
assert_equal ["some/posts"], tracker.dependencies
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_finds_multiple_unrelated_odd_dependencies
|
|
|
|
template = FakeTemplate.new("
|
|
|
|
<%# render('shared/header', title: 'Title') %>
|
|
|
|
<h2>Section title</h2>
|
|
|
|
<%# render@section %>
|
|
|
|
", :erb)
|
|
|
|
|
|
|
|
tracker = make_tracker("multiple/_dependencies", template)
|
|
|
|
|
|
|
|
assert_equal ["shared/header", "sections/section"], tracker.dependencies
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_finds_dependencies_for_all_kinds_of_identifiers
|
|
|
|
template = FakeTemplate.new("
|
|
|
|
<%# render $globals %>
|
|
|
|
<%# render @instance_variables %>
|
|
|
|
<%# render @@class_variables %>
|
|
|
|
", :erb)
|
|
|
|
|
|
|
|
tracker = make_tracker("identifiers/_all", template)
|
|
|
|
|
|
|
|
assert_equal [
|
|
|
|
"globals/global",
|
|
|
|
"instance_variables/instance_variable",
|
|
|
|
"class_variables/class_variable"
|
|
|
|
], tracker.dependencies
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_finds_dependencies_on_method_chains
|
|
|
|
template = FakeTemplate.new("<%# render @parent.child.grandchildren %>", :erb)
|
|
|
|
tracker = make_tracker("method/_chains", template)
|
|
|
|
|
|
|
|
assert_equal ["grandchildren/grandchild"], tracker.dependencies
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_finds_dependencies_with_special_characters
|
|
|
|
template = FakeTemplate.new("<%# render @pokémon, partial: 'ピカチュウ' %>", :erb)
|
|
|
|
tracker = make_tracker("special/_characters", template)
|
|
|
|
|
|
|
|
assert_equal ["special/ピカチュウ"], tracker.dependencies
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_finds_dependencies_with_quotes_within
|
2013-12-21 19:14:07 -05:00
|
|
|
template = FakeTemplate.new(%{
|
|
|
|
<%# render "single/quote's" %>
|
|
|
|
<%# render 'double/quote"s' %>
|
|
|
|
}, :erb)
|
|
|
|
|
2013-12-15 21:51:35 -05:00
|
|
|
tracker = make_tracker("quotes/_single_and_double", template)
|
|
|
|
|
|
|
|
assert_equal ["single/quote's", 'double/quote"s'], tracker.dependencies
|
|
|
|
end
|
2013-12-21 19:14:07 -05:00
|
|
|
|
|
|
|
def test_finds_dependencies_with_extra_spaces
|
|
|
|
template = FakeTemplate.new(%{
|
|
|
|
<%= render "header" %>
|
|
|
|
<%= render partial: "form" %>
|
|
|
|
<%= render @message %>
|
|
|
|
<%= render ( @message.events ) %>
|
|
|
|
<%= render :collection => @message.comments,
|
|
|
|
:partial => "comments/comment" %>
|
|
|
|
}, :erb)
|
|
|
|
|
|
|
|
tracker = make_tracker("spaces/_extra", template)
|
|
|
|
|
|
|
|
assert_equal [
|
|
|
|
"spaces/header",
|
|
|
|
"spaces/form",
|
|
|
|
"messages/message",
|
|
|
|
"events/event",
|
|
|
|
"comments/comment"
|
|
|
|
], tracker.dependencies
|
|
|
|
end
|
2013-12-15 21:51:35 -05:00
|
|
|
end
|