2017-08-14 13:08:09 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-08-06 13:15:47 -04:00
|
|
|
require "active_support/ordered_options"
|
|
|
|
require "active_support/core_ext/object"
|
2017-10-21 09:08:33 -04:00
|
|
|
require "rails/paths"
|
|
|
|
require "rails/rack"
|
2009-10-08 21:12:28 -04:00
|
|
|
|
2009-06-23 19:10:43 -04:00
|
|
|
module Rails
|
2010-01-23 16:30:17 -05:00
|
|
|
module Configuration
|
2012-03-06 06:26:09 -05:00
|
|
|
# MiddlewareStackProxy is a proxy for the Rails middleware stack that allows
|
|
|
|
# you to configure middlewares in your application. It works basically as a
|
|
|
|
# command recorder, saving each command to be applied after initialization
|
|
|
|
# over the default middleware stack, so you can add, swap, or remove any
|
|
|
|
# middleware in Rails.
|
|
|
|
#
|
|
|
|
# You can add your own middlewares by using the +config.middleware.use+ method:
|
|
|
|
#
|
|
|
|
# config.middleware.use Magical::Unicorns
|
|
|
|
#
|
2012-04-27 03:00:30 -04:00
|
|
|
# This will put the <tt>Magical::Unicorns</tt> middleware on the end of the stack.
|
2012-03-06 06:26:09 -05:00
|
|
|
# You can use +insert_before+ if you wish to add a middleware before another:
|
|
|
|
#
|
2014-11-24 05:48:51 -05:00
|
|
|
# config.middleware.insert_before Rack::Head, Magical::Unicorns
|
2012-03-06 06:26:09 -05:00
|
|
|
#
|
|
|
|
# There's also +insert_after+ which will insert a middleware after another:
|
|
|
|
#
|
2014-11-24 05:48:51 -05:00
|
|
|
# config.middleware.insert_after Rack::Head, Magical::Unicorns
|
2012-03-06 06:26:09 -05:00
|
|
|
#
|
|
|
|
# Middlewares can also be completely swapped out and replaced with others:
|
|
|
|
#
|
2013-01-28 12:14:28 -05:00
|
|
|
# config.middleware.swap ActionDispatch::Flash, Magical::Unicorns
|
2012-03-06 06:26:09 -05:00
|
|
|
#
|
Delayed middleware delete does not allow move operations
While trying to fix #16433, we made the middleware deletions always
happen at the end. While this works for the case of deleting the
Rack::Runtime middleware, it makes operations like the following
misbehave.
```ruby
gem "bundler", "< 1.16"
begin
require "bundler/inline"
rescue LoadError => e
$stderr.puts "Bundler version 1.10 or later is required. Please update your Bundler"
raise e
end
gemfile(true) do
source "https://rubygems.org"
git_source(:github) { |repo| "https://github.com/#{repo}.git" }
gem "rails", github: "rails/rails"
end
require "action_controller/railtie"
class TestApp < Rails::Application
config.root = __dir__
secrets.secret_key_base = "secret_key_base"
config.logger = Logger.new($stdout)
Rails.logger = config.logger
middleware.insert_after ActionDispatch::Session::CookieStore, ::Rails::Rack::Logger, config.log_tags
middleware.delete ::Rails::Rack::Logger
end
require "minitest/autorun"
require "rack/test"
class BugTest < Minitest::Test
include Rack::Test::Methods
def test_returns_success
get "/"
assert last_response.ok?
end
private
def app
Rails.application
end
end
```
In the case ☝️ the ::Rails::Rack::Logger would be deleted instead of
moved, because the order of middleware stack building execution will be:
```ruby
[:insert, ActionDispatch::Session::CookieStore, [::Rails::Rack::Logger]]
[:delete, ::Rails::Rack::Logger, [config.log_tags]]
```
This is pretty surprising and hard to reason about behaviour, unless you
go spelunking into the Rails configuration code.
I have a few solutions in mind and all of them have their drawbacks.
1. Introduce a `Rails::Configuration::MiddlewareStackProxy#delete!` that
delays the deleted operations. This will make `#delete` to be executed
in order. The drawback here is backwards incompatible behavior and a new
public method.
2. Just revert to the old operations. This won't allow people to delete
the `Rack::Runtime` middleware.
3. Legitimize the middleware moving with the new `#move_after` and
`#move_before` methods. This does not breaks any backwards
compatibility, but includes 2 new methods to the middleware stack.
I have implemented `3.` in this pull request.
Happy holidays! 🎄
2020-01-07 13:20:03 -05:00
|
|
|
# Middlewares can be moved from one place to another:
|
|
|
|
#
|
|
|
|
# config.middleware.move_before ActionDispatch::Flash, Magical::Unicorns
|
|
|
|
#
|
|
|
|
# This will move the <tt>Magical::Unicorns</tt> middleware before the
|
|
|
|
# <tt>ActionDispatch::Flash</tt>. You can also move it after:
|
|
|
|
#
|
|
|
|
# config.middleware.move_after ActionDispatch::Flash, Magical::Unicorns
|
|
|
|
#
|
2012-03-06 06:26:09 -05:00
|
|
|
# And finally they can also be removed from the stack completely:
|
|
|
|
#
|
2013-01-28 12:14:28 -05:00
|
|
|
# config.middleware.delete ActionDispatch::Flash
|
2012-03-06 06:26:09 -05:00
|
|
|
#
|
|
|
|
class MiddlewareStackProxy
|
2015-09-29 16:35:13 -04:00
|
|
|
def initialize(operations = [], delete_operations = [])
|
|
|
|
@operations = operations
|
|
|
|
@delete_operations = delete_operations
|
2010-05-16 06:03:11 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def insert_before(*args, &block)
|
2019-12-25 03:08:31 -05:00
|
|
|
@operations << -> middleware { middleware.send(__method__, *args, &block) }
|
2010-05-16 06:03:11 -04:00
|
|
|
end
|
2019-12-25 03:08:31 -05:00
|
|
|
ruby2_keywords(:insert_before) if respond_to?(:ruby2_keywords, true)
|
2010-05-16 06:03:11 -04:00
|
|
|
|
|
|
|
alias :insert :insert_before
|
|
|
|
|
|
|
|
def insert_after(*args, &block)
|
2019-12-25 03:08:31 -05:00
|
|
|
@operations << -> middleware { middleware.send(__method__, *args, &block) }
|
2010-05-16 06:03:11 -04:00
|
|
|
end
|
2019-12-25 03:08:31 -05:00
|
|
|
ruby2_keywords(:insert_after) if respond_to?(:ruby2_keywords, true)
|
2010-05-16 06:03:11 -04:00
|
|
|
|
|
|
|
def swap(*args, &block)
|
2019-12-25 03:08:31 -05:00
|
|
|
@operations << -> middleware { middleware.send(__method__, *args, &block) }
|
2010-05-16 06:03:11 -04:00
|
|
|
end
|
2019-12-25 03:08:31 -05:00
|
|
|
ruby2_keywords(:swap) if respond_to?(:ruby2_keywords, true)
|
2010-05-16 06:03:11 -04:00
|
|
|
|
|
|
|
def use(*args, &block)
|
2019-12-25 03:08:31 -05:00
|
|
|
@operations << -> middleware { middleware.send(__method__, *args, &block) }
|
2010-05-16 06:03:11 -04:00
|
|
|
end
|
2019-12-25 03:08:31 -05:00
|
|
|
ruby2_keywords(:use) if respond_to?(:ruby2_keywords, true)
|
2010-05-16 06:03:11 -04:00
|
|
|
|
2010-06-07 17:17:23 -04:00
|
|
|
def delete(*args, &block)
|
2019-12-25 03:08:31 -05:00
|
|
|
@delete_operations << -> middleware { middleware.send(__method__, *args, &block) }
|
2010-06-07 17:17:23 -04:00
|
|
|
end
|
|
|
|
|
Delayed middleware delete does not allow move operations
While trying to fix #16433, we made the middleware deletions always
happen at the end. While this works for the case of deleting the
Rack::Runtime middleware, it makes operations like the following
misbehave.
```ruby
gem "bundler", "< 1.16"
begin
require "bundler/inline"
rescue LoadError => e
$stderr.puts "Bundler version 1.10 or later is required. Please update your Bundler"
raise e
end
gemfile(true) do
source "https://rubygems.org"
git_source(:github) { |repo| "https://github.com/#{repo}.git" }
gem "rails", github: "rails/rails"
end
require "action_controller/railtie"
class TestApp < Rails::Application
config.root = __dir__
secrets.secret_key_base = "secret_key_base"
config.logger = Logger.new($stdout)
Rails.logger = config.logger
middleware.insert_after ActionDispatch::Session::CookieStore, ::Rails::Rack::Logger, config.log_tags
middleware.delete ::Rails::Rack::Logger
end
require "minitest/autorun"
require "rack/test"
class BugTest < Minitest::Test
include Rack::Test::Methods
def test_returns_success
get "/"
assert last_response.ok?
end
private
def app
Rails.application
end
end
```
In the case ☝️ the ::Rails::Rack::Logger would be deleted instead of
moved, because the order of middleware stack building execution will be:
```ruby
[:insert, ActionDispatch::Session::CookieStore, [::Rails::Rack::Logger]]
[:delete, ::Rails::Rack::Logger, [config.log_tags]]
```
This is pretty surprising and hard to reason about behaviour, unless you
go spelunking into the Rails configuration code.
I have a few solutions in mind and all of them have their drawbacks.
1. Introduce a `Rails::Configuration::MiddlewareStackProxy#delete!` that
delays the deleted operations. This will make `#delete` to be executed
in order. The drawback here is backwards incompatible behavior and a new
public method.
2. Just revert to the old operations. This won't allow people to delete
the `Rack::Runtime` middleware.
3. Legitimize the middleware moving with the new `#move_after` and
`#move_before` methods. This does not breaks any backwards
compatibility, but includes 2 new methods to the middleware stack.
I have implemented `3.` in this pull request.
Happy holidays! 🎄
2020-01-07 13:20:03 -05:00
|
|
|
def move_before(*args, &block)
|
|
|
|
@delete_operations << -> middleware { middleware.send(__method__, *args, &block) }
|
|
|
|
end
|
|
|
|
|
|
|
|
alias :move :move_before
|
|
|
|
|
|
|
|
def move_after(*args, &block)
|
|
|
|
@delete_operations << -> middleware { middleware.send(__method__, *args, &block) }
|
|
|
|
end
|
|
|
|
|
2013-10-09 06:16:22 -04:00
|
|
|
def unshift(*args, &block)
|
2019-12-25 03:08:31 -05:00
|
|
|
@operations << -> middleware { middleware.send(__method__, *args, &block) }
|
2013-10-09 06:16:22 -04:00
|
|
|
end
|
2019-12-25 03:08:31 -05:00
|
|
|
ruby2_keywords(:unshift) if respond_to?(:ruby2_keywords, true)
|
2013-10-09 06:16:22 -04:00
|
|
|
|
2012-03-06 06:26:09 -05:00
|
|
|
def merge_into(other) #:nodoc:
|
2019-12-25 03:08:31 -05:00
|
|
|
(@operations + @delete_operations).each do |operation|
|
|
|
|
operation.call(other)
|
2010-05-16 06:03:11 -04:00
|
|
|
end
|
2015-02-18 13:35:51 -05:00
|
|
|
|
2010-05-16 06:03:11 -04:00
|
|
|
other
|
|
|
|
end
|
2015-09-29 16:35:13 -04:00
|
|
|
|
|
|
|
def +(other) # :nodoc:
|
|
|
|
MiddlewareStackProxy.new(@operations + other.operations, @delete_operations + other.delete_operations)
|
|
|
|
end
|
|
|
|
|
|
|
|
protected
|
2018-03-29 22:29:55 -04:00
|
|
|
attr_reader :operations, :delete_operations
|
2010-05-16 06:03:11 -04:00
|
|
|
end
|
|
|
|
|
2010-01-23 16:30:17 -05:00
|
|
|
class Generators #:nodoc:
|
2015-04-17 19:33:43 -04:00
|
|
|
attr_accessor :aliases, :options, :templates, :fallbacks, :colorize_logging, :api_only
|
2019-06-19 04:22:46 -04:00
|
|
|
attr_reader :hidden_namespaces, :after_generate_callbacks
|
2010-01-22 19:29:29 -05:00
|
|
|
|
|
|
|
def initialize
|
2016-10-28 23:05:58 -04:00
|
|
|
@aliases = Hash.new { |h, k| h[k] = {} }
|
|
|
|
@options = Hash.new { |h, k| h[k] = {} }
|
2010-02-01 04:48:59 -05:00
|
|
|
@fallbacks = {}
|
2010-02-06 11:32:06 -05:00
|
|
|
@templates = []
|
2010-01-22 19:29:29 -05:00
|
|
|
@colorize_logging = true
|
2015-04-17 19:33:43 -04:00
|
|
|
@api_only = false
|
2011-05-24 19:03:15 -04:00
|
|
|
@hidden_namespaces = []
|
2019-06-19 04:22:46 -04:00
|
|
|
@after_generate_callbacks = []
|
2010-01-22 19:29:29 -05:00
|
|
|
end
|
|
|
|
|
2010-10-28 14:25:20 -04:00
|
|
|
def initialize_copy(source)
|
|
|
|
@aliases = @aliases.deep_dup
|
|
|
|
@options = @options.deep_dup
|
|
|
|
@fallbacks = @fallbacks.deep_dup
|
|
|
|
@templates = @templates.dup
|
|
|
|
end
|
|
|
|
|
2011-05-24 19:03:15 -04:00
|
|
|
def hide_namespace(namespace)
|
|
|
|
@hidden_namespaces << namespace
|
|
|
|
end
|
|
|
|
|
2019-06-19 04:22:46 -04:00
|
|
|
def after_generate(&block)
|
|
|
|
@after_generate_callbacks << block
|
|
|
|
end
|
|
|
|
|
2010-01-22 19:29:29 -05:00
|
|
|
def method_missing(method, *args)
|
2016-08-06 13:15:47 -04:00
|
|
|
method = method.to_s.sub(/=$/, "").to_sym
|
2010-01-22 19:29:29 -05:00
|
|
|
|
2017-03-16 01:21:37 -04:00
|
|
|
if args.empty?
|
|
|
|
if method == :rails
|
|
|
|
return @options[method]
|
|
|
|
else
|
|
|
|
return @options[:rails][method]
|
|
|
|
end
|
|
|
|
end
|
2010-01-28 13:03:47 -05:00
|
|
|
|
2010-07-21 10:02:13 -04:00
|
|
|
if method == :rails || args.first.is_a?(Hash)
|
2010-01-22 19:29:29 -05:00
|
|
|
namespace, configuration = method, args.shift
|
|
|
|
else
|
|
|
|
namespace, configuration = args.shift, args.shift
|
2010-07-21 10:37:03 -04:00
|
|
|
namespace = namespace.to_sym if namespace.respond_to?(:to_sym)
|
2010-01-22 19:29:29 -05:00
|
|
|
@options[:rails][method] = namespace
|
|
|
|
end
|
|
|
|
|
|
|
|
if configuration
|
|
|
|
aliases = configuration.delete(:aliases)
|
|
|
|
@aliases[namespace].merge!(aliases) if aliases
|
|
|
|
@options[namespace].merge!(configuration)
|
|
|
|
end
|
|
|
|
end
|
2010-01-21 17:14:20 -05:00
|
|
|
end
|
2009-06-23 19:10:43 -04:00
|
|
|
end
|
2009-07-08 04:57:56 -04:00
|
|
|
end
|