2011-04-28 04:56:11 -04:00
|
|
|
require 'abstract_unit'
|
|
|
|
|
|
|
|
module Admin; class User; end; end
|
|
|
|
|
2011-05-17 06:55:03 -04:00
|
|
|
module ParamsWrapperTestHelp
|
|
|
|
def with_default_wrapper_options(&block)
|
2012-11-13 14:38:36 -05:00
|
|
|
@controller.class._set_wrapper_options({:format => [:json]})
|
2011-05-17 06:55:03 -04:00
|
|
|
@controller.class.inherited(@controller.class)
|
|
|
|
yield
|
|
|
|
end
|
|
|
|
|
|
|
|
def assert_parameters(expected)
|
|
|
|
assert_equal expected, self.class.controller_class.last_parameters
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2011-04-28 04:56:11 -04:00
|
|
|
class ParamsWrapperTest < ActionController::TestCase
|
2011-05-17 06:55:03 -04:00
|
|
|
include ParamsWrapperTestHelp
|
|
|
|
|
2011-04-28 04:56:11 -04:00
|
|
|
class UsersController < ActionController::Base
|
2011-05-03 05:51:19 -04:00
|
|
|
class << self
|
|
|
|
attr_accessor :last_parameters
|
|
|
|
end
|
|
|
|
|
|
|
|
def parse
|
|
|
|
self.class.last_parameters = request.params.except(:controller, :action)
|
|
|
|
head :ok
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
2011-12-08 09:09:09 -05:00
|
|
|
end
|
2011-04-28 04:56:11 -04:00
|
|
|
|
|
|
|
class User; end
|
|
|
|
class Person; end
|
|
|
|
|
|
|
|
tests UsersController
|
|
|
|
|
2011-05-03 05:51:19 -04:00
|
|
|
def teardown
|
|
|
|
UsersController.last_parameters = nil
|
|
|
|
end
|
|
|
|
|
2012-04-29 11:16:32 -04:00
|
|
|
def test_filtered_parameters
|
|
|
|
with_default_wrapper_options do
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
|
|
|
post :parse, { 'username' => 'sikachu' }
|
|
|
|
assert_equal @request.filtered_parameters, { 'controller' => 'params_wrapper_test/users', 'action' => 'parse', 'username' => 'sikachu', 'user' => { 'username' => 'sikachu' } }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2011-05-03 14:05:01 -04:00
|
|
|
def test_derived_name_from_controller
|
2011-04-28 04:56:11 -04:00
|
|
|
with_default_wrapper_options do
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'username' => 'sikachu' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'user' => { 'username' => 'sikachu' }})
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_specify_wrapper_name
|
|
|
|
with_default_wrapper_options do
|
|
|
|
UsersController.wrap_parameters :person
|
|
|
|
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'username' => 'sikachu' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'person' => { 'username' => 'sikachu' }})
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_specify_wrapper_model
|
|
|
|
with_default_wrapper_options do
|
|
|
|
UsersController.wrap_parameters Person
|
|
|
|
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'username' => 'sikachu' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'person' => { 'username' => 'sikachu' }})
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2011-05-19 10:33:25 -04:00
|
|
|
def test_specify_include_option
|
2011-04-28 04:56:11 -04:00
|
|
|
with_default_wrapper_options do
|
2011-05-19 10:33:25 -04:00
|
|
|
UsersController.wrap_parameters :include => :username
|
2011-04-28 04:56:11 -04:00
|
|
|
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'username' => 'sikachu', 'title' => 'Developer' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'title' => 'Developer', 'user' => { 'username' => 'sikachu' }})
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2011-05-19 10:33:25 -04:00
|
|
|
def test_specify_exclude_option
|
2011-04-28 04:56:11 -04:00
|
|
|
with_default_wrapper_options do
|
2011-05-19 10:33:25 -04:00
|
|
|
UsersController.wrap_parameters :exclude => :title
|
2011-04-28 04:56:11 -04:00
|
|
|
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'username' => 'sikachu', 'title' => 'Developer' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'title' => 'Developer', 'user' => { 'username' => 'sikachu' }})
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2011-05-19 10:33:25 -04:00
|
|
|
def test_specify_both_wrapper_name_and_include_option
|
2011-04-28 04:56:11 -04:00
|
|
|
with_default_wrapper_options do
|
2011-05-19 10:33:25 -04:00
|
|
|
UsersController.wrap_parameters :person, :include => :username
|
2011-04-28 04:56:11 -04:00
|
|
|
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'username' => 'sikachu', 'title' => 'Developer' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'title' => 'Developer', 'person' => { 'username' => 'sikachu' }})
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_not_enabled_format
|
|
|
|
with_default_wrapper_options do
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/xml'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'username' => 'sikachu', 'title' => 'Developer' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'title' => 'Developer' })
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2011-05-02 18:37:40 -04:00
|
|
|
def test_wrap_parameters_false
|
|
|
|
with_default_wrapper_options do
|
|
|
|
UsersController.wrap_parameters false
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'username' => 'sikachu', 'title' => 'Developer' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'title' => 'Developer' })
|
2011-05-02 18:37:40 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2011-04-28 04:56:11 -04:00
|
|
|
def test_specify_format
|
|
|
|
with_default_wrapper_options do
|
|
|
|
UsersController.wrap_parameters :format => :xml
|
|
|
|
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/xml'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'username' => 'sikachu', 'title' => 'Developer' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'title' => 'Developer', 'user' => { 'username' => 'sikachu', 'title' => 'Developer' }})
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_not_wrap_reserved_parameters
|
|
|
|
with_default_wrapper_options do
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'authenticity_token' => 'pwned', '_method' => 'put', 'utf8' => '☃', 'username' => 'sikachu' }
|
|
|
|
assert_parameters({ 'authenticity_token' => 'pwned', '_method' => 'put', 'utf8' => '☃', 'username' => 'sikachu', 'user' => { 'username' => 'sikachu' }})
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_no_double_wrap_if_key_exists
|
|
|
|
with_default_wrapper_options do
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'user' => { 'username' => 'sikachu' }}
|
|
|
|
assert_parameters({ 'user' => { 'username' => 'sikachu' }})
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_nested_params
|
|
|
|
with_default_wrapper_options do
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'person' => { 'username' => 'sikachu' }}
|
|
|
|
assert_parameters({ 'person' => { 'username' => 'sikachu' }, 'user' => {'person' => { 'username' => 'sikachu' }}})
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_derived_wrapped_keys_from_matching_model
|
2011-05-15 14:25:00 -04:00
|
|
|
User.expects(:respond_to?).with(:attribute_names).returns(true)
|
|
|
|
User.expects(:attribute_names).twice.returns(["username"])
|
2011-04-28 04:56:11 -04:00
|
|
|
|
2011-05-02 18:37:40 -04:00
|
|
|
with_default_wrapper_options do
|
2011-04-28 04:56:11 -04:00
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'username' => 'sikachu', 'title' => 'Developer' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'title' => 'Developer', 'user' => { 'username' => 'sikachu' }})
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_derived_wrapped_keys_from_specified_model
|
|
|
|
with_default_wrapper_options do
|
2011-05-15 14:25:00 -04:00
|
|
|
Person.expects(:respond_to?).with(:attribute_names).returns(true)
|
|
|
|
Person.expects(:attribute_names).twice.returns(["username"])
|
2011-04-28 04:56:11 -04:00
|
|
|
|
|
|
|
UsersController.wrap_parameters Person
|
|
|
|
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'username' => 'sikachu', 'title' => 'Developer' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'title' => 'Developer', 'person' => { 'username' => 'sikachu' }})
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2011-05-15 00:41:20 -04:00
|
|
|
def test_not_wrapping_abstract_model
|
2011-05-15 14:25:00 -04:00
|
|
|
User.expects(:respond_to?).with(:attribute_names).returns(true)
|
|
|
|
User.expects(:attribute_names).returns([])
|
2011-05-15 00:41:20 -04:00
|
|
|
|
|
|
|
with_default_wrapper_options do
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
|
|
|
post :parse, { 'username' => 'sikachu', 'title' => 'Developer' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'title' => 'Developer', 'user' => { 'username' => 'sikachu', 'title' => 'Developer' }})
|
|
|
|
end
|
|
|
|
end
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
class NamespacedParamsWrapperTest < ActionController::TestCase
|
2011-05-17 06:55:03 -04:00
|
|
|
include ParamsWrapperTestHelp
|
|
|
|
|
2011-04-28 04:56:11 -04:00
|
|
|
module Admin
|
2011-05-10 18:08:18 -04:00
|
|
|
module Users
|
|
|
|
class UsersController < ActionController::Base;
|
|
|
|
class << self
|
|
|
|
attr_accessor :last_parameters
|
|
|
|
end
|
|
|
|
|
|
|
|
def parse
|
|
|
|
self.class.last_parameters = request.params.except(:controller, :action)
|
|
|
|
head :ok
|
|
|
|
end
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
2011-05-02 18:37:40 -04:00
|
|
|
end
|
2011-04-28 04:56:11 -04:00
|
|
|
|
2011-05-10 18:08:18 -04:00
|
|
|
class SampleOne
|
2011-05-15 14:25:00 -04:00
|
|
|
def self.attribute_names
|
2011-05-02 18:37:40 -04:00
|
|
|
["username"]
|
|
|
|
end
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
|
2011-05-10 18:08:18 -04:00
|
|
|
class SampleTwo
|
2011-05-15 14:25:00 -04:00
|
|
|
def self.attribute_names
|
2011-05-10 18:08:18 -04:00
|
|
|
["title"]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
tests Admin::Users::UsersController
|
2011-04-28 04:56:11 -04:00
|
|
|
|
2011-05-03 05:51:19 -04:00
|
|
|
def teardown
|
2011-05-10 18:08:18 -04:00
|
|
|
Admin::Users::UsersController.last_parameters = nil
|
2011-05-03 05:51:19 -04:00
|
|
|
end
|
|
|
|
|
2011-05-03 14:05:01 -04:00
|
|
|
def test_derived_name_from_controller
|
2011-04-28 04:56:11 -04:00
|
|
|
with_default_wrapper_options do
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'username' => 'sikachu' }
|
|
|
|
assert_parameters({'username' => 'sikachu', 'user' => { 'username' => 'sikachu' }})
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2011-05-02 18:37:40 -04:00
|
|
|
def test_namespace_lookup_from_model
|
2011-05-10 18:08:18 -04:00
|
|
|
Admin.const_set(:User, Class.new(SampleOne))
|
2011-05-02 18:37:40 -04:00
|
|
|
begin
|
|
|
|
with_default_wrapper_options do
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
2011-05-03 05:51:19 -04:00
|
|
|
post :parse, { 'username' => 'sikachu', 'title' => 'Developer' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'title' => 'Developer', 'user' => { 'username' => 'sikachu' }})
|
2011-05-02 18:37:40 -04:00
|
|
|
end
|
|
|
|
ensure
|
|
|
|
Admin.send :remove_const, :User
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2011-05-03 14:05:01 -04:00
|
|
|
def test_hierarchy_namespace_lookup_from_model
|
2011-05-10 18:08:18 -04:00
|
|
|
Object.const_set(:User, Class.new(SampleTwo))
|
2011-05-03 05:51:19 -04:00
|
|
|
begin
|
|
|
|
with_default_wrapper_options do
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
|
|
|
post :parse, { 'username' => 'sikachu', 'title' => 'Developer' }
|
2011-05-10 18:08:18 -04:00
|
|
|
assert_parameters({ 'username' => 'sikachu', 'title' => 'Developer', 'user' => { 'title' => 'Developer' }})
|
2011-05-03 05:51:19 -04:00
|
|
|
end
|
|
|
|
ensure
|
|
|
|
Object.send :remove_const, :User
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2011-05-17 06:55:03 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
class AnonymousControllerParamsWrapperTest < ActionController::TestCase
|
|
|
|
include ParamsWrapperTestHelp
|
|
|
|
|
|
|
|
tests(Class.new(ActionController::Base) do
|
|
|
|
class << self
|
|
|
|
attr_accessor :last_parameters
|
2011-04-28 04:56:11 -04:00
|
|
|
end
|
2011-05-03 05:51:19 -04:00
|
|
|
|
2011-05-17 06:55:03 -04:00
|
|
|
def parse
|
|
|
|
self.class.last_parameters = request.params.except(:controller, :action)
|
|
|
|
head :ok
|
2011-05-03 05:51:19 -04:00
|
|
|
end
|
2011-05-17 06:55:03 -04:00
|
|
|
end)
|
|
|
|
|
|
|
|
def test_does_not_implicitly_wrap_params
|
|
|
|
with_default_wrapper_options do
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
|
|
|
post :parse, { 'username' => 'sikachu' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu' })
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_does_wrap_params_if_name_provided
|
|
|
|
with_default_wrapper_options do
|
|
|
|
@controller.class.wrap_parameters(:name => "guest")
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
|
|
|
post :parse, { 'username' => 'sikachu' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'guest' => { 'username' => 'sikachu' }})
|
|
|
|
end
|
|
|
|
end
|
2011-05-15 00:41:20 -04:00
|
|
|
end
|
2011-12-05 11:05:03 -05:00
|
|
|
|
|
|
|
class IrregularInflectionParamsWrapperTest < ActionController::TestCase
|
|
|
|
include ParamsWrapperTestHelp
|
|
|
|
|
|
|
|
class ParamswrappernewsItem
|
|
|
|
def self.attribute_names
|
|
|
|
['test_attr']
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
class ParamswrappernewsController < ActionController::Base
|
|
|
|
class << self
|
|
|
|
attr_accessor :last_parameters
|
|
|
|
end
|
|
|
|
|
|
|
|
def parse
|
|
|
|
self.class.last_parameters = request.params.except(:controller, :action)
|
|
|
|
head :ok
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
tests ParamswrappernewsController
|
|
|
|
|
|
|
|
def test_uses_model_attribute_names_with_irregular_inflection
|
|
|
|
ActiveSupport::Inflector.inflections do |inflect|
|
|
|
|
inflect.irregular 'paramswrappernews_item', 'paramswrappernews'
|
|
|
|
end
|
|
|
|
|
|
|
|
with_default_wrapper_options do
|
|
|
|
@request.env['CONTENT_TYPE'] = 'application/json'
|
|
|
|
post :parse, { 'username' => 'sikachu', 'test_attr' => 'test_value' }
|
|
|
|
assert_parameters({ 'username' => 'sikachu', 'test_attr' => 'test_value', 'paramswrappernews_item' => { 'test_attr' => 'test_value' }})
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|