2016-06-13 10:29:50 -04:00
|
|
|
AllCops:
|
2018-12-19 15:09:34 -05:00
|
|
|
TargetRubyVersion: 2.5
|
2016-08-06 11:45:37 -04:00
|
|
|
# RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
|
2016-08-07 07:06:51 -04:00
|
|
|
# to ignore them, so only the ones explicitly set in this file are enabled.
|
2016-06-13 10:29:50 -04:00
|
|
|
DisabledByDefault: true
|
2016-08-06 11:45:37 -04:00
|
|
|
Exclude:
|
|
|
|
- '**/templates/**/*'
|
|
|
|
- '**/vendor/**/*'
|
2016-12-24 09:33:02 -05:00
|
|
|
- 'actionpack/lib/action_dispatch/journey/parser.rb'
|
2018-04-19 11:20:33 -04:00
|
|
|
- 'railties/test/fixtures/tmp/**/*'
|
2018-12-24 15:16:22 -05:00
|
|
|
- 'actionmailbox/test/dummy/**/*'
|
2019-01-04 19:43:11 -05:00
|
|
|
- 'actiontext/test/dummy/**/*'
|
2018-10-05 11:44:15 -04:00
|
|
|
- 'node_modules/**/*'
|
2016-06-13 10:29:50 -04:00
|
|
|
|
2018-07-26 04:33:49 -04:00
|
|
|
Performance:
|
|
|
|
Exclude:
|
|
|
|
- '**/test/**/*'
|
|
|
|
|
2018-07-02 23:11:28 -04:00
|
|
|
Rails:
|
|
|
|
Enabled: true
|
|
|
|
|
|
|
|
# Prefer assert_not over assert !
|
|
|
|
Rails/AssertNot:
|
Add custom RuboCop for `assert_not` over `refute`
Since at least cf4afc4 we have preferred `assert_not` methods over
`refute` methods. I have seen plenty of comments in PRs about this,
and we have tried to fix it a few times (5294ad8, e45f176, 8910f12,
41f50be, d4cfd54, 48a183e, and 211adb4), but the `refute` methods
keep sneaking back in.
This custom RuboCop will take care of enforcing this preference, so we
don't have to think about it again. I suspect there are other similar
stylistic preferences that could be solved with some custom RuboCops, so
I will definitely keep my eyes open. `assert_not` over `assert !` might
be a good candidate, for example.
I wasn't totally sure if `ci/custom_cops` was the best place to put
this, but nothing else seemed quite right. At one point I had it set up
as a gem, but I think custom cops like this would have limited value
in another context.
I want to see how code climate handles the new cops before
autocorrecting the existing violations. If things go as expected, I will
push another commit with those corrections.
2018-04-03 20:50:00 -04:00
|
|
|
Include:
|
2018-04-19 16:25:39 -04:00
|
|
|
- '**/test/**/*'
|
Add custom RuboCop for `assert_not` over `refute`
Since at least cf4afc4 we have preferred `assert_not` methods over
`refute` methods. I have seen plenty of comments in PRs about this,
and we have tried to fix it a few times (5294ad8, e45f176, 8910f12,
41f50be, d4cfd54, 48a183e, and 211adb4), but the `refute` methods
keep sneaking back in.
This custom RuboCop will take care of enforcing this preference, so we
don't have to think about it again. I suspect there are other similar
stylistic preferences that could be solved with some custom RuboCops, so
I will definitely keep my eyes open. `assert_not` over `assert !` might
be a good candidate, for example.
I wasn't totally sure if `ci/custom_cops` was the best place to put
this, but nothing else seemed quite right. At one point I had it set up
as a gem, but I think custom cops like this would have limited value
in another context.
I want to see how code climate handles the new cops before
autocorrecting the existing violations. If things go as expected, I will
push another commit with those corrections.
2018-04-03 20:50:00 -04:00
|
|
|
|
2018-07-02 23:11:28 -04:00
|
|
|
# Prefer assert_not_x over refute_x
|
|
|
|
Rails/RefuteMethods:
|
2018-04-17 08:37:35 -04:00
|
|
|
Include:
|
2018-04-19 16:25:39 -04:00
|
|
|
- '**/test/**/*'
|
2018-04-17 08:37:35 -04:00
|
|
|
|
2016-08-06 11:45:37 -04:00
|
|
|
# Prefer &&/|| over and/or.
|
|
|
|
Style/AndOr:
|
2016-07-19 23:35:11 -04:00
|
|
|
Enabled: true
|
2016-06-13 10:29:50 -04:00
|
|
|
|
2016-08-06 11:45:37 -04:00
|
|
|
# Do not use braces for hash literals when they are the last argument of a
|
|
|
|
# method call.
|
|
|
|
Style/BracesAroundHashParameters:
|
2016-07-19 23:35:11 -04:00
|
|
|
Enabled: true
|
2017-08-12 07:31:46 -04:00
|
|
|
EnforcedStyle: context_dependent
|
2016-06-13 10:29:50 -04:00
|
|
|
|
2016-08-06 11:45:37 -04:00
|
|
|
# Align `when` with `case`.
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/CaseIndentation:
|
2016-07-19 23:35:11 -04:00
|
|
|
Enabled: true
|
2016-06-13 10:29:50 -04:00
|
|
|
|
2016-09-14 04:57:52 -04:00
|
|
|
# Align comments with method definitions.
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/CommentIndentation:
|
2016-09-14 04:57:52 -04:00
|
|
|
Enabled: true
|
|
|
|
|
2018-01-17 22:09:16 -05:00
|
|
|
Layout/ElseAlignment:
|
|
|
|
Enabled: true
|
|
|
|
|
2018-04-21 13:13:34 -04:00
|
|
|
# Align `end` with the matching keyword or starting expression except for
|
|
|
|
# assignments, where it should be aligned with the LHS.
|
|
|
|
Layout/EndAlignment:
|
|
|
|
Enabled: true
|
|
|
|
EnforcedStyleAlignWith: variable
|
|
|
|
AutoCorrect: true
|
|
|
|
|
2017-07-10 09:36:57 -04:00
|
|
|
Layout/EmptyLineAfterMagicComment:
|
|
|
|
Enabled: true
|
|
|
|
|
2018-07-12 08:29:48 -04:00
|
|
|
Layout/EmptyLinesAroundBlockBody:
|
|
|
|
Enabled: true
|
|
|
|
|
2016-08-06 11:45:37 -04:00
|
|
|
# In a regular class definition, no empty lines around the body.
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/EmptyLinesAroundClassBody:
|
2016-07-19 23:35:11 -04:00
|
|
|
Enabled: true
|
2016-06-13 10:29:50 -04:00
|
|
|
|
2017-02-12 06:44:15 -05:00
|
|
|
# In a regular method definition, no empty lines around the body.
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/EmptyLinesAroundMethodBody:
|
2017-02-12 06:44:15 -05:00
|
|
|
Enabled: true
|
|
|
|
|
2016-08-06 11:45:37 -04:00
|
|
|
# In a regular module definition, no empty lines around the body.
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/EmptyLinesAroundModuleBody:
|
2016-07-19 23:35:11 -04:00
|
|
|
Enabled: true
|
2016-07-17 03:10:45 -04:00
|
|
|
|
2017-07-16 05:11:03 -04:00
|
|
|
Layout/FirstParameterIndentation:
|
|
|
|
Enabled: true
|
|
|
|
|
2016-08-06 11:45:37 -04:00
|
|
|
# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
|
|
|
|
Style/HashSyntax:
|
2016-07-19 23:35:11 -04:00
|
|
|
Enabled: true
|
2016-07-17 03:10:45 -04:00
|
|
|
|
2016-07-21 07:49:13 -04:00
|
|
|
# Method definitions after `private` or `protected` isolated calls need one
|
|
|
|
# extra level of indentation.
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/IndentationConsistency:
|
2016-07-19 23:35:11 -04:00
|
|
|
Enabled: true
|
2016-07-17 03:10:45 -04:00
|
|
|
EnforcedStyle: rails
|
|
|
|
|
2016-08-06 11:45:37 -04:00
|
|
|
# Two spaces, no tabs (for indentation).
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/IndentationWidth:
|
2016-07-19 23:35:11 -04:00
|
|
|
Enabled: true
|
2016-07-17 03:10:45 -04:00
|
|
|
|
2017-12-14 03:30:54 -05:00
|
|
|
Layout/LeadingCommentSpace:
|
|
|
|
Enabled: true
|
|
|
|
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/SpaceAfterColon:
|
2016-10-28 23:05:58 -04:00
|
|
|
Enabled: true
|
|
|
|
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/SpaceAfterComma:
|
2016-10-28 23:05:58 -04:00
|
|
|
Enabled: true
|
|
|
|
|
2018-12-07 18:11:38 -05:00
|
|
|
Layout/SpaceAfterSemicolon:
|
|
|
|
Enabled: true
|
|
|
|
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/SpaceAroundEqualsInParameterDefault:
|
2016-10-28 23:05:58 -04:00
|
|
|
Enabled: true
|
|
|
|
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/SpaceAroundKeyword:
|
2016-10-28 23:05:58 -04:00
|
|
|
Enabled: true
|
|
|
|
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/SpaceAroundOperators:
|
2016-10-28 23:05:58 -04:00
|
|
|
Enabled: true
|
|
|
|
|
2017-12-12 06:00:50 -05:00
|
|
|
Layout/SpaceBeforeComma:
|
2018-12-07 18:11:38 -05:00
|
|
|
Enabled: true
|
2017-12-12 06:00:50 -05:00
|
|
|
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/SpaceBeforeFirstArg:
|
2018-12-07 18:11:38 -05:00
|
|
|
Enabled: true
|
2016-10-28 23:05:58 -04:00
|
|
|
|
2017-11-27 01:16:12 -05:00
|
|
|
Style/DefWithParentheses:
|
|
|
|
Enabled: true
|
|
|
|
|
2016-08-06 11:45:37 -04:00
|
|
|
# Defining a method with parameters needs parentheses.
|
|
|
|
Style/MethodDefParentheses:
|
|
|
|
Enabled: true
|
|
|
|
|
2017-07-09 08:06:36 -04:00
|
|
|
Style/FrozenStringLiteralComment:
|
|
|
|
Enabled: true
|
|
|
|
EnforcedStyle: always
|
2017-07-23 11:36:41 -04:00
|
|
|
Exclude:
|
|
|
|
- 'actionview/test/**/*.builder'
|
|
|
|
- 'actionview/test/**/*.ruby'
|
2017-07-24 16:20:53 -04:00
|
|
|
- 'actionpack/test/**/*.builder'
|
|
|
|
- 'actionpack/test/**/*.ruby'
|
2017-08-22 01:32:27 -04:00
|
|
|
- 'activestorage/db/migrate/**/*.rb'
|
2018-12-24 15:16:22 -05:00
|
|
|
- 'actionmailbox/db/migrate/**/*.rb'
|
2019-01-04 19:43:11 -05:00
|
|
|
- 'actiontext/db/migrate/**/*.rb'
|
2017-07-09 08:06:36 -04:00
|
|
|
|
2018-02-27 23:33:37 -05:00
|
|
|
Style/RedundantFreeze:
|
|
|
|
Enabled: true
|
|
|
|
|
2016-08-16 03:30:11 -04:00
|
|
|
# Use `foo {}` not `foo{}`.
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/SpaceBeforeBlockBraces:
|
2016-08-16 03:30:11 -04:00
|
|
|
Enabled: true
|
|
|
|
|
|
|
|
# Use `foo { bar }` not `foo {bar}`.
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/SpaceInsideBlockBraces:
|
2016-08-16 03:30:11 -04:00
|
|
|
Enabled: true
|
2018-09-25 13:18:20 -04:00
|
|
|
EnforcedStyleForEmptyBraces: space
|
2016-08-16 03:30:11 -04:00
|
|
|
|
|
|
|
# Use `{ a: 1 }` not `{a:1}`.
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/SpaceInsideHashLiteralBraces:
|
2016-08-16 03:30:11 -04:00
|
|
|
Enabled: true
|
|
|
|
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/SpaceInsideParens:
|
2016-10-28 23:05:58 -04:00
|
|
|
Enabled: true
|
|
|
|
|
2016-08-06 11:45:37 -04:00
|
|
|
# Check quotes usage according to lint rule below.
|
|
|
|
Style/StringLiterals:
|
|
|
|
Enabled: true
|
|
|
|
EnforcedStyle: double_quotes
|
|
|
|
|
|
|
|
# Detect hard tabs, no hard tabs.
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/Tab:
|
2016-08-06 11:45:37 -04:00
|
|
|
Enabled: true
|
|
|
|
|
|
|
|
# Blank lines should not have any spaces.
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/TrailingBlankLines:
|
2016-08-06 11:45:37 -04:00
|
|
|
Enabled: true
|
|
|
|
|
|
|
|
# No trailing whitespace.
|
2017-05-24 14:33:50 -04:00
|
|
|
Layout/TrailingWhitespace:
|
2016-08-06 11:45:37 -04:00
|
|
|
Enabled: true
|
|
|
|
|
|
|
|
# Use quotes for string literals when they are enough.
|
|
|
|
Style/UnneededPercentQ:
|
2016-07-19 23:35:11 -04:00
|
|
|
Enabled: true
|
|
|
|
|
2016-08-06 11:45:37 -04:00
|
|
|
# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
|
|
|
|
Lint/RequireParentheses:
|
|
|
|
Enabled: true
|
2017-10-28 08:15:34 -04:00
|
|
|
|
2018-12-27 17:33:05 -05:00
|
|
|
Lint/ShadowingOuterLocalVariable:
|
|
|
|
Enabled: true
|
|
|
|
|
2018-05-21 08:04:01 -04:00
|
|
|
Lint/StringConversionInInterpolation:
|
|
|
|
Enabled: true
|
|
|
|
|
2018-08-16 00:05:05 -04:00
|
|
|
Lint/UriEscapeUnescape:
|
|
|
|
Enabled: true
|
|
|
|
|
2018-08-18 19:12:05 -04:00
|
|
|
Style/ParenthesesAroundCondition:
|
|
|
|
Enabled: true
|
|
|
|
|
2018-12-20 12:44:01 -05:00
|
|
|
Style/RedundantBegin:
|
|
|
|
Enabled: true
|
|
|
|
|
2017-10-31 18:32:04 -04:00
|
|
|
Style/RedundantReturn:
|
|
|
|
Enabled: true
|
|
|
|
AllowMultipleReturnValues: true
|
|
|
|
|
2017-10-28 08:15:34 -04:00
|
|
|
Style/Semicolon:
|
|
|
|
Enabled: true
|
|
|
|
AllowAsExpressionSeparator: true
|
2018-02-22 01:26:48 -05:00
|
|
|
|
|
|
|
# Prefer Foo.method over Foo::method
|
|
|
|
Style/ColonMethodCall:
|
|
|
|
Enabled: true
|
2018-03-29 22:29:55 -04:00
|
|
|
|
|
|
|
Style/TrivialAccessors:
|
|
|
|
Enabled: true
|
|
|
|
|
|
|
|
Performance/FlatMap:
|
|
|
|
Enabled: true
|
|
|
|
|
|
|
|
Performance/RedundantMerge:
|
|
|
|
Enabled: true
|
2018-07-28 17:37:17 -04:00
|
|
|
|
|
|
|
Performance/StartWith:
|
|
|
|
Enabled: true
|
|
|
|
|
|
|
|
Performance/EndWith:
|
|
|
|
Enabled: true
|
|
|
|
|
|
|
|
Performance/RegexpMatch:
|
|
|
|
Enabled: true
|
2018-05-17 04:32:27 -04:00
|
|
|
|
|
|
|
Performance/UnfreezeString:
|
|
|
|
Enabled: true
|