kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #40053 from composerinteralia/safe-yaml-config-for

Browse source 
Use deep_symbolize_keys instead of symbolize_names
This commit is contained in:
Rafael França 2020-11-17 11:42:59 -05:00 committed by GitHub
commit 000e2853fa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
railties/lib/rails/application.rb
View file

@ -243,7 +243,7 @@ module Rails
if yaml.exist?
require "erb"
all_configs = ActiveSupport::ConfigurationFile.parse(yaml, symbolize_names: true)
all_configs = ActiveSupport::ConfigurationFile.parse(yaml).deep_symbolize_keys
config, shared = all_configs[env.to_sym], all_configs[:shared]
if config.is_a?(Hash)

13
railties/test/application/configuration_test.rb
View file

@ -2129,6 +2129,19 @@ module ApplicationTests
assert_equal "unicorn", Rails.application.config.my_custom_config[:key]
end
test "config_for handles YAML patches (like safe_yaml) that disable the symbolize_names option" do
app_file "config/custom.yml", <<~RUBY
development:
key: value
RUBY
app "development"
YAML.stub :load, { "development" => { "key" => "value" } } do
assert_equal({ key: "value" }, Rails.application.config_for(:custom))
end
end
test "api_only is false by default" do
app "development"
assert_not Rails.application.config.api_only