Fix urlsafe MessageVerifier not to include padding
urlsafe option was introduced to MessageVerifier in
09c3f36a96
but it can generate strings
containing padding character ("=") which is not urlsafe.
Fix not to pad when base64 encode.
This commit is contained in:
parent
6d8df0af70
commit
08afa160a5
|
@ -210,7 +210,7 @@ module ActiveSupport
|
||||||
|
|
||||||
private
|
private
|
||||||
def encode(data)
|
def encode(data)
|
||||||
@urlsafe ? Base64.urlsafe_encode64(data) : Base64.strict_encode64(data)
|
@urlsafe ? Base64.urlsafe_encode64(data, padding: false) : Base64.strict_encode64(data)
|
||||||
end
|
end
|
||||||
|
|
||||||
def decode(data)
|
def decode(data)
|
||||||
|
|
|
@ -360,6 +360,11 @@ class MessageVerifierUrlsafeTest < MessageVerifierMetadataTest
|
||||||
assert_equal message, URI.encode_www_form_component(message)
|
assert_equal message, URI.encode_www_form_component(message)
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def test_no_padding
|
||||||
|
message = generate("a")
|
||||||
|
assert_not_includes message, "="
|
||||||
|
end
|
||||||
|
|
||||||
private
|
private
|
||||||
def verifier_options
|
def verifier_options
|
||||||
{ urlsafe: true }
|
{ urlsafe: true }
|
||||||
|
|
Loading…
Reference in New Issue