From 0adcf6d90e787f2c953d2d58b875d1ff9ef71da8 Mon Sep 17 00:00:00 2001 From: Xavier Noria Date: Fri, 7 Dec 2012 15:20:02 +0100 Subject: [PATCH] let @version be always externally set in guides generation [fixes #8221] Shelling out was there for authors convenience, but we are rather going to have the tag or SHA1 always in RAILS_VERSION and if the environment variable is blank, then just use "local" as a reminder that you are just working locally. The docs server has been updated to set the long SHA1 in RAILS_VERSION when generating edge guides. --- guides/rails_guides/generator.rb | 2 +- guides/source/_welcome.html.erb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/guides/rails_guides/generator.rb b/guides/rails_guides/generator.rb index 3b124ef236..a53d34a279 100644 --- a/guides/rails_guides/generator.rb +++ b/guides/rails_guides/generator.rb @@ -84,7 +84,7 @@ module RailsGuides @warnings = ENV['WARNINGS'] == '1' @all = ENV['ALL'] == '1' @kindle = ENV['KINDLE'] == '1' - @version = ENV['RAILS_VERSION'] || `git rev-parse --short HEAD`.chomp + @version = ENV['RAILS_VERSION'] || 'local' @lang = ENV['GUIDES_LANGUAGE'] end diff --git a/guides/source/_welcome.html.erb b/guides/source/_welcome.html.erb index 9d2e9c1d68..a50961a0c7 100644 --- a/guides/source/_welcome.html.erb +++ b/guides/source/_welcome.html.erb @@ -1,4 +1,4 @@ -

Ruby on Rails Guides (<%= @version %>)

+

Ruby on Rails Guides (<%= @edge ? @version[0, 7] : @version %>)

<% if @edge %>