kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

This is even more explaining and upload/download don't have some inherent need to synchronize chunk sizes anyway

Browse source
This commit is contained in:
David Heinemeier Hansson 2017-07-06 15:35:48 +02:00
parent 89e8b86546
commit 0ed18d9671
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/active_storage/service/disk_service.rb
View file

@ -2,8 +2,6 @@ require "fileutils"
require "pathname" require "pathname"
class ActiveStorage::Service::DiskService < ActiveStorage::Service class ActiveStorage::Service::DiskService < ActiveStorage::Service
CHUNK_SIZE = 65536
attr_reader :root attr_reader :root
def initialize(root:) def initialize(root:)
@ -12,7 +10,7 @@ class ActiveStorage::Service::DiskService < ActiveStorage::Service
def upload(key, io) def upload(key, io)
File.open(make_path_for(key), "wb") do |file| File.open(make_path_for(key), "wb") do |file|
while chunk = io.read(CHUNK_SIZE) while chunk = io.read(64.kilobytes)
file.write(chunk) file.write(chunk)
end end
end end
@ -21,7 +19,7 @@ class ActiveStorage::Service::DiskService < ActiveStorage::Service
def download(key) def download(key)
if block_given? if block_given?
File.open(path_for(key)) do |file| File.open(path_for(key)) do |file|
while data = file.read(CHUNK_SIZE) while data = file.read(64.kilobytes)
yield data yield data
end end
end end