kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Remove deprecated ActiveRecord::Base.disable_implicit_join_references=

Browse source
This commit is contained in:
Rafael Mendonça França 2015-01-04 00:45:54 -03:00
parent efdc20f36c
commit 0fbd1fc888
3 changed files with 4 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
activerecord/CHANGELOG.md
View file

@ -1,3 +1,7 @@
* Remove deprecated `ActiveRecord::Base.disable_implicit_join_references=`.
*Rafael Mendonça França*
* Remove deprecated access to connection specification using a string acessor.
Now all strings will be handled as a URL.

7
activerecord/lib/active_record/core.rb
View file

@ -87,13 +87,6 @@ module ActiveRecord
mattr_accessor :maintain_test_schema, instance_accessor: false
def self.disable_implicit_join_references=(value)
ActiveSupport::Deprecation.warn(<<-MSG.squish)
Implicit join references were removed with Rails 4.1.
Make sure to remove this configuration because it does nothing.
MSG
end
class_attribute :default_connection_handler, instance_writer: false
class_attribute :find_by_statement_cache

6
activerecord/test/cases/relations_test.rb
View file

@ -1382,12 +1382,6 @@ class RelationTest < ActiveRecord::TestCase
assert_equal "id", Post.all.primary_key
end
def test_disable_implicit_join_references_is_deprecated
assert_deprecated do
ActiveRecord::Base.disable_implicit_join_references = true
end
end
def test_ordering_with_extra_spaces
assert_equal authors(:david), Author.order('id DESC , name DESC').last
end