From 10e361179d80a7449d892c4118ee27635ab85df6 Mon Sep 17 00:00:00 2001 From: Jean Boussier Date: Wed, 16 Feb 2022 13:03:25 +0100 Subject: [PATCH] Fix MemCacheStoreTest stubbing The stub wasn't called because it was defined on the `@cache` client rather than on `cache`'s client. This should reduce `MemCacheStoreTest` flakiness a bit. --- activesupport/test/cache/stores/mem_cache_store_test.rb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/activesupport/test/cache/stores/mem_cache_store_test.rb b/activesupport/test/cache/stores/mem_cache_store_test.rb index cb584bdd0c..d9cbae3457 100644 --- a/activesupport/test/cache/stores/mem_cache_store_test.rb +++ b/activesupport/test/cache/stores/mem_cache_store_test.rb @@ -85,7 +85,9 @@ class MemCacheStoreTest < ActiveSupport::TestCase def test_clear_also_clears_local_cache key = SecureRandom.uuid cache = lookup_store(raw: true) - client.stub(:flush_all, -> { client.delete(key) }) do + stub_called = false + + client(cache).stub(:flush_all, -> { stub_called = true; client.delete("#{@namespace}:#{key}") }) do cache.with_local_cache do cache.write(key, SecureRandom.alphanumeric) cache.clear @@ -93,6 +95,7 @@ class MemCacheStoreTest < ActiveSupport::TestCase end assert_nil cache.read(key) end + assert stub_called end def test_raw_values