kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

We don't really need all these to_a calls; fine to do a single check but rely on query otherwise

Browse source
This commit is contained in:
Kasper Timm Hansen 2021-03-03 16:05:45 +01:00
parent 17854e69b3
commit 14f35cde18
No known key found for this signature in database
GPG key ID: 191153215EDA53D8
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
activerecord/test/cases/excluding_test.rb
View file

@ -10,30 +10,32 @@ class ExcludingTest < ActiveRecord::TestCase
setup { @post = posts(:welcome) }
def test_result_set_does_not_include_single_excluded_record
assert_not_includes Post.excluding(@post), @post
assert_not_includes Post.excluding(@post).to_a, @post
assert_not_includes Post.without(@post).to_a, @post
assert_not_includes Post.without(@post), @post
end
def test_result_set_does_not_include_collection_of_excluded_records
relation = Post.excluding(@post, posts(:thinking))
assert_not_includes relation.to_a, @post
assert_not_includes relation.to_a, posts(:thinking)
assert_not_includes relation, @post
assert_not_includes relation, posts(:thinking)
end
def test_result_set_through_association_does_not_include_single_excluded_record
comment_greetings, comment_more_greetings = comments(:greetings, :more_greetings)
relation = @post.comments.excluding(comment_greetings)
assert_not_includes relation.to_a, comment_greetings
assert_includes relation.to_a, comment_more_greetings
assert_not_includes relation, comment_greetings
assert_includes relation, comment_more_greetings
end
def test_result_set_through_association_does_not_include_collection_of_excluded_records
comment_greetings, comment_more_greetings = comments(:greetings, :more_greetings)
relation = @post.comments.excluding([ comment_greetings, comment_more_greetings ])
assert_not_includes relation.to_a, comment_greetings
assert_not_includes relation.to_a, comment_more_greetings
assert_not_includes relation, comment_greetings
assert_not_includes relation, comment_more_greetings
end
def test_does_not_exclude_records_when_no_arguments