kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Use require_dependency inside Active Storage

Browse source 
Active Storage is an engine which means its models, jobs and controllers
are autoloaded by Rails rather than Ruby. Unfortunately this means it's
subject to the same gotchas as applications, including this one:

http://guides.rubyonrails.org/v5.1.4/autoloading_and_reloading_constants.html#when-constants-aren-t-missed-qualified-references

On Ruby < 2.5, constants nested under classes can't be autoloaded by
Rails if a top level constant already exists with the same name.

To avoid clashing with constants defined in users' applications or gems,
we can use `require_dependency` to ensure that the nested constants are
loaded before they're used.
This commit is contained in:
Eugene Kenny 2018-02-14 23:15:12 +00:00
parent fa9e791e01
commit 1e55ee5a28
2 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
activestorage/app/models/active_storage/blob.rb
View file

@ -14,9 +14,13 @@
# update a blob's metadata on a subsequent pass, but you should not update the key or change the uploaded file. # update a blob's metadata on a subsequent pass, but you should not update the key or change the uploaded file.
# If you need to create a derivative or otherwise change the blob, simply create a new blob and purge the old one. # If you need to create a derivative or otherwise change the blob, simply create a new blob and purge the old one.
class ActiveStorage::Blob < ActiveRecord::Base class ActiveStorage::Blob < ActiveRecord::Base
include ActiveStorage::Blob::Analyzable require_dependency "active_storage/blob/analyzable"
include ActiveStorage::Blob::Identifiable require_dependency "active_storage/blob/identifiable"
include ActiveStorage::Blob::Representable require_dependency "active_storage/blob/representable"
include Analyzable
include Identifiable
include Representable
self.table_name = "active_storage_blobs" self.table_name = "active_storage_blobs"

2
activestorage/app/models/active_storage/filename.rb
View file

@ -3,6 +3,8 @@
# Encapsulates a string representing a filename to provide convenient access to parts of it and sanitization. # Encapsulates a string representing a filename to provide convenient access to parts of it and sanitization.
# A Filename instance is returned by ActiveStorage::Blob#filename, and is comparable so it can be used for sorting. # A Filename instance is returned by ActiveStorage::Blob#filename, and is comparable so it can be used for sorting.
class ActiveStorage::Filename class ActiveStorage::Filename
require_dependency "active_storage/filename/parameters"
include Comparable include Comparable
class << self class << self