Failing tests for to_param/to_query not escaping "[]"
This commit is contained in:
parent
49e943c4f0
commit
1ee9b40b18
|
@ -38,7 +38,7 @@ class Hash
|
|||
# ==== Examples
|
||||
# { :name => 'David', :nationality => 'Danish' }.to_query # => "name=David&nationality=Danish"
|
||||
#
|
||||
# { :name => 'David', :nationality => 'Danish' }.to_query('user') # => "user%5Bname%5D=David&user%5Bnationality%5D=Danish"
|
||||
# { :name => 'David', :nationality => 'Danish' }.to_query('user') # => "user[name]=David&user[nationality]=Danish"
|
||||
def to_param(namespace = nil)
|
||||
collect do |key, value|
|
||||
value.to_query(namespace ? "#{namespace}[#{key}]" : key)
|
||||
|
|
|
@ -15,7 +15,7 @@ class Array
|
|||
# Converts an array into a string suitable for use as a URL query string,
|
||||
# using the given +key+ as the param name.
|
||||
#
|
||||
# ['Rails', 'coding'].to_query('hobbies') # => "hobbies%5B%5D=Rails&hobbies%5B%5D=coding"
|
||||
# ['Rails', 'coding'].to_query('hobbies') # => "hobbies[]=Rails&hobbies[]=coding"
|
||||
def to_query(key)
|
||||
prefix = "#{key}[]"
|
||||
collect { |value| value.to_query(prefix) }.join '&'
|
||||
|
|
|
@ -17,22 +17,22 @@ class ToQueryTest < Test::Unit::TestCase
|
|||
end
|
||||
|
||||
def test_nested_conversion
|
||||
assert_query_equal 'person%5Blogin%5D=seckar&person%5Bname%5D=Nicholas',
|
||||
assert_query_equal 'person[login]=seckar&person[name]=Nicholas',
|
||||
:person => {:name => 'Nicholas', :login => 'seckar'}
|
||||
end
|
||||
|
||||
def test_multiple_nested
|
||||
assert_query_equal 'account%5Bperson%5D%5Bid%5D=20&person%5Bid%5D=10',
|
||||
assert_query_equal 'account[person][id]=20&person[id]=10',
|
||||
:person => {:id => 10}, :account => {:person => {:id => 20}}
|
||||
end
|
||||
|
||||
def test_array_values
|
||||
assert_query_equal 'person%5Bid%5D%5B%5D=10&person%5Bid%5D%5B%5D=20',
|
||||
assert_query_equal 'person[id][]=10&person[id][]=20',
|
||||
:person => {:id => [10, 20]}
|
||||
end
|
||||
|
||||
def test_array_values_are_not_sorted
|
||||
assert_query_equal 'person%5Bid%5D%5B%5D=20&person%5Bid%5D%5B%5D=10',
|
||||
assert_query_equal 'person[id][]=20&person[id][]=10',
|
||||
:person => {:id => [20, 10]}
|
||||
end
|
||||
|
||||
|
|
Loading…
Reference in New Issue