kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Change require order to come require "models/post" before require "models/comment"

Browse source 
to address BasicsTest#test_readonly_attributes failure #26368

It reproduces only when both of these conditions are satisfied:

- Other test files `autosave_association_test.rb` or `where_test.rb`
  which executes `require "models/comment"` then `require "models/post"`
- When `autosave_association_test.rb` or `where_test.rb` executed before `base_test.rb`
This commit is contained in:
Yasuo Honda 2016-09-02 15:40:59 +00:00
parent 55c5dffd9f
commit 1f0112dfc3
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
activerecord/test/cases/autosave_association_test.rb
View file

@ -1,5 +1,6 @@
require "cases/helper" require "cases/helper"
require "models/bird" require "models/bird"
require "models/post"
require "models/comment" require "models/comment"
require "models/company" require "models/company"
require "models/customer" require "models/customer"
@ -11,7 +12,6 @@ require "models/order"
require "models/parrot" require "models/parrot"
require "models/person" require "models/person"
require "models/pirate" require "models/pirate"
require "models/post"
require "models/reader" require "models/reader"
require "models/ship" require "models/ship"
require "models/ship_part" require "models/ship_part"

2
activerecord/test/cases/relation/where_test.rb
View file

@ -4,10 +4,10 @@ require "models/binary"
require "models/cake_designer" require "models/cake_designer"
require "models/car" require "models/car"
require "models/chef" require "models/chef"
require "models/post"
require "models/comment" require "models/comment"
require "models/edge" require "models/edge"
require "models/essay" require "models/essay"
require "models/post"
require "models/price_estimate" require "models/price_estimate"
require "models/topic" require "models/topic"
require "models/treasure" require "models/treasure"