kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Fix header capitalization by explicitly upcasing first letter of every word, and avoiding capitalize. [#5636 state:resolved]

Browse source
This commit is contained in:
Maxim Chernyak 2010-09-18 04:08:48 -04:00 committed by José Valim
parent 154081f0f7
commit 20685d07ab
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
actionpack/lib/action_controller/metal/head.rb
View file

@ -22,7 +22,7 @@ module ActionController
location = options.delete(:location) location = options.delete(:location)
options.each do |key, value| options.each do |key, value|
headers[key.to_s.dasherize.split(/-/).map { |v| v.capitalize }.join("-")] = value.to_s headers[key.to_s.dasherize.split('-').each { |v| v[0] = v[0].chr.upcase }.join('-')] = value.to_s
end end
self.status = status self.status = status

11
actionpack/test/controller/render_test.rb
View file

@ -488,6 +488,10 @@ class TestController < ActionController::Base
head :x_custom_header => "something" head :x_custom_header => "something"
end end
def head_with_www_authenticate_header
head 'WWW-Authenticate' => 'something'
end
def head_with_status_code_first def head_with_status_code_first
head :forbidden, :x_custom_header => "something" head :forbidden, :x_custom_header => "something"
end end
@ -1139,6 +1143,13 @@ class RenderTest < ActionController::TestCase
assert_response :ok assert_response :ok
end end
def test_head_with_www_authenticate_header
get :head_with_www_authenticate_header
assert_blank @response.body
assert_equal "something", @response.headers["WWW-Authenticate"]
assert_response :ok
end
def test_head_with_symbolic_status def test_head_with_symbolic_status
get :head_with_symbolic_status, :status => "ok" get :head_with_symbolic_status, :status => "ok"
assert_equal 200, @response.status assert_equal 200, @response.status