mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
Change refute to assert_not
This commit is contained in:
parent
0d50cae996
commit
211adb47e7
19 changed files with 51 additions and 51 deletions
|
@ -167,7 +167,7 @@ module ActionCable::StreamTests
|
|||
|
||||
@server.broadcast "channel", {}
|
||||
wait_for_async
|
||||
refute Thread.current[:ran_callback], "User callback was not run through the worker pool"
|
||||
assert_not Thread.current[:ran_callback], "User callback was not run through the worker pool"
|
||||
end
|
||||
end
|
||||
|
||||
|
|
|
@ -23,9 +23,9 @@ class MetalControllerInstanceTests < ActiveSupport::TestCase
|
|||
"rack.input" => -> {}
|
||||
)[1]
|
||||
|
||||
refute response_headers.key?("X-Frame-Options")
|
||||
refute response_headers.key?("X-Content-Type-Options")
|
||||
refute response_headers.key?("X-XSS-Protection")
|
||||
assert_not response_headers.key?("X-Frame-Options")
|
||||
assert_not response_headers.key?("X-Content-Type-Options")
|
||||
assert_not response_headers.key?("X-XSS-Protection")
|
||||
ensure
|
||||
ActionDispatch::Response.default_headers = original_default_headers
|
||||
end
|
||||
|
|
|
@ -82,7 +82,7 @@ class ParametersAccessorsTest < ActiveSupport::TestCase
|
|||
end
|
||||
|
||||
test "empty? returns false when any params are present" do
|
||||
refute @params.empty?
|
||||
assert_not @params.empty?
|
||||
end
|
||||
|
||||
test "except retains permitted status" do
|
||||
|
@ -112,7 +112,7 @@ class ParametersAccessorsTest < ActiveSupport::TestCase
|
|||
end
|
||||
|
||||
test "has_key? returns false if the given key is not present in the params" do
|
||||
refute @params.has_key?(:address)
|
||||
assert_not @params.has_key?(:address)
|
||||
end
|
||||
|
||||
test "has_value? returns true if the given value is present in the params" do
|
||||
|
@ -122,7 +122,7 @@ class ParametersAccessorsTest < ActiveSupport::TestCase
|
|||
|
||||
test "has_value? returns false if the given value is not present in the params" do
|
||||
params = ActionController::Parameters.new(city: "Chicago", state: "Illinois")
|
||||
refute params.has_value?("New York")
|
||||
assert_not params.has_value?("New York")
|
||||
end
|
||||
|
||||
test "include? returns true if the given key is present in the params" do
|
||||
|
@ -130,7 +130,7 @@ class ParametersAccessorsTest < ActiveSupport::TestCase
|
|||
end
|
||||
|
||||
test "include? returns false if the given key is not present in the params" do
|
||||
refute @params.include?(:address)
|
||||
assert_not @params.include?(:address)
|
||||
end
|
||||
|
||||
test "key? returns true if the given key is present in the params" do
|
||||
|
@ -138,7 +138,7 @@ class ParametersAccessorsTest < ActiveSupport::TestCase
|
|||
end
|
||||
|
||||
test "key? returns false if the given key is not present in the params" do
|
||||
refute @params.key?(:address)
|
||||
assert_not @params.key?(:address)
|
||||
end
|
||||
|
||||
test "keys returns an array of the keys of the params" do
|
||||
|
@ -198,7 +198,7 @@ class ParametersAccessorsTest < ActiveSupport::TestCase
|
|||
|
||||
test "value? returns false if the given value is not present in the params" do
|
||||
params = ActionController::Parameters.new(city: "Chicago", state: "Illinois")
|
||||
refute params.value?("New York")
|
||||
assert_not params.value?("New York")
|
||||
end
|
||||
|
||||
test "values returns an array of the values of the params" do
|
||||
|
|
|
@ -500,9 +500,9 @@ class ParametersPermitTest < ActiveSupport::TestCase
|
|||
params = ActionController::Parameters.new(foo: "bar")
|
||||
|
||||
assert params.permit(:foo).has_key?(:foo)
|
||||
refute params.permit(foo: []).has_key?(:foo)
|
||||
refute params.permit(foo: [:bar]).has_key?(:foo)
|
||||
refute params.permit(foo: :bar).has_key?(:foo)
|
||||
assert_not params.permit(foo: []).has_key?(:foo)
|
||||
assert_not params.permit(foo: [:bar]).has_key?(:foo)
|
||||
assert_not params.permit(foo: :bar).has_key?(:foo)
|
||||
end
|
||||
|
||||
test "#permitted? is false by default" do
|
||||
|
|
|
@ -187,7 +187,7 @@ module ActiveModel
|
|||
test "an attribute is not changed if it hasn't been assigned or mutated" do
|
||||
attribute = Attribute.from_database(:foo, 1, Type::Value.new)
|
||||
|
||||
refute attribute.changed?
|
||||
assert_not attribute.changed?
|
||||
end
|
||||
|
||||
test "an attribute is changed if it's been assigned a new value" do
|
||||
|
@ -201,7 +201,7 @@ module ActiveModel
|
|||
attribute = Attribute.from_database(:foo, 1, Type::Value.new)
|
||||
unchanged = attribute.with_value_from_user(1)
|
||||
|
||||
refute unchanged.changed?
|
||||
assert_not unchanged.changed?
|
||||
end
|
||||
|
||||
test "an attribute can not be mutated if it has not been read,
|
||||
|
@ -226,7 +226,7 @@ module ActiveModel
|
|||
forgotten = changed.forgetting_assignment
|
||||
|
||||
assert changed.changed? # sanity check
|
||||
refute forgotten.changed?
|
||||
assert_not forgotten.changed?
|
||||
end
|
||||
|
||||
test "with_value_from_user validates the value" do
|
||||
|
|
|
@ -257,7 +257,7 @@ class PostgresqlArrayTest < ActiveRecord::PostgreSQLTestCase
|
|||
x = PgArray.create!(tags: tags)
|
||||
x.reload
|
||||
|
||||
refute x.changed?
|
||||
assert_not x.changed?
|
||||
end
|
||||
|
||||
def test_quoting_non_standard_delimiters
|
||||
|
|
|
@ -174,7 +174,7 @@ class PostgresqlHstoreTest < ActiveRecord::PostgreSQLTestCase
|
|||
|
||||
hstore.settings = { "key" => "value", "alongkey" => "anything" }
|
||||
assert_equal settings, hstore.settings
|
||||
refute hstore.changed?
|
||||
assert_not hstore.changed?
|
||||
end
|
||||
|
||||
def test_hstore_dirty_from_database_equal
|
||||
|
@ -184,7 +184,7 @@ class PostgresqlHstoreTest < ActiveRecord::PostgreSQLTestCase
|
|||
|
||||
assert_equal settings, hstore.settings
|
||||
hstore.settings = settings
|
||||
refute hstore.changed?
|
||||
assert_not hstore.changed?
|
||||
end
|
||||
|
||||
def test_gen1
|
||||
|
|
|
@ -211,7 +211,7 @@ module ActiveRecord
|
|||
end
|
||||
|
||||
test "attributes not backed by database columns are not dirty when unchanged" do
|
||||
refute OverloadedType.new.non_existent_decimal_changed?
|
||||
assert_not OverloadedType.new.non_existent_decimal_changed?
|
||||
end
|
||||
|
||||
test "attributes not backed by database columns are always initialized" do
|
||||
|
@ -251,7 +251,7 @@ module ActiveRecord
|
|||
assert_equal "lol", model.foo
|
||||
|
||||
model.foo = "lol"
|
||||
refute model.changed?
|
||||
assert_not model.changed?
|
||||
end
|
||||
|
||||
test "attributes not backed by database columns appear in inspect" do
|
||||
|
|
|
@ -1490,7 +1490,7 @@ class BasicsTest < ActiveRecord::TestCase
|
|||
query = Developer.all.to_sql.downcase
|
||||
|
||||
# ignored column
|
||||
refute query.include?("first_name")
|
||||
assert_not query.include?("first_name")
|
||||
|
||||
# regular column
|
||||
assert query.include?("name")
|
||||
|
|
|
@ -762,7 +762,7 @@ class DirtyTest < ActiveRecord::TestCase
|
|||
|
||||
test "attributes assigned but not selected are dirty" do
|
||||
person = Person.select(:id).first
|
||||
refute person.changed?
|
||||
assert_not person.changed?
|
||||
|
||||
person.first_name = "Sean"
|
||||
assert person.changed?
|
||||
|
@ -782,13 +782,13 @@ class DirtyTest < ActiveRecord::TestCase
|
|||
person = Person.create!(first_name: "Sean")
|
||||
|
||||
assert person.saved_change_to_first_name?
|
||||
refute person.saved_change_to_gender?
|
||||
assert_not person.saved_change_to_gender?
|
||||
assert person.saved_change_to_first_name?(from: nil, to: "Sean")
|
||||
assert person.saved_change_to_first_name?(from: nil)
|
||||
assert person.saved_change_to_first_name?(to: "Sean")
|
||||
refute person.saved_change_to_first_name?(from: "Jim", to: "Sean")
|
||||
refute person.saved_change_to_first_name?(from: "Jim")
|
||||
refute person.saved_change_to_first_name?(to: "Jim")
|
||||
assert_not person.saved_change_to_first_name?(from: "Jim", to: "Sean")
|
||||
assert_not person.saved_change_to_first_name?(from: "Jim")
|
||||
assert_not person.saved_change_to_first_name?(to: "Jim")
|
||||
end
|
||||
|
||||
test "saved_change_to_attribute returns the change that occurred in the last save" do
|
||||
|
@ -827,7 +827,7 @@ class DirtyTest < ActiveRecord::TestCase
|
|||
|
||||
person.save
|
||||
|
||||
refute person.saved_changes?
|
||||
assert_not person.saved_changes?
|
||||
end
|
||||
|
||||
test "saved_changes returns a hash of all the changes that occurred" do
|
||||
|
@ -857,7 +857,7 @@ class DirtyTest < ActiveRecord::TestCase
|
|||
end
|
||||
|
||||
person = klass.create!(first_name: "Sean")
|
||||
refute person.changed?
|
||||
assert_not person.changed?
|
||||
end
|
||||
|
||||
private
|
||||
|
|
|
@ -532,7 +532,7 @@ class OptimisticLockingWithSchemaChangeTest < ActiveRecord::TestCase
|
|||
stale_object.destroy!
|
||||
end
|
||||
|
||||
refute stale_object.destroyed?
|
||||
assert_not stale_object.destroyed?
|
||||
end
|
||||
|
||||
private
|
||||
|
|
|
@ -235,12 +235,12 @@ if ActiveRecord::Base.connection.supports_foreign_keys?
|
|||
assert_equal 1, foreign_keys.size
|
||||
|
||||
fk = foreign_keys.first
|
||||
refute fk.validated?
|
||||
assert_not fk.validated?
|
||||
end
|
||||
|
||||
def test_validate_foreign_key_infers_column
|
||||
@connection.add_foreign_key :astronauts, :rockets, validate: false
|
||||
refute @connection.foreign_keys("astronauts").first.validated?
|
||||
assert_not @connection.foreign_keys("astronauts").first.validated?
|
||||
|
||||
@connection.validate_foreign_key :astronauts, :rockets
|
||||
assert @connection.foreign_keys("astronauts").first.validated?
|
||||
|
@ -248,7 +248,7 @@ if ActiveRecord::Base.connection.supports_foreign_keys?
|
|||
|
||||
def test_validate_foreign_key_by_column
|
||||
@connection.add_foreign_key :astronauts, :rockets, column: "rocket_id", validate: false
|
||||
refute @connection.foreign_keys("astronauts").first.validated?
|
||||
assert_not @connection.foreign_keys("astronauts").first.validated?
|
||||
|
||||
@connection.validate_foreign_key :astronauts, column: "rocket_id"
|
||||
assert @connection.foreign_keys("astronauts").first.validated?
|
||||
|
@ -256,7 +256,7 @@ if ActiveRecord::Base.connection.supports_foreign_keys?
|
|||
|
||||
def test_validate_foreign_key_by_symbol_column
|
||||
@connection.add_foreign_key :astronauts, :rockets, column: :rocket_id, validate: false
|
||||
refute @connection.foreign_keys("astronauts").first.validated?
|
||||
assert_not @connection.foreign_keys("astronauts").first.validated?
|
||||
|
||||
@connection.validate_foreign_key :astronauts, column: :rocket_id
|
||||
assert @connection.foreign_keys("astronauts").first.validated?
|
||||
|
@ -264,7 +264,7 @@ if ActiveRecord::Base.connection.supports_foreign_keys?
|
|||
|
||||
def test_validate_foreign_key_by_name
|
||||
@connection.add_foreign_key :astronauts, :rockets, column: "rocket_id", name: "fancy_named_fk", validate: false
|
||||
refute @connection.foreign_keys("astronauts").first.validated?
|
||||
assert_not @connection.foreign_keys("astronauts").first.validated?
|
||||
|
||||
@connection.validate_foreign_key :astronauts, name: "fancy_named_fk"
|
||||
assert @connection.foreign_keys("astronauts").first.validated?
|
||||
|
|
|
@ -86,7 +86,7 @@ module ActiveRecord
|
|||
rename_table :cats, :felines
|
||||
|
||||
assert connection.table_exists? :felines
|
||||
refute connection.table_exists? :cats
|
||||
assert_not connection.table_exists? :cats
|
||||
|
||||
primary_key_name = connection.select_values(<<-SQL.strip_heredoc, "SCHEMA")[0]
|
||||
SELECT c.relname
|
||||
|
@ -107,7 +107,7 @@ module ActiveRecord
|
|||
connection.create_table :cats, id: :uuid, default: "uuid_generate_v4()"
|
||||
assert_nothing_raised { rename_table :cats, :felines }
|
||||
assert connection.table_exists? :felines
|
||||
refute connection.table_exists? :cats
|
||||
assert_not connection.table_exists? :cats
|
||||
ensure
|
||||
connection.drop_table :cats, if_exists: true
|
||||
connection.drop_table :felines, if_exists: true
|
||||
|
|
|
@ -327,7 +327,7 @@ class QueryCacheTest < ActiveRecord::TestCase
|
|||
conf = ActiveRecord::Base.configurations["arunit"].merge("name" => "test2")
|
||||
ActiveRecord::Base.connection_handler.establish_connection(conf)
|
||||
Task.connection_specification_name = "test2"
|
||||
refute Task.connected?
|
||||
assert_not Task.connected?
|
||||
|
||||
Task.cache do
|
||||
begin
|
||||
|
@ -414,20 +414,20 @@ class QueryCacheTest < ActiveRecord::TestCase
|
|||
def test_query_cache_does_not_establish_connection_if_unconnected
|
||||
with_temporary_connection_pool do
|
||||
ActiveRecord::Base.clear_active_connections!
|
||||
refute ActiveRecord::Base.connection_handler.active_connections? # sanity check
|
||||
assert_not ActiveRecord::Base.connection_handler.active_connections? # sanity check
|
||||
|
||||
middleware {
|
||||
refute ActiveRecord::Base.connection_handler.active_connections?, "QueryCache forced ActiveRecord::Base to establish a connection in setup"
|
||||
assert_not ActiveRecord::Base.connection_handler.active_connections?, "QueryCache forced ActiveRecord::Base to establish a connection in setup"
|
||||
}.call({})
|
||||
|
||||
refute ActiveRecord::Base.connection_handler.active_connections?, "QueryCache forced ActiveRecord::Base to establish a connection in cleanup"
|
||||
assert_not ActiveRecord::Base.connection_handler.active_connections?, "QueryCache forced ActiveRecord::Base to establish a connection in cleanup"
|
||||
end
|
||||
end
|
||||
|
||||
def test_query_cache_is_enabled_on_connections_established_after_middleware_runs
|
||||
with_temporary_connection_pool do
|
||||
ActiveRecord::Base.clear_active_connections!
|
||||
refute ActiveRecord::Base.connection_handler.active_connections? # sanity check
|
||||
assert_not ActiveRecord::Base.connection_handler.active_connections? # sanity check
|
||||
|
||||
middleware {
|
||||
assert ActiveRecord::Base.connection.query_cache_enabled, "QueryCache did not get lazily enabled"
|
||||
|
@ -444,8 +444,8 @@ class QueryCacheTest < ActiveRecord::TestCase
|
|||
assert ActiveRecord::Base.connection.query_cache_enabled
|
||||
|
||||
Thread.new {
|
||||
refute ActiveRecord::Base.connection_pool.query_cache_enabled
|
||||
refute ActiveRecord::Base.connection.query_cache_enabled
|
||||
assert_not ActiveRecord::Base.connection_pool.query_cache_enabled
|
||||
assert_not ActiveRecord::Base.connection.query_cache_enabled
|
||||
}.join
|
||||
}.call({})
|
||||
|
||||
|
|
|
@ -115,7 +115,7 @@ class RelationMergingTest < ActiveRecord::TestCase
|
|||
relation = Post.all
|
||||
assert relation.from_clause.empty?
|
||||
relation = relation.merge(Post.from("posts"))
|
||||
refute relation.from_clause.empty?
|
||||
assert_not relation.from_clause.empty?
|
||||
end
|
||||
end
|
||||
|
||||
|
|
|
@ -349,7 +349,7 @@ class SerializedAttributeTest < ActiveRecord::TestCase
|
|||
|
||||
topic = model.create!(foo: "bar")
|
||||
topic.foo
|
||||
refute topic.changed?
|
||||
assert_not topic.changed?
|
||||
end
|
||||
|
||||
def test_serialized_attribute_works_under_concurrent_initial_access
|
||||
|
|
|
@ -530,7 +530,7 @@ class UniquenessValidationTest < ActiveRecord::TestCase
|
|||
assert topic.author_name.start_with?("Title1")
|
||||
|
||||
topic2 = TopicWithAfterCreate.new(title: "Title1")
|
||||
refute topic2.valid?
|
||||
assert_not topic2.valid?
|
||||
assert_equal(["has already been taken"], topic2.errors[:title])
|
||||
end
|
||||
|
||||
|
@ -550,7 +550,7 @@ class UniquenessValidationTest < ActiveRecord::TestCase
|
|||
assert_empty item.errors
|
||||
|
||||
item2 = CoolTopic.new(id: item.id, title: "MyItem2")
|
||||
refute item2.valid?
|
||||
assert_not item2.valid?
|
||||
|
||||
assert_equal(["has already been taken"], item2.errors[:id])
|
||||
end
|
||||
|
|
|
@ -30,11 +30,11 @@ class ClassTest < ActiveSupport::TestCase
|
|||
|
||||
def test_descendants_excludes_singleton_classes
|
||||
klass = Parent.new.singleton_class
|
||||
refute Parent.descendants.include?(klass), "descendants should not include singleton classes"
|
||||
assert_not Parent.descendants.include?(klass), "descendants should not include singleton classes"
|
||||
end
|
||||
|
||||
def test_subclasses_excludes_singleton_classes
|
||||
klass = Parent.new.singleton_class
|
||||
refute Parent.subclasses.include?(klass), "subclasses should not include singleton classes"
|
||||
assert_not Parent.subclasses.include?(klass), "subclasses should not include singleton classes"
|
||||
end
|
||||
end
|
||||
|
|
|
@ -1831,7 +1831,7 @@ module ApplicationTests
|
|||
|
||||
test "api_only is false by default" do
|
||||
app "development"
|
||||
refute Rails.application.config.api_only
|
||||
assert_not Rails.application.config.api_only
|
||||
end
|
||||
|
||||
test "api_only generator config is set when api_only is set" do
|
||||
|
|
Loading…
Reference in a new issue