kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #38210 from Edouard-chin/ec-numeric-validation-doublefig

Browse source 
Fix NumericalityValidator when precision is too high:
This commit is contained in:
Eileen M. Uchitelle 2020-01-10 13:02:12 -05:00 committed by GitHub
commit 25a5b296a3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
activerecord/lib/active_record/validations/numericality.rb
View file

@ -4,7 +4,7 @@ module ActiveRecord
module Validations
class NumericalityValidator < ActiveModel::Validations::NumericalityValidator # :nodoc:
def validate_each(record, attribute, value, precision: nil)
precision = column_precision_for(attribute, record) || Float::DIG
precision = [column_precision_for(attribute, record) || BigDecimal.double_fig, BigDecimal.double_fig].min
super
end

20
activerecord/test/cases/validations/numericality_validation_test.rb
View file

@ -20,12 +20,22 @@ class NumericalityValidationTest < ActiveRecord::TestCase
assert_predicate subject, :valid?
end
def test_no_column_precision
def test_column_with_precision_higher_than_double_fig
model_class.validates_numericality_of(
:decimal_number, equal_to: 1_000_000_000.12345
:decimal_number_big_precision, equal_to: 10_000_000.3
)
subject = model_class.new(decimal_number: 1_000_000_000.123454)
subject = model_class.new(decimal_number_big_precision: 10_000_000.3)
assert_predicate subject, :valid?
end
def test_no_column_precision
model_class.validates_numericality_of(
:decimal_number, equal_to: 1_000_000_000.123454
)
subject = model_class.new(decimal_number: 1_000_000_000.1234545)
assert_predicate subject, :valid?
end
@ -33,10 +43,10 @@ class NumericalityValidationTest < ActiveRecord::TestCase
def test_virtual_attribute
model_class.attribute(:virtual_decimal_number, :decimal)
model_class.validates_numericality_of(
:virtual_decimal_number, equal_to: 1_000_000_000.12345
:virtual_decimal_number, equal_to: 1_000_000_000.123454
)
subject = model_class.new(virtual_decimal_number: 1_000_000_000.123454)
subject = model_class.new(virtual_decimal_number: 1_000_000_000.1234545)
assert_predicate subject, :valid?
end

1
activerecord/test/schema/schema.rb
View file

@ -585,6 +585,7 @@ ActiveRecord::Schema.define do
t.decimal :decimal_number
t.decimal :decimal_number_with_default, precision: 3, scale: 2, default: 2.78
t.float :temperature
t.decimal :decimal_number_big_precision, precision: 20
# Oracle/SQLServer supports precision up to 38
if current_adapter?(:OracleAdapter, :SQLServerAdapter)
t.decimal :atoms_in_universe, precision: 38, scale: 0