1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

Add name to ActionCable threads

To assist in various debugging scenarios, such as [tracking which types of threads are using db connections][0]

Thread names will now be "ActionCable-worker-N" instead of "worker-N".

This is safe for all ruby versions. In versions which do not have thread names, [concurrent-ruby does not attempt to add the name][1]

In the environment I happened to be testing in:

```ruby
e = Concurrent::ThreadPoolExecutor.new(name: 'ActionCable', min_threads: 2, max_threads: 2)
e.post{sleep 100}
e.post{sleep 100}
Thread.list.map(&:name)
```

[0] https://github.com/puma/puma/issues/1512#issuecomment-756760388
[1] https://github.com/ruby-concurrency/concurrent-ruby/blob/master/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb#L312
This commit is contained in:
John Bachir 2021-01-12 16:59:44 +00:00 committed by Jeremy Daer
parent 92c6f41cdb
commit 267e1d25dc

View file

@ -19,6 +19,7 @@ module ActionCable
def initialize(max_size: 5)
@executor = Concurrent::ThreadPoolExecutor.new(
name: "ActionCable",
min_threads: 1,
max_threads: max_size,
max_queue: 0,