Fixed that the dynamic finder like find_all_by_something_boolean(false) didn't work #649 [lmarlow@yahoo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@666 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
This commit is contained in:
parent
37249f6a86
commit
28edbca477
|
@ -1,5 +1,7 @@
|
|||
*SVN*
|
||||
|
||||
* Fixed that the dynamic finder like find_all_by_something_boolean(false) didn't work #649 [lmarlow@yahoo.com]
|
||||
|
||||
* Added validates_each that validates each specified attribute against a block #610 [bitsweat]. Example:
|
||||
|
||||
class Person < ActiveRecord::Base
|
||||
|
|
|
@ -755,7 +755,7 @@ module ActiveRecord #:nodoc:
|
|||
attributes.each { |attr_name| super unless column_methods_hash[attr_name.intern] }
|
||||
|
||||
attr_index = -1
|
||||
conditions = attributes.collect { |attr_name| attr_index += 1; "#{attr_name} #{arguments[attr_index] ? "=" : "IS"} ? " }.join(" AND ")
|
||||
conditions = attributes.collect { |attr_name| attr_index += 1; "#{attr_name} #{arguments[attr_index].nil? ? "IS" : "="} ? " }.join(" AND ")
|
||||
send(finder, [conditions, *arguments[0...attributes.length]], *arguments[attributes.length..-1])
|
||||
else
|
||||
super
|
||||
|
|
|
@ -199,6 +199,16 @@ class FinderTest < Test::Unit::TestCase
|
|||
|
||||
assert_equal [], Topic.find_all_by_title("The First Topic!!")
|
||||
end
|
||||
|
||||
def test_find_all_by_boolean_attribute
|
||||
topics = Topic.find_all_by_approved(false)
|
||||
assert_equal 1, topics.size
|
||||
assert topics.include?(@topics["first"].find)
|
||||
|
||||
topics = Topic.find_all_by_approved(true)
|
||||
assert_equal 1, topics.size
|
||||
assert topics.include?(@topics["second"].find)
|
||||
end
|
||||
|
||||
def test_find_by_nil_attribute
|
||||
topic = Topic.find_by_last_read nil
|
||||
|
|
Loading…
Reference in New Issue