diff --git a/actionpack/CHANGELOG b/actionpack/CHANGELOG index d373c02a64..8b418ac92b 100644 --- a/actionpack/CHANGELOG +++ b/actionpack/CHANGELOG @@ -1,5 +1,7 @@ *SVN* +* Added that nil options are not included in tags, so tag("p", :ignore => nil) now returns
not but that tag("p", :ignore => "") still includes it #1465 [michael@schuerig.de] + * Fixed that UrlHelper#link_to_unless/link_to_if used html_escape on the name if no link was to be applied. This is unnecessary and breaks its use with images #1649 [joergd@pobox.com] * Added even more goodies to script.aculo.us #1677 [Thomas Fuchs] diff --git a/actionpack/lib/action_view/helpers/tag_helper.rb b/actionpack/lib/action_view/helpers/tag_helper.rb index 1753ef9acf..40fd72d23f 100644 --- a/actionpack/lib/action_view/helpers/tag_helper.rb +++ b/actionpack/lib/action_view/helpers/tag_helper.rb @@ -24,8 +24,9 @@ module ActionView private def tag_options(options) - unless options.empty? - " " + options.symbolize_keys.map { |key, value| + cleaned_options = options.reject { |key, value| value.nil? } + unless cleaned_options.empty? + " " + cleaned_options.symbolize_keys.map { |key, value| %(#{key}="#{html_escape(value.to_s)}") }.sort.join(" ") end diff --git a/actionpack/test/template/form_helper_test.rb b/actionpack/test/template/form_helper_test.rb index b76f21d80b..1b9df865f3 100644 --- a/actionpack/test/template/form_helper_test.rb +++ b/actionpack/test/template/form_helper_test.rb @@ -37,7 +37,7 @@ class FormHelperTest < Test::Unit::TestCase '', password_field("post", "title") ) assert_equal( - '', password_field("person", "name") + '', password_field("person", "name") ) end @@ -71,7 +71,7 @@ class FormHelperTest < Test::Unit::TestCase check_box("post", "secret") ) assert_equal( - '', + '', check_box("post", "secret" ,{"checked"=>"checked"}) ) @post.secret = true @@ -80,7 +80,7 @@ class FormHelperTest < Test::Unit::TestCase check_box("post", "secret") ) end - + def test_check_box_with_explicit_checked_and_unchecked_values @post.secret = "on" assert_equal( diff --git a/actionpack/test/template/form_tag_helper_test.rb b/actionpack/test/template/form_tag_helper_test.rb index 7a666271c1..6295aa91b6 100644 --- a/actionpack/test/template/form_tag_helper_test.rb +++ b/actionpack/test/template/form_tag_helper_test.rb @@ -22,7 +22,7 @@ class FormTagHelperTest < Test::Unit::TestCase end def test_form_tag - actual = form_tag + actual = form_tag expected = %(