kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Shush various interpreter warnings

Browse source
This commit is contained in:
George Claghorn 2018-10-17 12:42:54 -04:00
parent 7903e3ada8
commit 2b09cbbe44
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/models/action_mailbox/inbound_email/message_id.rb
View file

@ -13,7 +13,7 @@ module ActionMailbox::InboundEmail::MessageId
private
def extract_message_id(raw_email)
mail_from_source(raw_email.read).message_id
rescue => e
rescue
# FIXME: Add logging with "Couldn't extract Message ID, so will generating a new random ID instead"
end
end

2
lib/action_mailbox/base.rb
View file

@ -49,7 +49,7 @@ class ActionMailbox::Base
inbound_email.processing!
yield
inbound_email.delivered! unless inbound_email.bounced?
rescue => exception
rescue
inbound_email.failed!
raise
end

2
lib/action_mailbox/test_helper.rb
View file

@ -9,7 +9,7 @@ module ActionMailbox
end
def create_inbound_email_from_mail(status: :processing, **mail_options)
raw_email = Tempfile.new.tap { |raw_email| raw_email.write Mail.new(mail_options).to_s }
raw_email = Tempfile.new.tap { |io| io.write Mail.new(mail_options).to_s }
create_inbound_email(raw_email, status: status)
end

2
test/unit/mailbox/routing_test.rb
View file

@ -23,7 +23,7 @@ class ActionMailbox::Base::RoutingTest < ActiveSupport::TestCase
test "delayed routing" do
perform_enqueued_jobs only: ActionMailbox::RoutingJob do
another_inbound_email = create_inbound_email_from_fixture("welcome.eml", status: :pending)
create_inbound_email_from_fixture "welcome.eml", status: :pending
assert_equal "Discussion: Let's debate these attachments", $processed
end
end