From 6a013cf5e745f4e4da012959bea0b10eb54ede7f Mon Sep 17 00:00:00 2001 From: Yasuo Honda Date: Sun, 2 Jan 2022 12:55:53 +0900 Subject: [PATCH] SQLite3Adapter supports default function since #43993 then no need to skip tests added via #43296 Related https://github.com/rails/rails/pull/43296 https://github.com/rails/rails/pull/43993 --- activerecord/test/cases/dirty_test.rb | 42 +++++++++++++-------------- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/activerecord/test/cases/dirty_test.rb b/activerecord/test/cases/dirty_test.rb index 0850b61925..e2bce3d2e9 100644 --- a/activerecord/test/cases/dirty_test.rb +++ b/activerecord/test/cases/dirty_test.rb @@ -941,35 +941,33 @@ class DirtyTest < ActiveRecord::TestCase assert_not_predicate person, :changed? end - unless current_adapter?(:SQLite3Adapter) - test "partial insert off with unchanged default function attribute" do - with_partial_writes Aircraft, false do - aircraft = Aircraft.new(name: "Boeing") - assert_equal "Boeing", aircraft.name + test "partial insert off with unchanged default function attribute" do + with_partial_writes Aircraft, false do + aircraft = Aircraft.new(name: "Boeing") + assert_equal "Boeing", aircraft.name - aircraft.save! - expected_manufactured_at = Time.now - aircraft.reload + aircraft.save! + expected_manufactured_at = Time.now + aircraft.reload - assert_equal "Boeing", aircraft.name - assert_in_delta expected_manufactured_at, aircraft.manufactured_at, 1 - end + assert_equal "Boeing", aircraft.name + assert_in_delta expected_manufactured_at, aircraft.manufactured_at, 1 end + end - test "partial insert off with changed default function attribute" do - with_partial_writes Aircraft, false do - manufactured_at = 1.years.ago - aircraft = Aircraft.new(name: "Boeing2", manufactured_at: manufactured_at) + test "partial insert off with changed default function attribute" do + with_partial_writes Aircraft, false do + manufactured_at = 1.years.ago + aircraft = Aircraft.new(name: "Boeing2", manufactured_at: manufactured_at) - assert_equal "Boeing2", aircraft.name - assert_equal manufactured_at.to_i, aircraft.manufactured_at.to_i + assert_equal "Boeing2", aircraft.name + assert_equal manufactured_at.to_i, aircraft.manufactured_at.to_i - aircraft.save! - aircraft.reload + aircraft.save! + aircraft.reload - assert_equal "Boeing2", aircraft.name - assert_equal manufactured_at.utc.strftime("%Y-%m-%d %H:%M:%S"), aircraft.manufactured_at.strftime("%Y-%m-%d %H:%M:%S") - end + assert_equal "Boeing2", aircraft.name + assert_equal manufactured_at.utc.strftime("%Y-%m-%d %H:%M:%S"), aircraft.manufactured_at.strftime("%Y-%m-%d %H:%M:%S") end end