From 2c15e00a2c3efb2634aa299e778751893d93921f Mon Sep 17 00:00:00 2001 From: Nicholas Stuart Date: Tue, 24 Aug 2021 10:09:07 -0700 Subject: [PATCH] Address PR comments. --- activesupport/CHANGELOG.md | 2 ++ guides/source/caching_with_rails.md | 1 + 2 files changed, 3 insertions(+) diff --git a/activesupport/CHANGELOG.md b/activesupport/CHANGELOG.md index bb3772cf45..78be5e5099 100644 --- a/activesupport/CHANGELOG.md +++ b/activesupport/CHANGELOG.md @@ -3,6 +3,8 @@ Previously, if you provided a `error_handler` to `redis_cache_store`, any errors thrown by the error handler would be rescued and logged only. Removed the `rescue` clause from `handle_exception` to allow these to be thrown. + + *Nicholas A. Stuart* * Allow entirely opting out of deprecation warnings. diff --git a/guides/source/caching_with_rails.md b/guides/source/caching_with_rails.md index 18d933bedd..9f7ec4f0be 100644 --- a/guides/source/caching_with_rails.md +++ b/guides/source/caching_with_rails.md @@ -528,6 +528,7 @@ config.cache_store = :redis_cache_store, { url: cache_servers, read_timeout: 0.2, # Defaults to 1 second write_timeout: 0.2, # Defaults to 1 second reconnect_attempts: 1, # Defaults to 0 + error_handler: -> (method:, returning:, exception:) { # Report errors to Sentry as warnings Raven.capture_exception exception, level: 'warning',