kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Fix regex to strip quotations from hstore values

Browse source 
Previously regex did not strip quotation marks where hstore values were multi-line strings.
This commit is contained in:
jlxw 2013-02-05 16:49:33 +08:00 committed by Rafael Mendonça França
parent bad0b81a07
commit 2c9304891e
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
activerecord/lib/active_record/connection_adapters/postgresql/cast.rb
View file

@ -30,8 +30,8 @@ module ActiveRecord
nil
elsif String === string
Hash[string.scan(HstorePair).map { |k,v|
v = v.upcase == 'NULL' ? nil : v.gsub(/^"(.*)"$/,'\1').gsub(/\\(.)/, '\1')
k = k.gsub(/^"(.*)"$/,'\1').gsub(/\\(.)/, '\1')
v = v.upcase == 'NULL' ? nil : v.gsub(/\A"(.*)"\Z/m,'\1').gsub(/\\(.)/, '\1')
k = k.gsub(/\A"(.*)"\Z/m,'\1').gsub(/\\(.)/, '\1')
[k,v]
}]
else

4
activerecord/test/cases/adapters/postgresql/hstore_test.rb
View file

@ -189,6 +189,10 @@ class PostgresqlHstoreTest < ActiveRecord::TestCase
assert_cycle('ca' => 'cà', 'ac' => 'àc')
end
def test_multiline
assert_cycle("a\nb" => "c\nd")
end
private
def assert_cycle hash
# test creation